[cr141] Updated hermetic Windows SDK to 10.0.26100.4654
The job has already been run for this case. Chromium changes: https://chromium.googlesource.com/chromium/src/+/ef698db4741700349ada03200cea4269a5f1e174 commit ef698db4741700349ada03200cea4269a5f1e174 Author: Devon Loehr <dloehr@google.com> Date: Thu Aug 14 07:30:28 2025 -0700 Update Supported Windows SDK to 10.0.26100.4654 This updates the windows toolchain package used to build chromium to the newest version. This is a minor version bump, so it's pretty smooth: no compilation failures, and few places that need to be updated. There were no changes to mc or idl output. This SDK version undoes the problematic linking of d3dcompiler_47.dll (crbug.com/372059340), so the packaging process is simpler and we are now using the most recent version of that dll. ----------------------------------------------------------------- Instructions to reproduce: These instructions are best done on a fresh VM. Make sure to uninstall any existing installations of Visual Studio and any existing SDK installations before starting. 1. Install git for windows from their website, with the default settings (https://git-scm.com/downloads/win) 2. Install depot_tools following the instructions on their webpage (https://commondatastorage.googleapis.com/chrome-infra-docs/flat/depot_tools/docs/html/depot_tools_tutorial.html#_setting_up) 3. Download Visual Studio Professional (Free Trial) from the official site (https://visualstudio.microsoft.com/downloads/) 4. Run the VS installer with the following arguments: ``` $ VisualStudioSetup.exe --add Microsoft.VisualStudio.Workload.NativeDesktop --add Microsoft.VisualStudio.Component.VC.ATLMFC --add Microsoft.VisualStudio.Component.VC.Tools.ARM64 --add Microsoft.VisualStudio.Component.VC.MFC.ARM64 --includeRecommended --passive ``` 5. Open the VS installer (from the start menu), click “Modify”, and uninstall any existing SDK versions (search for “windows sdk”). 6. Open “Add or Remove Programs” and make sure there are no SDK versions installed; remove them if so (search for “windows software development kit”). 7. Download SDK Version 10.0.26100.4654 from the official site (https://developer.microsoft.com/en-us/windows/downloads/windows-sdk/). Note that if a more recent version has been released, it may no longer be available. 8. Run the SDK installer with default settings, except disable “insights”. 9. Run the packaging script from depot_tools, e.g $ vpython3 depot_tools\win_toolchain\package_from_installed.py 2022 -w 10.0.26100.0 Link to packaging script version used for packaging: https://source.chromium.org/chromium/chromium/tools/depot_tools/+/main:win_toolchain/package_from_installed.py;drc=1867bb56c124ea7e6d8cdc023244b31a2c41bf1f This resulted in the final package with hash e4305f407e. Bug: 433818340 Change-Id: Ic4733efe9607f92034da66114354b599e31398c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6840817 Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Devon Loehr <dloehr@google.com> Cr-Commit-Position: refs/heads/main@{#1501375}
This commit is contained in:
@@ -1192,7 +1192,7 @@ Object.defineProperty(Config.prototype, 'defaultOptions', {
|
||||
// Use hermetic toolchain only internally.
|
||||
env.USE_BRAVE_HERMETIC_TOOLCHAIN = '1'
|
||||
env.DEPOT_TOOLS_WIN_TOOLCHAIN = '1'
|
||||
env.GYP_MSVS_HASH_68a20d6dee = '6c25999c85'
|
||||
env.GYP_MSVS_HASH_e4305f407e = '7a2a21dbe7'
|
||||
env.DEPOT_TOOLS_WIN_TOOLCHAIN_BASE_URL = `${this.internalDepsUrl}/windows-hermetic-toolchain/`
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user