Fixed icons at CTA menu (#29688)

* Fixed icons at CTA menu

Resolves https://github.com/brave/brave-browser/issues/46811

Chromium change:
https://source.chromium.org/chromium/chromium/src/+/fa431a3660de796f7aa18130fd8a6da39f1cc1d7

	[Icon Button] Migrate app menu icon buttons

	Migrated the app menu top row icons from ChromeImageButtons to Material Buttons. The highlight (ripple) is now a perfect circle instead of rectangle.

	Bug: 405189559
	Change-Id: I0376bf0ecf7f5b734dad2d7e8c69200834c54248
	Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6477118

android/brave_java_resources.gni

@@ -23,7 +23,6 @@ brave_java_resources = [
   "java/res/drawable-hdpi/btn_brave.png",
   "java/res/drawable-hdpi/btn_brave_off.png",
   "java/res/drawable-hdpi/btn_delete_24dp.png",
-  "java/res/drawable-hdpi/btn_info.png",
   "java/res/drawable-hdpi/btn_left.png",
   "java/res/drawable-hdpi/btn_mic.png",
   "java/res/drawable-hdpi/btn_right.png",
@@ -33,7 +32,6 @@ brave_java_resources = [
   "java/res/drawable-hdpi/btn_tabstrip_switch_normal.png",
   "java/res/drawable-hdpi/btn_tabswitcher_modern.png",
   "java/res/drawable-hdpi/btn_toolbar_home.png",
-  "java/res/drawable-hdpi/btn_toolbar_reload.png",
   "java/res/drawable-hdpi/camera.png",
   "java/res/drawable-hdpi/check.png",
   "java/res/drawable-hdpi/checkbox.png",
@@ -46,7 +44,6 @@ brave_java_resources = [
   "java/res/drawable-hdpi/ic_delete_white_24dp.png",
   "java/res/drawable-hdpi/ic_expand_less_black_24dp.png",
   "java/res/drawable-hdpi/ic_expand_more_black_24dp.png",
-  "java/res/drawable-hdpi/ic_file_download_white_24dp.png",
   "java/res/drawable-hdpi/ic_onboarding_bottom_leaf.png",
   "java/res/drawable-hdpi/ic_onboarding_top_leaf.png",
   "java/res/drawable-hdpi/icon_validated_notification.png",
@@ -68,7 +65,6 @@ brave_java_resources = [
   "java/res/drawable-mdpi/btn_brave.png",
   "java/res/drawable-mdpi/btn_brave_off.png",
   "java/res/drawable-mdpi/btn_delete_24dp.png",
-  "java/res/drawable-mdpi/btn_info.png",
   "java/res/drawable-mdpi/btn_left.png",
   "java/res/drawable-mdpi/btn_mic.png",
   "java/res/drawable-mdpi/btn_right.png",
@@ -78,7 +74,6 @@ brave_java_resources = [
   "java/res/drawable-mdpi/btn_tabstrip_switch_normal.png",
   "java/res/drawable-mdpi/btn_tabswitcher_modern.png",
   "java/res/drawable-mdpi/btn_toolbar_home.png",
-  "java/res/drawable-mdpi/btn_toolbar_reload.png",
   "java/res/drawable-mdpi/camera.png",
   "java/res/drawable-mdpi/check.png",
   "java/res/drawable-mdpi/checkbox.png",
@@ -91,7 +86,6 @@ brave_java_resources = [
   "java/res/drawable-mdpi/ic_delete_white_24dp.png",
   "java/res/drawable-mdpi/ic_expand_less_black_24dp.png",
   "java/res/drawable-mdpi/ic_expand_more_black_24dp.png",
-  "java/res/drawable-mdpi/ic_file_download_white_24dp.png",
   "java/res/drawable-mdpi/ic_onboarding_bottom_leaf.png",
   "java/res/drawable-mdpi/ic_onboarding_top_leaf.png",
   "java/res/drawable-mdpi/icon_validated_notification.png",
@@ -135,7 +129,6 @@ brave_java_resources = [
   "java/res/drawable-xhdpi/btn_brave.png",
   "java/res/drawable-xhdpi/btn_brave_off.png",
   "java/res/drawable-xhdpi/btn_delete_24dp.png",
-  "java/res/drawable-xhdpi/btn_info.png",
   "java/res/drawable-xhdpi/btn_left.png",
   "java/res/drawable-xhdpi/btn_mic.png",
   "java/res/drawable-xhdpi/btn_right.png",
@@ -145,7 +138,6 @@ brave_java_resources = [
   "java/res/drawable-xhdpi/btn_tabstrip_switch_normal.png",
   "java/res/drawable-xhdpi/btn_tabswitcher_modern.png",
   "java/res/drawable-xhdpi/btn_toolbar_home.png",
-  "java/res/drawable-xhdpi/btn_toolbar_reload.png",
   "java/res/drawable-xhdpi/camera.png",
   "java/res/drawable-xhdpi/check.png",
   "java/res/drawable-xhdpi/checkbox.png",
@@ -158,7 +150,6 @@ brave_java_resources = [
   "java/res/drawable-xhdpi/ic_delete_white_24dp.png",
   "java/res/drawable-xhdpi/ic_expand_less_black_24dp.png",
   "java/res/drawable-xhdpi/ic_expand_more_black_24dp.png",
-  "java/res/drawable-xhdpi/ic_file_download_white_24dp.png",
   "java/res/drawable-xhdpi/ic_onboarding_bottom_leaf.png",
   "java/res/drawable-xhdpi/ic_onboarding_top_leaf.png",
   "java/res/drawable-xhdpi/icon_validated_notification.png",
@@ -180,7 +171,6 @@ brave_java_resources = [
   "java/res/drawable-xxhdpi/btn_brave.png",
   "java/res/drawable-xxhdpi/btn_brave_off.png",
   "java/res/drawable-xxhdpi/btn_delete_24dp.png",
-  "java/res/drawable-xxhdpi/btn_info.png",
   "java/res/drawable-xxhdpi/btn_left.png",
   "java/res/drawable-xxhdpi/btn_mic.png",
   "java/res/drawable-xxhdpi/btn_right.png",
@@ -190,7 +180,6 @@ brave_java_resources = [
   "java/res/drawable-xxhdpi/btn_tabstrip_switch_normal.png",
   "java/res/drawable-xxhdpi/btn_tabswitcher_modern.png",
   "java/res/drawable-xxhdpi/btn_toolbar_home.png",
-  "java/res/drawable-xxhdpi/btn_toolbar_reload.png",
   "java/res/drawable-xxhdpi/camera.png",
   "java/res/drawable-xxhdpi/check.png",
   "java/res/drawable-xxhdpi/checkbox.png",
@@ -203,7 +192,6 @@ brave_java_resources = [
   "java/res/drawable-xxhdpi/ic_delete_white_24dp.png",
   "java/res/drawable-xxhdpi/ic_expand_less_black_24dp.png",
   "java/res/drawable-xxhdpi/ic_expand_more_black_24dp.png",
-  "java/res/drawable-xxhdpi/ic_file_download_white_24dp.png",
   "java/res/drawable-xxhdpi/ic_onboarding_bottom_leaf.png",
   "java/res/drawable-xxhdpi/ic_onboarding_top_leaf.png",
   "java/res/drawable-xxhdpi/icon_validated_notification.png",
@@ -225,7 +213,6 @@ brave_java_resources = [
   "java/res/drawable-xxxhdpi/btn_brave.png",
   "java/res/drawable-xxxhdpi/btn_brave_off.png",
   "java/res/drawable-xxxhdpi/btn_delete_24dp.png",
-  "java/res/drawable-xxxhdpi/btn_info.png",
   "java/res/drawable-xxxhdpi/btn_left.png",
   "java/res/drawable-xxxhdpi/btn_mic.png",
   "java/res/drawable-xxxhdpi/btn_right.png",
@@ -235,7 +222,6 @@ brave_java_resources = [
   "java/res/drawable-xxxhdpi/btn_tabstrip_switch_normal.png",
   "java/res/drawable-xxxhdpi/btn_tabswitcher_modern.png",
   "java/res/drawable-xxxhdpi/btn_toolbar_home.png",
-  "java/res/drawable-xxxhdpi/btn_toolbar_reload.png",
   "java/res/drawable-xxxhdpi/camera.png",
   "java/res/drawable-xxxhdpi/check.png",
   "java/res/drawable-xxxhdpi/checkbox.png",
@@ -247,7 +233,6 @@ brave_java_resources = [
   "java/res/drawable-xxxhdpi/ic_delete_white_24dp.png",
   "java/res/drawable-xxxhdpi/ic_expand_less_black_24dp.png",
   "java/res/drawable-xxxhdpi/ic_expand_more_black_24dp.png",
-  "java/res/drawable-xxxhdpi/ic_file_download_white_24dp.png",
   "java/res/drawable-xxxhdpi/ic_onboarding_bottom_leaf.png",
   "java/res/drawable-xxxhdpi/ic_onboarding_top_leaf.png",
   "java/res/drawable-xxxhdpi/icon_validated_notification.png",

build/commands/lib/util.js

@@ -1052,6 +1052,11 @@ const util = {
         'res',
       )
 
+      const uiAndroidResSource =
+          path.join(config.braveCoreDir, "ui", "android", "java", "res")
+      const uiAndroidResDest =
+          path.join(config.srcDir, "ui", "android", "java", "res")
+
       // Mapping for copying Brave's Android resource into chromium folder.
       const copyAndroidResourceMapping = {
         [androidTranslateResSource]: [androidTranslateResDest],
@@ -1073,6 +1078,7 @@ const util = {
         [androidBrowserHubInternalResSource]: [
           androidBrowserHubInternalResDest,
         ],
+        [uiAndroidResSource]: [uiAndroidResDest],
       }
 
       console.log('copy Android app icons and app resources')

chromium_presubmit_config.json5

@@ -81,8 +81,8 @@
     "CheckForRelativeIncludes": ["chromium_src/"],
     "CheckLongLines": [
       "components/p3a/metric_names\\.h",
-      "android/java/res/drawable/.*\\.xml",
       "android/java/res/values/.*\\.xml",
+      ".*/java/res/drawable/.*\\.xml",
     ],
     "CheckParseErrors": [
       ".*tsconfig\\.json",