Discharge7443/brave-core
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix memory leaks in BraveTabTest (#33670)

Browse Source
This commit is contained in:
Mikhail
2026-02-05 09:29:51 +00:00
committed by GitHub
parent 33196a77f7
commit 68a924f14f
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
browser/ui/views/tabs/brave_tab_unittest.cc
+6 -4
View File
@@ -224,8 +224,9 @@ TEST_F(BraveTabRenamingUnitTest, EnterKeyCommitsRename) {
SetCustomTitleForTab(
tab(), std::make_optional(std::u16string(kNewTitle))));
// Simulate pressing Enter key to commit the rename.
rename_textfield().OnEvent(new ui::KeyEvent(ui::EventType::kKeyPressed,
ui::VKEY_RETURN, ui::EF_NONE));
ui::KeyEvent enter_event(ui::EventType::kKeyPressed, ui::VKEY_RETURN,
ui::EF_NONE);
rename_textfield().OnEvent(&enter_event);
EXPECT_FALSE(in_renaming_mode());
EXPECT_FALSE(rename_textfield().GetVisible());
@@ -244,8 +245,9 @@ TEST_F(BraveTabRenamingUnitTest, EscapeKeyExitsRenameMode) {
EXPECT_CALL(*tab_slot_controller(), SetCustomTitleForTab(tab(), testing::_))
.Times(0);
// Simulate pressing Escape key to exit rename mode.
rename_textfield().OnEvent(new ui::KeyEvent(ui::EventType::kKeyPressed,
ui::VKEY_ESCAPE, ui::EF_NONE));
ui::KeyEvent escape_event(ui::EventType::kKeyPressed, ui::VKEY_ESCAPE,
ui::EF_NONE);
rename_textfield().OnEvent(&escape_event);
EXPECT_FALSE(in_renaming_mode());
EXPECT_FALSE(rename_textfield().GetVisible());