Discharge7443/brave-core
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[CodeHealth] Clang tidy browser with use-equals-default I

Browse Source 
This change corrects the constructors of several classes under
browser/, using clang-tidy's modernize-use-equals-default.
This commit is contained in:
Claudio DeSouza
2022-08-16 14:02:42 +01:00
parent 5596dbe780
commit 6acda02358
21 changed files with 28 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/brave_main_delegate_runtime_flags_browsertest.cc
+2 -2
View File
@@ -16,8 +16,8 @@
class BraveMainDelegateRuntimeFlagsBrowserTest : public PlatformBrowserTest {
public:
BraveMainDelegateRuntimeFlagsBrowserTest() {}
~BraveMainDelegateRuntimeFlagsBrowserTest() override {}
BraveMainDelegateRuntimeFlagsBrowserTest() = default;
~BraveMainDelegateRuntimeFlagsBrowserTest() override = default;
void SetUpCommandLine(base::CommandLine* command_line) override {
command_line->AppendSwitch(switches::kDisableDnsOverHttps);
browser/autocomplete/brave_autocomplete_scheme_classifier.cc
+2 -2
View File
@@ -28,8 +28,8 @@ BraveAutocompleteSchemeClassifier::BraveAutocompleteSchemeClassifier(
#endif
}
BraveAutocompleteSchemeClassifier::~BraveAutocompleteSchemeClassifier() {
}
BraveAutocompleteSchemeClassifier::~BraveAutocompleteSchemeClassifier() =
default;
// Without this override, typing in brave:// URLs will search Google
metrics::OmniboxInputType
browser/binance/binance_service_factory.cc
+1 -2
View File
@@ -27,8 +27,7 @@ BinanceServiceFactory::BinanceServiceFactory()
BrowserContextDependencyManager::GetInstance()) {
}
BinanceServiceFactory::~BinanceServiceFactory() {
}
BinanceServiceFactory::~BinanceServiceFactory() = default;
KeyedService* BinanceServiceFactory::BuildServiceInstanceFor(
content::BrowserContext* context) const {
browser/brave_adaptive_captcha/brave_adaptive_captcha_service_factory.cc
+2 -1
View File
@@ -80,7 +80,8 @@ BraveAdaptiveCaptchaServiceFactory::BraveAdaptiveCaptchaServiceFactory()
DependsOn(brave_rewards::RewardsServiceFactory::GetInstance());
}
BraveAdaptiveCaptchaServiceFactory::~BraveAdaptiveCaptchaServiceFactory() {}
BraveAdaptiveCaptchaServiceFactory::~BraveAdaptiveCaptchaServiceFactory() =
default;
KeyedService* BraveAdaptiveCaptchaServiceFactory::BuildServiceInstanceFor(
content::BrowserContext* context) const {
browser/brave_ads/background_helper/background_helper_mac.mm
+1 -1
View File
@@ -74,7 +74,7 @@ BackgroundHelperMac::BackgroundHelperMac() {
delegate_ = std::make_unique<BackgroundHelperDelegate>(this);
}
BackgroundHelperMac::~BackgroundHelperMac() {}
BackgroundHelperMac::~BackgroundHelperMac() = default;
bool BackgroundHelperMac::IsForeground() const {
return [[NSApplication sharedApplication] isActive];
browser/brave_ads/brave_ads_host.cc
+1 -1
View File
@@ -33,7 +33,7 @@ BraveAdsHost::BraveAdsHost(Profile* profile, content::WebContents* web_contents)
}
}
BraveAdsHost::~BraveAdsHost() {}
BraveAdsHost::~BraveAdsHost() = default;
void BraveAdsHost::MaybeTriggerAdViewedEvent(
const std::string& creative_instance_id,
browser/brave_ads/request_ads_enabled_api_browsertest.cc
+1 -1
View File
@@ -59,7 +59,7 @@ constexpr char kUserGestureRejectReason[] =
class RequestAdsEnabledApiTestBase : public InProcessBrowserTest {
public:
RequestAdsEnabledApiTestBase() {}
RequestAdsEnabledApiTestBase() = default;
void SetUpOnMainThread() override {
InProcessBrowserTest::SetUpOnMainThread();
browser/brave_browser_main_extra_parts.cc
+2 -4
View File
@@ -50,11 +50,9 @@ void RecordInitialP3AValues() {
} // namespace
BraveBrowserMainExtraParts::BraveBrowserMainExtraParts() {
}
BraveBrowserMainExtraParts::BraveBrowserMainExtraParts() = default;
BraveBrowserMainExtraParts::~BraveBrowserMainExtraParts() {
}
BraveBrowserMainExtraParts::~BraveBrowserMainExtraParts() = default;
void BraveBrowserMainExtraParts::PostBrowserStart() {
g_brave_browser_process->StartBraveServices();
browser/brave_browser_process.cc
+2 -2
View File
@@ -9,6 +9,6 @@
BraveBrowserProcess* g_brave_browser_process = nullptr;
BraveBrowserProcess::BraveBrowserProcess() {}
BraveBrowserProcess::BraveBrowserProcess() = default;
BraveBrowserProcess::~BraveBrowserProcess() {}
BraveBrowserProcess::~BraveBrowserProcess() = default;
browser/brave_browser_process_impl.cc
+1 -1
View File
@@ -105,7 +105,7 @@ void InitSystemRequestHandlerCallback() {
using content::BrowserThread;
BraveBrowserProcessImpl::~BraveBrowserProcessImpl() {}
BraveBrowserProcessImpl::~BraveBrowserProcessImpl() = default;
BraveBrowserProcessImpl::BraveBrowserProcessImpl(StartupData* startup_data)
: BrowserProcessImpl(startup_data) {
browser/brave_content_browser_client.cc
+2 -2
View File
@@ -402,9 +402,9 @@ void MaybeBindSkusSdkImpl(
} // namespace
BraveContentBrowserClient::BraveContentBrowserClient() {}
BraveContentBrowserClient::BraveContentBrowserClient() = default;
BraveContentBrowserClient::~BraveContentBrowserClient() {}
BraveContentBrowserClient::~BraveContentBrowserClient() = default;
std::unique_ptr<content::BrowserMainParts>
BraveContentBrowserClient::CreateBrowserMainParts(bool is_integration_test) {
browser/brave_content_browser_client_unittest.cc
+1 -1
View File
@@ -33,7 +33,7 @@ namespace extensions {
class BraveWalleBrowserClientUnitTest
: public ChromeRenderViewHostTestHarness {
public:
BraveWalleBrowserClientUnitTest() {}
BraveWalleBrowserClientUnitTest() = default;
BraveWalleBrowserClientUnitTest(const BraveWalleBrowserClientUnitTest&) =
delete;
BraveWalleBrowserClientUnitTest& operator=(
browser/brave_drm_tab_helper.cc
+1 -1
View File
@@ -56,7 +56,7 @@ BraveDrmTabHelper::BraveDrmTabHelper(content::WebContents* contents)
observer_.Observe(updater);
}
BraveDrmTabHelper::~BraveDrmTabHelper() {}
BraveDrmTabHelper::~BraveDrmTabHelper() = default;
// static
void BraveDrmTabHelper::BindBraveDRM(
browser/brave_federated/brave_federated_service_factory.cc
+1 -1
View File
@@ -38,7 +38,7 @@ BraveFederatedServiceFactory::BraveFederatedServiceFactory()
"BraveFederatedService",
BrowserContextDependencyManager::GetInstance()) {}
BraveFederatedServiceFactory::~BraveFederatedServiceFactory() {}
BraveFederatedServiceFactory::~BraveFederatedServiceFactory() = default;
KeyedService* BraveFederatedServiceFactory::BuildServiceInstanceFor(
content::BrowserContext* context) const {
browser/brave_shields/ad_block_pref_service_factory.cc
+1 -1
View File
@@ -31,7 +31,7 @@ AdBlockPrefServiceFactory::AdBlockPrefServiceFactory()
"AdBlockPrefService",
BrowserContextDependencyManager::GetInstance()) {}
AdBlockPrefServiceFactory::~AdBlockPrefServiceFactory() {}
AdBlockPrefServiceFactory::~AdBlockPrefServiceFactory() = default;
KeyedService* AdBlockPrefServiceFactory::BuildServiceInstanceFor(
content::BrowserContext* context) const {
browser/brave_shields/ad_block_service_browsertest.cc
+2 -2
View File
@@ -87,7 +87,7 @@ AdBlockServiceTest::AdBlockServiceTest() {
brave_shields::SetDefaultAdBlockComponentIdAndBase64PublicKeyForTest(
kDefaultAdBlockComponentTestId, kDefaultAdBlockComponentTest64PublicKey);
}
AdBlockServiceTest::~AdBlockServiceTest() {}
AdBlockServiceTest::~AdBlockServiceTest() = default;
void AdBlockServiceTest::SetUpOnMainThread() {
ExtensionBrowserTest::SetUpOnMainThread();
@@ -2363,7 +2363,7 @@ class CookieListPrefObserver {
base::BindRepeating(&CookieListPrefObserver::OnUpdated,
base::Unretained(this)));
}
~CookieListPrefObserver() {}
~CookieListPrefObserver() = default;
CookieListPrefObserver(const CookieListPrefObserver& other) = delete;
CookieListPrefObserver& operator=(const CookieListPrefObserver& other) =
browser/brave_shields/brave_shields_web_contents_observer_browsertest.cc
+1 -1
View File
@@ -51,7 +51,7 @@ class TestBraveShieldsWebContentsObserver
class BraveShieldsWebContentsObserverBrowserTest : public InProcessBrowserTest {
public:
BraveShieldsWebContentsObserverBrowserTest() {}
BraveShieldsWebContentsObserverBrowserTest() = default;
void SetUpOnMainThread() override {
InProcessBrowserTest::SetUpOnMainThread();
browser/brave_shields/domain_block_page_browsertest.cc
+1 -1
View File
@@ -33,7 +33,7 @@ using brave_shields::features::kBraveDomainBlock;
class DomainBlockTestBase : public AdBlockServiceTest {
public:
DomainBlockTestBase() {}
DomainBlockTestBase() = default;
DomainBlockTestBase(const DomainBlockTestBase&) = delete;
DomainBlockTestBase& operator=(const DomainBlockTestBase&) = delete;
browser/brave_stats/brave_stats_updater.cc
+1 -1
View File
@@ -117,7 +117,7 @@ BraveStatsUpdater::BraveStatsUpdater(PrefService* pref_service)
}
}
BraveStatsUpdater::~BraveStatsUpdater() {}
BraveStatsUpdater::~BraveStatsUpdater() = default;
void BraveStatsUpdater::OnProfileAdded(Profile* profile) {
if (profile == ProfileManager::GetPrimaryUserProfile()) {
browser/brave_stats/brave_stats_updater_params.cc
+1 -1
View File
@@ -57,7 +57,7 @@ BraveStatsUpdaterParams::BraveStatsUpdaterParams(
LoadPrefs();
}
BraveStatsUpdaterParams::~BraveStatsUpdaterParams() {}
BraveStatsUpdaterParams::~BraveStatsUpdaterParams() = default;
std::string BraveStatsUpdaterParams::GetDailyParam() const {
return BooleanToString(
browser/brave_stats/brave_stats_updater_unittest.cc
+1 -1
View File
@@ -55,7 +55,7 @@ class BraveStatsUpdaterTest : public testing::Test {
shared_url_loader_factory_(
base::MakeRefCounted<network::WeakWrapperSharedURLLoaderFactory>(
&url_loader_factory_)) {}
~BraveStatsUpdaterTest() override {}
~BraveStatsUpdaterTest() override = default;
void SetUp() override {
#if BUILDFLAG(IS_ANDROID)