Discharge7443/brave-core
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

add codeowner for sources.gni (#25351)

Browse Source 
Add codeowner and docs for sources.gni
Fixes https://github.com/brave/brave-browser/issues/40732
This commit is contained in:
Brian Johnson
2024-08-28 17:13:26 +02:00
committed by GitHub
parent cf1f967bbc
commit 717a4ca92a
2 changed files with 8 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.github/CODEOWNERS
+5
View File
@@ -17,6 +17,11 @@ browser/brave_browser_process.h @bridiver
components/brave_component_updater/browser/brave_component.h @bridiver @antonok-edm
components/brave_component_updater/browser/local_data_files_observer.h @bridiver @antonok-edm
# sources.gni - see docs/gni_sources.md
**/sources.gni @brave/sources-gni-reviewers
**/*_sources.gni @brave/sources-gni-reviewers
docs/gni_sources.md @brave/sources-gni-reviewers
# Renderer code
**/renderer/**/* @brave/renderer-reviewers
docs/gni_sources.md
+3
View File
@@ -0,0 +1,3 @@
Use of sources.gni should be limited to sources that would otherwise have circular dependencies that cannot be easily resolved, in other cases files should be added a new or existing BUILD.gn targets. The chromium ios code is a good model for separating out dependencies and sometimes makes use of interface/implementation patterns. A good example in desktop/android code is //chrome/browser/profiles target [https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/profiles/BUILD.gn;l=8](https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/profiles/BUILD.gn;l=8) which has a minimal set of dependencies and the bulk of the implementation that would likely trigger a lot of circular deps is in profile_impl.cc in the //chrome/browser target. This reduces the number of sources/targets that either depend on //chrome/browser or have to be added to //chrome/browser sources list. Other strategies used to break //chrome dependencies in components can also sometimes be applied to //brave/browser code to avoid circular dependencies [https://www.chromium.org/developers/design-documents/cookbook/#dependency-inversion](https://www.chromium.org/developers/design-documents/cookbook/#dependency-inversion). Do not use `check_includes = false`.
This does not mean that you cannot use sources.gni to inject sources into existing targets, but please try to avoid it when practical.