Discharge7443/brave-core
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[ads][CodeHealth] Use get() instead of &* to extract raw pointers (#35805)

Browse Source 
Use the idiomatic Chromium form `.get()` to extract a raw pointer from
smart pointers (mojo::StructPtr, std::unique_ptr, base::ScopedFILE)
rather than the non-idiomatic `&*` dereference-and-address pattern. The
three `raw_ref` sites are left unchanged because `raw_ref::get()` returns
a reference, not a pointer, so `&*` is the correct form there.

No behavioral changes.
This commit is contained in:
Terry Mancey
2026-04-23 00:50:10 +00:00
committed by GitHub
parent 14d076b97f
commit 71dbdc3ace
5 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
components/brave_ads/core/internal/ads_impl.cc
+2 -2
View File
@@ -378,7 +378,7 @@ void AdsImpl::SuccessfullyInitialized(mojom::WalletInfoPtr mojom_wallet,
std::optional<WalletInfo> wallet;
if (mojom_wallet) {
wallet = CreateWalletFromRecoverySeed(&*mojom_wallet);
wallet = CreateWalletFromRecoverySeed(mojom_wallet.get());
if (!wallet) {
BLOG(0, "Invalid wallet");
return FailedToInitialize(std::move(callback));
@@ -415,7 +415,7 @@ void AdsImpl::LoadClientStateCallback(mojom::WalletInfoPtr mojom_wallet,
std::optional<WalletInfo> wallet;
if (mojom_wallet) {
wallet = CreateWalletFromRecoverySeed(&*mojom_wallet);
wallet = CreateWalletFromRecoverySeed(mojom_wallet.get());
if (!wallet) {
BLOG(0, "Invalid wallet");
return FailedToInitialize(std::move(callback));
components/brave_ads/core/internal/common/resources/resource_util_impl.h
+1 -1
View File
@@ -40,7 +40,7 @@ std::optional<T> LoadAndParseResourceComponentOnBackgroundThread(
std::string content;
const base::ScopedFILE scoped_file(base::FileToFILE(std::move(file), "rb"));
if (!base::ReadStreamToString(&*scoped_file, &content)) {
if (!base::ReadStreamToString(scoped_file.get(), &content)) {
return std::nullopt;
}
components/brave_ads/core/internal/serving/eligible_ads/exclusion_rules/subdivision_targeting_exclusion_rule_unittest.cc
+1 -1
View File
@@ -110,7 +110,7 @@ class BraveAdsSubdivisionTargetingExclusionRuleTest
subdivision_targeting_ = std::make_unique<SubdivisionTargeting>();
subdivision_ = std::make_unique<Subdivision>();
subdivision_->AddObserver(&*subdivision_targeting_);
subdivision_->AddObserver(subdivision_targeting_.get());
exclusion_rule_ = std::make_unique<SubdivisionTargetingExclusionRule>(
*subdivision_targeting_);
}
components/brave_ads/core/internal/targeting/geographical/subdivision/subdivision_targeting_unittest.cc
+1 -1
View File
@@ -31,7 +31,7 @@ class BraveAdsSubdivisionTargetingTest : public test::TestBase {
subdivision_targeting_ = std::make_unique<SubdivisionTargeting>();
subdivision_ = std::make_unique<Subdivision>();
subdivision_->AddObserver(&*subdivision_targeting_);
subdivision_->AddObserver(subdivision_targeting_.get());
}
void MockHttpOkUrlResponse(const std::string& country_code,
components/brave_ads/core/internal/test/ads_observer_test_util.cc
+1 -1
View File
@@ -16,7 +16,7 @@ namespace brave_ads::test {
AdsObserverMock* MockAdsObserver() {
std::unique_ptr<AdsObserverMock> ads_observer_mock =
std::make_unique<AdsObserverMock>();
AdsObserverMock* const ads_observer_mock_ptr = &*ads_observer_mock;
AdsObserverMock* const ads_observer_mock_ptr = ads_observer_mock.get();
// `AdsNotifierManager` takes ownership of `ads_observer_mock`.
AdsNotifierManager::GetInstance().AddObserver(std::move(ads_observer_mock));