[cr137] [Android] Changes for saveOffline buttons move
Chromium change: https://chromium.googlesource.com/chromium/src/+/a3b80168e9abfa063071cc10ab487300c708856f [Toolbar] Moved click/longClick listeners for bookmark and saveOffline buttons to location bar classes. * Moved onLongClick for saveOffline and bookmark button to LocationBarLayoutTablet since this has simple implementation. * Moved onClick for saveOffline and bookmark button to LocationBarCoordinator Change-Id: I4b97d9209fd04f761e93fe393efe7e0d10f6e0b9
This commit is contained in:
@@ -92,7 +92,8 @@ public class BraveLocationBarCoordinator extends LocationBarCoordinator {
|
||||
Supplier<Integer> bottomWindowPaddingSupplier,
|
||||
@Nullable OnLongClickListener onLongClickListener,
|
||||
@Nullable BrowserControlsStateProvider browserControlsStateProvider,
|
||||
boolean isToolbarPositionCustomizationEnabled) {
|
||||
boolean isToolbarPositionCustomizationEnabled,
|
||||
@NonNull OfflineDownloader offlineDownloader) {
|
||||
super(
|
||||
locationBarLayout,
|
||||
autocompleteAnchorView,
|
||||
@@ -129,7 +130,8 @@ public class BraveLocationBarCoordinator extends LocationBarCoordinator {
|
||||
: 0),
|
||||
onLongClickListener,
|
||||
browserControlsStateProvider,
|
||||
isToolbarPositionCustomizationEnabled);
|
||||
isToolbarPositionCustomizationEnabled,
|
||||
offlineDownloader);
|
||||
|
||||
if (mUrlBar != null) {
|
||||
((UrlBar) mUrlBar).setSelectAllOnFocus(true);
|
||||
|
||||
@@ -60,7 +60,8 @@ public class BraveLocationBarMediator extends LocationBarMediator {
|
||||
@NonNull BooleanSupplier isToolbarMicEnabledSupplier,
|
||||
@NonNull OmniboxSuggestionsDropdownEmbedderImpl dropdownEmbedder,
|
||||
@Nullable ObservableSupplier<TabModelSelector> tabModelSelectorSupplier,
|
||||
@Nullable BrowserControlsStateProvider browserControlsStateProvider) {
|
||||
@Nullable BrowserControlsStateProvider browserControlsStateProvider,
|
||||
@NonNull LocationBarCoordinator.OfflineDownloader offlineDownloader) {
|
||||
super(
|
||||
context,
|
||||
locationBarLayout,
|
||||
@@ -79,7 +80,8 @@ public class BraveLocationBarMediator extends LocationBarMediator {
|
||||
isToolbarMicEnabledSupplier,
|
||||
dropdownEmbedder,
|
||||
tabModelSelectorSupplier,
|
||||
browserControlsStateProvider);
|
||||
browserControlsStateProvider,
|
||||
offlineDownloader);
|
||||
}
|
||||
|
||||
public static Class<OmniboxUma> getOmniboxUmaClass() {
|
||||
|
||||
@@ -101,7 +101,6 @@ import org.chromium.chrome.browser.toolbar.menu_button.BraveMenuButtonCoordinato
|
||||
import org.chromium.chrome.browser.toolbar.menu_button.MenuButtonCoordinator;
|
||||
import org.chromium.chrome.browser.toolbar.reload_button.ReloadButtonCoordinator;
|
||||
import org.chromium.chrome.browser.toolbar.top.NavigationPopup.HistoryDelegate;
|
||||
import org.chromium.chrome.browser.toolbar.top.ToolbarTablet.OfflineDownloader;
|
||||
import org.chromium.chrome.browser.user_education.UserEducationHelper;
|
||||
import org.chromium.chrome.browser.util.BraveConstants;
|
||||
import org.chromium.chrome.browser.util.BraveTouchUtils;
|
||||
@@ -1500,7 +1499,6 @@ public abstract class BraveToolbarLayoutImpl extends ToolbarLayout
|
||||
ToggleTabStackButtonCoordinator tabSwitcherButtonCoordinator,
|
||||
HistoryDelegate historyDelegate,
|
||||
BooleanSupplier partnerHomepageEnabledSupplier,
|
||||
OfflineDownloader offlineDownloader,
|
||||
UserEducationHelper userEducationHelper,
|
||||
ObservableSupplier<Tracker> trackerSupplier,
|
||||
ToolbarProgressBar progressBar,
|
||||
@@ -1513,7 +1511,6 @@ public abstract class BraveToolbarLayoutImpl extends ToolbarLayout
|
||||
tabSwitcherButtonCoordinator,
|
||||
historyDelegate,
|
||||
partnerHomepageEnabledSupplier,
|
||||
offlineDownloader,
|
||||
userEducationHelper,
|
||||
trackerSupplier,
|
||||
progressBar,
|
||||
|
||||
@@ -37,7 +37,6 @@ import org.chromium.chrome.browser.toolbar.menu_button.MenuButton;
|
||||
import org.chromium.chrome.browser.toolbar.menu_button.MenuButtonCoordinator;
|
||||
import org.chromium.chrome.browser.toolbar.optional_button.ButtonDataProvider;
|
||||
import org.chromium.chrome.browser.toolbar.top.NavigationPopup.HistoryDelegate;
|
||||
import org.chromium.chrome.browser.toolbar.top.ToolbarTablet.OfflineDownloader;
|
||||
import org.chromium.chrome.browser.toolbar.top.tab_strip.TabStripTransitionCoordinator.TabStripTransitionDelegate;
|
||||
import org.chromium.chrome.browser.ui.appmenu.AppMenuButtonHelper;
|
||||
import org.chromium.chrome.browser.user_education.UserEducationHelper;
|
||||
@@ -78,7 +77,6 @@ public class BraveTopToolbarCoordinator extends TopToolbarCoordinator {
|
||||
Supplier<ResourceManager> resourceManagerSupplier,
|
||||
HistoryDelegate historyDelegate,
|
||||
BooleanSupplier partnerHomepageEnabledSupplier,
|
||||
OfflineDownloader offlineDownloader,
|
||||
boolean initializeWithIncognitoColors,
|
||||
ObservableSupplier<Integer> constraintsSupplier,
|
||||
ObservableSupplier<Boolean> compositorInMotionSupplier,
|
||||
@@ -109,7 +107,6 @@ public class BraveTopToolbarCoordinator extends TopToolbarCoordinator {
|
||||
resourceManagerSupplier,
|
||||
historyDelegate,
|
||||
partnerHomepageEnabledSupplier,
|
||||
offlineDownloader,
|
||||
initializeWithIncognitoColors,
|
||||
constraintsSupplier,
|
||||
compositorInMotionSupplier,
|
||||
|
||||
@@ -94,6 +94,7 @@ import org.chromium.chrome.browser.ntp.NewTabPageCreationTracker;
|
||||
import org.chromium.chrome.browser.omnibox.BackKeyBehaviorDelegate;
|
||||
import org.chromium.chrome.browser.omnibox.BraveLocationBarMediator;
|
||||
import org.chromium.chrome.browser.omnibox.DeferredIMEWindowInsetApplicationCallback;
|
||||
import org.chromium.chrome.browser.omnibox.LocationBarCoordinator;
|
||||
import org.chromium.chrome.browser.omnibox.LocationBarDataProvider;
|
||||
import org.chromium.chrome.browser.omnibox.LocationBarEmbedderUiOverrides;
|
||||
import org.chromium.chrome.browser.omnibox.LocationBarLayout;
|
||||
@@ -135,7 +136,6 @@ import org.chromium.chrome.browser.toolbar.top.ToggleTabStackButtonCoordinator;
|
||||
import org.chromium.chrome.browser.toolbar.top.ToolbarActionModeCallback;
|
||||
import org.chromium.chrome.browser.toolbar.top.ToolbarControlContainer;
|
||||
import org.chromium.chrome.browser.toolbar.top.ToolbarLayout;
|
||||
import org.chromium.chrome.browser.toolbar.top.ToolbarTablet.OfflineDownloader;
|
||||
import org.chromium.chrome.browser.ui.appmenu.AppMenuBlocker;
|
||||
import org.chromium.chrome.browser.ui.appmenu.AppMenuDelegate;
|
||||
import org.chromium.chrome.browser.ui.messages.snackbar.SnackbarManager;
|
||||
@@ -1324,7 +1324,6 @@ public class BytecodeTest {
|
||||
Supplier.class,
|
||||
HistoryDelegate.class,
|
||||
BooleanSupplier.class,
|
||||
OfflineDownloader.class,
|
||||
boolean.class,
|
||||
ObservableSupplier.class,
|
||||
ObservableSupplier.class,
|
||||
@@ -1494,7 +1493,8 @@ public class BytecodeTest {
|
||||
Supplier.class,
|
||||
OnLongClickListener.class,
|
||||
BrowserControlsStateProvider.class,
|
||||
boolean.class));
|
||||
boolean.class,
|
||||
LocationBarCoordinator.OfflineDownloader.class));
|
||||
Assert.assertTrue(
|
||||
constructorsMatch(
|
||||
"org/chromium/chrome/browser/omnibox/LocationBarMediator",
|
||||
@@ -1516,7 +1516,8 @@ public class BytecodeTest {
|
||||
BooleanSupplier.class,
|
||||
BraveLocationBarMediator.getOmniboxSuggestionsDropdownEmbedderImplClass(),
|
||||
ObservableSupplier.class,
|
||||
BrowserControlsStateProvider.class));
|
||||
BrowserControlsStateProvider.class,
|
||||
LocationBarCoordinator.OfflineDownloader.class));
|
||||
Assert.assertTrue(
|
||||
constructorsMatch(
|
||||
"org/chromium/chrome/browser/AppHooks",
|
||||
|
||||
Reference in New Issue
Block a user