Discharge7443/brave-core
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[Android] Crash on app reviews (#32973)

Browse Source 
Fixes a crash on app reviews in certain cases.
Resolves: https://github.com/brave/brave-browser/issues/51708
This commit is contained in:
Serg
2025-12-30 13:26:49 -05:00
committed by GitHub
parent 473f52b1d8
commit 81387558a0
2 changed files with 45 additions and 50 deletions
Download Patch File Download Diff File Expand all files Collapse all files
android/java/org/chromium/chrome/browser/rate/BraveAskPlayStoreRatingDialog.java
+44 -49
View File
@@ -36,7 +36,6 @@ public class BraveAskPlayStoreRatingDialog extends BottomSheetDialogFragment {
private static final String TAG = "AskPlayStoreRating";
private static final int DIALOG_DISMISS_DELAY_MS = 500;
private ReviewManager mReviewManager;
private ReviewInfo mReviewInfo;
private boolean mIsFromSettings;
private Context mContext;
@@ -88,11 +87,6 @@ public class BraveAskPlayStoreRatingDialog extends BottomSheetDialogFragment {
if (mReviewManager == null) {
mReviewManager = ReviewManagerFactory.create(mContext);
}
try {
requestReviewFlow();
} catch (NullPointerException e) {
Log.e(TAG, "In-App requestReviewFlow exception");
}
final View view = LayoutInflater.from(getContext())
.inflate(R.layout.brave_ask_play_store_rating_dialog, null);
@@ -138,51 +132,52 @@ public class BraveAskPlayStoreRatingDialog extends BottomSheetDialogFragment {
rateNotNowButton.setOnClickListener((v) -> dismiss());
}
private void requestReviewFlow() {
if (mReviewManager != null) {
Task<ReviewInfo> request = mReviewManager.requestReviewFlow();
request.addOnCompleteListener(task -> {
if (task.isSuccessful()) {
mReviewInfo = task.getResult();
} else {
// There was some problem
Log.e(TAG, "In-App review error " + task.getException());
}
});
}
}
private void launchReviewFlow() {
if (mReviewManager != null && mReviewInfo != null && mContext instanceof Activity) {
try {
// We can get the ReviewInfo object
Task<Void> flow = mReviewManager.launchReviewFlow((Activity) mContext, mReviewInfo);
flow.addOnCompleteListener(
task1 -> {
if (!task1.isSuccessful() && task1.getException() != null) {
// Handle failures in the review flow. Fall back to opening Play
// Store directly if the review flow fails for any reason.
Exception exception = task1.getException();
Log.e(
TAG,
"Review flow failed: " + exception.getMessage(),
exception);
RateUtils.getInstance().openPlaystore(mContext);
}
// The flow has finished. The API does not indicate whether the user
// reviewed or not, or even whether the review dialog was shown.
// Thus, no matter the result, we continue our app flow.
});
} catch (RuntimeException e) {
// Catch BadParcelableException wrapped in RuntimeException that can occur when
// PlayCoreDialogWrapperActivity tries to deserialize ReviewInfo from Intent extras.
// Fall back to opening Play Store directly.
Log.e(TAG, "Failed to launch review flow: " + e.getMessage(), e);
RateUtils.getInstance().openPlaystore(mContext);
}
} else {
// if case fails then open play store app page
if (mReviewManager == null || !(mContext instanceof Activity)) {
RateUtils.getInstance().openPlaystore(mContext);
return;
}
// Request a fresh ReviewInfo right before launching. According to Google's official
// documentation (https://developer.android.com/guide/playcore/in-app-review),
// ReviewInfo objects are valid for a limited time and should be requested shortly
// before launching the review flow to ensure validity.
Task<ReviewInfo> request = mReviewManager.requestReviewFlow();
request.addOnCompleteListener(
task -> {
if (!task.isSuccessful()) {
// If requestReviewFlow fails, fall back to opening Play Store directly
Log.e(TAG, "Failed to request review flow: " + task.getException());
RateUtils.getInstance().openPlaystore(mContext);
return;
}
ReviewInfo reviewInfo = task.getResult();
if (reviewInfo == null) {
Log.e(TAG, "ReviewInfo is null, falling back to Play Store");
RateUtils.getInstance().openPlaystore(mContext);
return;
}
// Launch review flow with fresh ReviewInfo
Task<Void> flow =
mReviewManager.launchReviewFlow((Activity) mContext, reviewInfo);
flow.addOnCompleteListener(
task1 -> {
if (!task1.isSuccessful() && task1.getException() != null) {
// Handle failures reported back through the Task API.
// Note: This won't catch crashes in Play Store's activity
// (like BadParcelableException), but will catch other failures.
Exception exception = task1.getException();
Log.e(
TAG,
"Review flow failed: " + exception.getMessage(),
exception);
RateUtils.getInstance().openPlaystore(mContext);
}
// The flow has finished. The API does not indicate whether the user
// reviewed or not, or even whether the review dialog was shown.
// Thus, no matter the result, we continue our app flow.
});
});
}
}
android/junit/src/org/chromium/chrome/browser/rate/BraveAskPlayStoreRatingDialogTest.java
+1 -1
View File
@@ -104,7 +104,7 @@ public class BraveAskPlayStoreRatingDialogTest {
assertNotNull("Dialog should be created", dialog);
fragment.setupDialog(dialog, 0);
// Process async Task callbacks from requestReviewFlow to ensure mReviewInfo is set
// Process async Task callbacks from setupDialog
ShadowLooper.idleMainLooper();
// Find the "Rate Now" button from the dialog's content view