Discharge7443/brave-core
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[Android] Hide NTP ad settings when Rewards is disabled by policy (#36224)

Browse Source 
Hides the "Show New Tab Page Ads" toggle and the
"Learn more about new tab page ads" link in
Settings -> New Tab Page when Brave Rewards is disabled by policy.
Both controls remain visible and functional otherwise.

Also switches BackgroundImagesPreferences to retrieve the profile via
the inherited getProfile() instead of the legacy
ProfileManager.getLastUsedRegularProfile().

Resolves: https://github.com/brave/brave-browser/issues/55312
This commit is contained in:
Serg
2026-05-06 22:18:17 +01:00
committed by GitHub
parent 2b1b8cf843
commit 824d5976cf
1 changed files with 13 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
android/java/org/chromium/chrome/browser/settings/BackgroundImagesPreferences.java
+13 -8
View File
@@ -22,12 +22,12 @@ import org.chromium.build.annotations.NullMarked;
import org.chromium.build.annotations.Nullable;
import org.chromium.chrome.R;
import org.chromium.chrome.browser.BraveRelaunchUtils;
import org.chromium.chrome.browser.BraveRewardsPolicy;
import org.chromium.chrome.browser.app.BraveActivity;
import org.chromium.chrome.browser.ntp.BraveFreshNtpHelper;
import org.chromium.chrome.browser.ntp.NtpUtil;
import org.chromium.chrome.browser.preferences.BravePref;
import org.chromium.chrome.browser.preferences.ChromeSharedPreferences;
import org.chromium.chrome.browser.profiles.ProfileManager;
import org.chromium.chrome.browser.util.TabUtils;
import org.chromium.components.browser_ui.settings.ChromeBasePreference;
import org.chromium.components.browser_ui.settings.ChromeSwitchPreference;
@@ -78,25 +78,30 @@ public class BackgroundImagesPreferences extends BravePreferenceFragment
if (mShowBackgroundImagesPref != null) {
mShowBackgroundImagesPref.setEnabled(true);
mShowBackgroundImagesPref.setChecked(
UserPrefs.get(ProfileManager.getLastUsedRegularProfile())
UserPrefs.get(getProfile())
.getBoolean(BravePref.NEW_TAB_PAGE_SHOW_BACKGROUND_IMAGE));
mShowBackgroundImagesPref.setOnPreferenceChangeListener(this);
}
boolean rewardsDisabledByPolicy = BraveRewardsPolicy.isDisabledByPolicy(getProfile());
mShowSponsoredImagesPref =
(ChromeSwitchPreference) findPreference(PREF_SHOW_SPONSORED_IMAGES);
if (mShowSponsoredImagesPref != null) {
if (mShowSponsoredImagesPref != null && rewardsDisabledByPolicy) {
mShowSponsoredImagesPref.setVisible(false);
} else if (mShowSponsoredImagesPref != null) {
mShowSponsoredImagesPref.setEnabled(
UserPrefs.get(ProfileManager.getLastUsedRegularProfile())
UserPrefs.get(getProfile())
.getBoolean(BravePref.NEW_TAB_PAGE_SHOW_BACKGROUND_IMAGE));
mShowSponsoredImagesPref.setChecked(
UserPrefs.get(ProfileManager.getLastUsedRegularProfile())
UserPrefs.get(getProfile())
.getBoolean(
BravePref.NEW_TAB_PAGE_SHOW_SPONSORED_IMAGES_BACKGROUND_IMAGE));
mShowSponsoredImagesPref.setOnPreferenceChangeListener(this);
}
mLearnMorePreference =
(ChromeBasePreference) findPreference(PREF_SPONSORED_IMAGES_LEARN_MORE);
if (mLearnMorePreference != null) {
if (mLearnMorePreference != null && rewardsDisabledByPolicy) {
mLearnMorePreference.setVisible(false);
} else if (mLearnMorePreference != null) {
SpannableString spannableString =
new SpannableString(
getContext().getString(R.string.sponsored_images_learn_more));
@@ -171,11 +176,11 @@ public class BackgroundImagesPreferences extends BravePreferenceFragment
if (mShowSponsoredImagesPref != null) {
mShowSponsoredImagesPref.setEnabled((boolean) newValue);
}
UserPrefs.get(ProfileManager.getLastUsedRegularProfile())
UserPrefs.get(getProfile())
.setBoolean(BravePref.NEW_TAB_PAGE_SHOW_BACKGROUND_IMAGE, (boolean) newValue);
BraveRelaunchUtils.askForRelaunch(getActivity());
} else if (PREF_SHOW_SPONSORED_IMAGES.equals(key)) {
UserPrefs.get(ProfileManager.getLastUsedRegularProfile())
UserPrefs.get(getProfile())
.setBoolean(
BravePref.NEW_TAB_PAGE_SHOW_SPONSORED_IMAGES_BACKGROUND_IMAGE,
(boolean) newValue);