Discharge7443/brave-core
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[Android] Adopt ServiceLoaderUtil for CustomizationProviderDelegate

Browse Source 
Chromium change:
https://source.chromium.org/chromium/chromium/src/+/2c57ce7d0331365cdf349f90451fb1379a5778ab

Adopt ServiceLoaderUtil for CustomizationProviderDelegate

Needs to wait for crrev.com/i/7702286 before landing.

Cq-Include-Trybots: luci.chrome.try:android-internal-binary-size
Bug: 40901855
This commit is contained in:
Artem Samoilenko
2024-10-24 12:14:30 +01:00
committed by Claudio DeSouza
parent e044958fbc
commit 8604da3db1
4 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
android/java/apk_for_test.flags
+1 -1
View File
@@ -591,7 +591,7 @@
*** get(...);
}
-keep class org.chromium.chrome.browser.partnercustomizations.CustomizationProviderDelegateImpl {
-keep class org.chromium.chrome.browser.partnercustomizations.CustomizationProviderDelegateUpstreamImpl {
public <init>(...);
}
android/javatests/org/chromium/chrome/browser/BytecodeTest.java
+2 -2
View File
@@ -286,7 +286,7 @@ public class BytecodeTest {
classExists("org/chromium/components/variations/firstrun/VariationsSeedFetcher"));
Assert.assertTrue(
classExists(
"org/chromium/chrome/browser/partnercustomizations/CustomizationProviderDelegateImpl"));
"org/chromium/chrome/browser/partnercustomizations/CustomizationProviderDelegateUpstreamImpl"));
Assert.assertTrue(
classExists(
"org/chromium/chrome/browser/share/send_tab_to_self/ManageAccountDevicesLinkView")); // presubmit: ignore-long-line
@@ -1371,7 +1371,7 @@ public class BytecodeTest {
Profile.class));
Assert.assertTrue(
constructorsMatch(
"org/chromium/chrome/browser/partnercustomizations/CustomizationProviderDelegateImpl",
"org/chromium/chrome/browser/partnercustomizations/CustomizationProviderDelegateUpstreamImpl",
"org/chromium/chrome/browser/partnercustomizations/BraveCustomizationProviderDelegateImpl"));
Assert.assertTrue(
constructorsMatch(
browser/partnercustomizations/java/src/org/chromium/chrome/browser/partnercustomizations/BraveCustomizationProviderDelegateImpl.java
+2 -1
View File
@@ -6,7 +6,8 @@
package org.chromium.chrome.browser.partnercustomizations;
/** Default ContextProviderPackageDelegateImpl implementation. */
public class BraveCustomizationProviderDelegateImpl extends CustomizationProviderDelegateImpl {
public class BraveCustomizationProviderDelegateImpl
extends CustomizationProviderDelegateUpstreamImpl {
@Override
public String getHomepage() {
return null;
build/android/bytecode/java/org/brave/bytecode/BraveCustomizationProviderDelegateImplClassAdapter.java
+1 -1
View File
@@ -9,7 +9,7 @@ import org.objectweb.asm.ClassVisitor;
public class BraveCustomizationProviderDelegateImplClassAdapter extends BraveClassVisitor {
static String sCustomizationProviderDelegateImplClassName =
"org/chromium/chrome/browser/partnercustomizations/CustomizationProviderDelegateImpl";
"org/chromium/chrome/browser/partnercustomizations/CustomizationProviderDelegateUpstreamImpl";
static String sBraveCustomizationProviderDelegateImplClassName =
"org/chromium/chrome/browser/partnercustomizations/BraveCustomizationProviderDelegateImpl";