Discharge7443/brave-core
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[cr149][Android] Changes for NTP LegacyLogoView

Browse Source 
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/c66e45550985e3570e1cf181df0ec749ab3d80f6

commit c66e45550985e3570e1cf181df0ec749ab3d80f6
Author: Yanting Yu <yyanting@google.com>
Date:   Tue Apr 21 12:43:23 2026 -0700

    [LogoRefactor] Branch to LegacyLogoView and introduce feature flag.

    This CL branches the current LogoView implementation into LegacyLogoView
    to ensure the existing functionality remains intact while we restructure
    the new LogoView in the follow up CL.

    Changes include:
    - Branched LogoView, LogoViewBinder, layout XMLs, and corresponding unit tests into LegacyLogoView equivalents.
    - Added the ChromeFeatureList.LOGO_VIEW_REFACTOR feature flag in LogoCoordinator to dynamically switch between inflating the LogoView and the LegacyLogoView.
    - Extracted the ClickHandler interface from LogoView into LogoProperties to serve as a shared, domain-specific contract. This cleanly decouples the two views, allowing them to be fully independent while still being driven by the same PropertyModel and LogoMediator.
    - Updated new_tab_page_layout.xml to replace the `logo_holder` FrameLayout with ViewStub.

    Bug: 492453183
    Change-Id: Id0ef80f8acab9c2d15928020eb3688bd9f2afc33
    Bypass-Check-License: branched files
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7760153
    Commit-Queue: Yanting Yu <yyanting@google.com>
    Reviewed-by: Xi Han <hanxi@chromium.org>
    Reviewed-by: Andrew Grieve <agrieve@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1618376}
This commit is contained in:
Artem Samoilenko
2026-05-22 16:25:13 -04:00
committed by Max Karolinskiy
parent edd588d9b2
commit 8af75b3a89
1 changed files with 5 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files
android/java/res/layout/new_tab_page_layout.xml
+5 -15
View File
@@ -29,22 +29,12 @@
android:visibility="gone">
</FrameLayout>
<FrameLayout
android:id="@+id/logo_holder"
<!-- Search provider logo -->
<ViewStub
android:id="@+id/logo_view_stub"
android:layout_width="match_parent"
android:layout_height="wrap_content">
<org.chromium.chrome.browser.logo.LogoView
android:id="@+id/search_provider_logo"
android:layout_width="wrap_content"
android:layout_height="@dimen/ntp_logo_height"
android:layout_gravity="center_horizontal"
android:layout_marginStart="16dp"
android:layout_marginEnd="16dp"
android:layout_marginTop="@dimen/ntp_logo_margin_top"
android:layout_marginBottom="23dp" />
</FrameLayout>
android:layout_height="wrap_content"
android:layout="@layout/logo_view_layout" />
<androidx.recyclerview.widget.RecyclerView
android:id="@+id/recyclerview"