Fix deps in //brave/components/omnibox/browser

Below files have a strong dependency with components/omnibox/browser.
So, this PR adds sources.gni to //brave/components/omnibox/browser,
then make it build in //components/omnibox/browser.

  - brave_omnibox_client.cc
  - brave_omnibox_client.h",
  - suggested_sites_provider.cc",
  - suggested_sites_provider.h",
  - suggested_sites_provider_data.cc",
  - topsites_provider.cc",
  - topsites_provider.h",
  - topsites_provider_data.cc",

Resolves brave/brave-browser#10624.

build/config/brave_build.gni

@@ -6,6 +6,7 @@ import("//brave/browser/extensions/resources.gni")
 import("//brave/browser/sources.gni")
 import("//brave/build/config/compiler.gni")
 import("//brave/build/features.gni")
+import("//brave/components/omnibox/browser/sources.gni")
 import("//brave/components/sync/sources.gni")
 import("//brave/components/sync/driver/sources.gni")
 import("//brave/installer/linux/sources.gni")

components/omnibox/browser/BUILD.gn

@@ -1,39 +0,0 @@
-source_set("browser") {
-  # Only //components/omnibox/browser target can depend on this target
-  # because this target expands //components/omnibox/browser implementation.
-  visibility = [ "//components/omnibox/browser" ]
-  # Remove when https://github.com/brave/brave-browser/issues/10624 is resolved
-  check_includes = false
-
-  sources = [
-    "brave_omnibox_client.cc",
-    "brave_omnibox_client.h",
-    "constants.cc",
-    "constants.h",
-    "suggested_sites_match.cc",
-    "suggested_sites_match.h",
-    "suggested_sites_provider.cc",
-    "suggested_sites_provider.h",
-    "suggested_sites_provider_data.cc",
-    "topsites_provider_data.cc",
-    "topsites_provider.cc",
-    "topsites_provider.h",
-  ]
-
-  deps = [
-     "//base",
-     "//components/omnibox/browser:buildflags",
-     "//components/security_state/core",
-     "//skia",
-     "//third_party/icu",
-     "//third_party/metrics_proto",
-     "//url",
-  ]
-
-if (!is_ios) {
-  deps += [
-   "//brave/common:pref_names",
-   "//content/public/common",
-  ]
-}
-}

components/omnibox/browser/sources.gni

@@ -0,0 +1,25 @@
+# Copyright (c) 2020 The Brave Authors. All rights reserved.
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this file,
+# You can obtain one at http://mozilla.org/MPL/2.0/.
+
+brave_components_omnibox_browser_sources = [
+  "//brave/components/omnibox/browser/brave_omnibox_client.cc",
+  "//brave/components/omnibox/browser/brave_omnibox_client.h",
+  "//brave/components/omnibox/browser/constants.cc",
+  "//brave/components/omnibox/browser/constants.h",
+  "//brave/components/omnibox/browser/suggested_sites_match.cc",
+  "//brave/components/omnibox/browser/suggested_sites_match.h",
+  "//brave/components/omnibox/browser/suggested_sites_provider.cc",
+  "//brave/components/omnibox/browser/suggested_sites_provider.h",
+  "//brave/components/omnibox/browser/suggested_sites_provider_data.cc",
+  "//brave/components/omnibox/browser/topsites_provider.cc",
+  "//brave/components/omnibox/browser/topsites_provider.h",
+  "//brave/components/omnibox/browser/topsites_provider_data.cc",
+]
+
+brave_components_omnibox_browser_deps = [
+  "//base",
+  "//brave/common:pref_names",
+  "//url",
+]

patches/components-omnibox-browser-BUILD.gn.patch

@@ -1,12 +1,12 @@
 diff --git a/components/omnibox/browser/BUILD.gn b/components/omnibox/browser/BUILD.gn
-index ce702e7dec262a0ff797235efcd5f6f3e5df3531..328ac3af1ff2f74a1e950fe5010478450def3a29 100644
+index ce702e7dec262a0ff797235efcd5f6f3e5df3531..109692f0f8f4c354398786bc97f9620cdc749ed5 100644
 --- a/components/omnibox/browser/BUILD.gn
 +++ b/components/omnibox/browser/BUILD.gn
 @@ -250,6 +250,7 @@ static_library("browser") {
      "//ui/base",
      "//ui/gfx",
    ]
-+  if (brave_chromium_build) {  deps += [ "//brave/components/omnibox/browser" ] }
++  sources += brave_components_omnibox_browser_sources deps += brave_components_omnibox_browser_deps
  
    if ((!is_android || enable_vr) && !is_ios) {
      deps += [ ":vector_icons" ]