Discharge7443/brave-core
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[cr136] js_minifier_ignore_list gone from grit's minifier

Browse Source 
As the override in place is trying to prevent minifying a file, the
exclusion now is to just return the contents that were received
untouched.

Chromium changes:
https://chromium.googlesource.com/chromium/src/+/eadc4393a867edd65f8c279732e16cc631e30005

commit eadc4393a867edd65f8c279732e16cc631e30005
Author: dpapad <dpapad@chromium.org>
Date:   Tue Mar 4 12:24:49 2025 -0800

    WebUI: Remove JS minification step built into Grit on Android builds.

    JS minification happens within build_webui() targets, and does not
    belong in Grit. It was added there long time ago, before build_webui()
    existed and before any other minification happened during the build.

    Removing it avoids running the minifier (Terser) on top of already
    minified files, reducing unnecessary work during the build, as well as
    complexity when minification needs to be turned off for specific files.

    Fixed: 340278433
    Change-Id: I7148bba2e542860ffafc5394e393614a6b377918
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6158805
    Reviewed-by: Andrew Grieve <agrieve@chromium.org>
    Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org>
    Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
    Commit-Queue: Andrew Grieve <agrieve@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1427910}
This commit is contained in:
Claudio DeSouza
2025-04-16 09:30:32 +01:00
parent f8e39b9a5a
commit 939d799d7a
1 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
chromium_src/tools/grit/grit/format/minifier.py
+3 -4
View File
@@ -8,7 +8,6 @@ import override_utils
@override_utils.override_function(globals())
def Minify(original_function, source, filename):
with override_utils.override_scope_variable(
globals(), 'js_minifier_ignore_list',
js_minifier_ignore_list + ['gen/brave/web-ui-opaque_ke/']):
return original_function(source, filename)
if 'gen/brave/web-ui-opaque_ke/' in filename:
return source
return original_function(source, filename)