[cr146][Android] Cleanup of unused BraveNewTabPageLayout overrides
BraveNewTabPageLayout.setSearchProviderTopMargin and BraveNewTabPageLayout.setSearchProviderBottomMargin methods were removed at https://github.com/brave/brave-core/commit/798973641caa39762bae9dff9d2866c7185ce6c8 but class adapter/bytecode Chromium commit below is the commit which caused our bytecode test to fail, because was renamed setSearchProviderBottomMargin => setLogoViewBottomMargin . Chromium change: https://source.chromium.org/chromium/chromium/src/+/9b284825edfb4cea09d686dac7456517c1e8b96e [Composeplate] Fix composeplate view visibility issue. There are 3 issues of the existing NTP: 1) When DSE is changed between Google and 3P, the return value of ComposeplateUtils.isComposeplateEnabled(mIsTablet, profile) changes, but we didn't recalculate it. It causes the bug that composeplate view button doesn't show again for Google -> 3p -> Google. 2) If Chrome starts with 3p DSE, ComposeplateCoornidator won't be initialized at all. Switching to Google won't make it visible. 3) When switching from Google -> 3p, search box's height doesn't reduce from 72dp to 64dp. In this CL, we resolve the above 3 issues: 1) When DSE is changed, initialize ComposeplateCoornidator if hasn't yet; updates the buttons' visibility. 2) Changes the search box height inside NTP, not in SaerchBoxContainerView. The height is determined by whether composeplate is enabled, as well as whether a shadow is added. 3) Polish the initialization process of NTP layout to prevent calling same function multiple times. Demo: http://shortn/_vdN9koVnsu Bug: 474426974 Change-Id: I3a16e56e655465d36184204657626f2bb7c92f24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7487954
This commit is contained in:
@@ -49,9 +49,6 @@
|
||||
*** mMvtContentFits;
|
||||
*** mProfile;
|
||||
*** initializeSiteSectionView(...);
|
||||
*** setSearchProviderTopMargin(...);
|
||||
*** setSearchProviderBottomMargin(...);
|
||||
*** getLogoMargin(...);
|
||||
*** calculateTabletMvtWidth(...);
|
||||
*** updateMvtOnTablet(...);
|
||||
*** isInNarrowWindowOnTablet(...);
|
||||
|
||||
Reference in New Issue
Block a user