Discharge7443/brave-core
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Non-trivial test fixes

Browse Source
This commit is contained in:
Mikhail Atuchin
2024-03-01 16:54:11 +07:00
parent e439623728
commit c667b6943b
3 changed files with 20 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files
components/ai_chat/core/browser/engine/remote_completion_client_unittest.cc
+4 -8
View File
@@ -68,16 +68,12 @@ TEST_F(RemoteCompletionClientUnitTest, ParseJson) {
run_loop2.Run();
// This test verifies that the callback is not called when the response is
// "[DONE]". We use a run loop to wait for the callback to be called, and we
// expect it to never be called. Therefore, we use RunUntilIdle() instead of
// Run(), since Run() would time out waiting for the callback to be called.
base::RunLoop run_loop3;
// "[DONE]". We use RunUntilIdle() to wait for the callback to be called, and
// we expect it to never be called.
SendMesage(
base::BindRepeating([](base::RunLoop* run_loop,
const std::string& response) { run_loop->Quit(); },
&run_loop3),
base::BindRepeating([](const std::string& response) { ADD_FAILURE(); }),
"data: [DONE]");
run_loop3.RunUntilIdle();
task_environment_.RunUntilIdle();
}
} // namespace ai_chat
components/api_request_helper/api_request_helper_unittest.cc
+15 -24
View File
@@ -138,10 +138,8 @@ TEST_F(ApiRequestHelperUnitTest, SanitizedRequest) {
SendRequest("{", base::Value());
SendRequest("0", base::Value());
SendRequest("a", base::Value());
// Android's sanitizer doesn't support trailing commas.
#if !BUILDFLAG(IS_ANDROID)
SendRequest("{\"a\":1,}", ParseJson("{\"a\":1}"));
#endif
// The sanitizer doesn't support trailing commas by default.
SendRequest("{\"a\":1,}", base::Value());
}
TEST_F(ApiRequestHelperUnitTest, RequestWithConversion) {
@@ -245,28 +243,21 @@ TEST_F(ApiRequestHelperUnitTest, SSEJsonParsing) {
run_loop2.Run();
// This test verifies that the callback is not called when the response is
// "[DONE]". We use a run loop to wait for the callback to be called, and
// we expect it to never be called.
base::RunLoop run_loop3;
SendMessageSSEJSON("data: [DONE]",
base::BindRepeating(
[](base::RunLoop* run_loop,
data_decoder::DataDecoder::ValueOrError result) {
run_loop->Quit();
},
&run_loop3));
run_loop3.RunUntilIdle();
// "[DONE]".
SendMessageSSEJSON(
"data: [DONE]",
base::BindRepeating([](data_decoder::DataDecoder::ValueOrError result) {
ADD_FAILURE();
}));
task_environment_.RunUntilIdle();
// Testing with no JSON and an empty string
base::RunLoop run_loop4;
SendMessageSSEJSON("",
base::BindRepeating(
[](base::RunLoop* run_loop,
data_decoder::DataDecoder::ValueOrError result) {
run_loop->Quit();
},
&run_loop4));
run_loop4.RunUntilIdle();
SendMessageSSEJSON(
"",
base::BindRepeating([](data_decoder::DataDecoder::ValueOrError result) {
ADD_FAILURE();
}));
task_environment_.RunUntilIdle();
}
} // namespace api_request_helper
components/brave_wallet/browser/wallet_data_files_installer_unittest.cc
+1
View File
@@ -257,6 +257,7 @@ TEST_F(WalletDataFilesInstallerUnitTest, OnDemandInstallAndParsing_EmptyPath) {
.Times(1)
.WillOnce(testing::Return(true));
SetOnDemandUpdateCallbackWithComponentReady(base::FilePath());
RunUntilIdle();
CreateWallet();
RunUntilIdle();