Discharge7443/brave-core
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

showNtpAtStartup and StartSurfaceAndroid flags were removed

Browse Source 
Related Chromium change:
https://source.chromium.org/chromium/chromium/src/+/5b360c7808439527a4aa57f6ee2e19b9a914014f

[Start] Remove showNtpAtStartup and StartSurfaceAndroid feature flags.

	In this CL, we remove:
	1) feature flag ShowNtpAtStartup;
	2) feature flag StartSurfaceAndroid;
	3) ReturnToChromeUtil#isStartSurfaceFlagEnabled() which always returns
	   false;
	4) StartSurfaceConfiguration#isNtpAsHomeSurfaceEnabled() which always
	   returns true.

	Bug: 344651414
	Change-Id: Ib9a7e41b9387c6f15ebcb304f894e05c259342db
	Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5709277
This commit is contained in:
AlexeyBarabash
2024-08-07 21:31:42 -04:00
committed by mkarolin
parent a59337e65b
commit cebcded69a
2 changed files with 0 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
base/android/java/src/org/chromium/base/cached_flags/BraveCachedFlag.java
-4
View File
@@ -15,8 +15,6 @@ public class BraveCachedFlag extends CachedFlag {
private static final String INCOGNITO_REAUTHENTICATION_FOR_ANDROID =
"IncognitoReauthenticationForAndroid";
private static final String MAGIC_STACK_ANDROID = "MagicStackAndroid";
private static final String SHOW_NTP_AT_STARTUP_ANDROID = "ShowNtpAtStartupAndroid";
private static final String START_SURFACE_ANDROID = "StartSurfaceAndroid";
private static final String SURFACE_POLISH = "SurfacePolish";
// Set of flags to override.
@@ -27,8 +25,6 @@ public class BraveCachedFlag extends CachedFlag {
sFlags.put(ANDROID_TAB_GROUP_STABLE_IDS, false);
sFlags.put(INCOGNITO_REAUTHENTICATION_FOR_ANDROID, true);
sFlags.put(MAGIC_STACK_ANDROID, false);
sFlags.put(SHOW_NTP_AT_STARTUP_ANDROID, false);
sFlags.put(START_SURFACE_ANDROID, false);
sFlags.put(SURFACE_POLISH, false);
}
chromium_src/chrome/browser/flags/android/chrome_feature_list.cc
-2
View File
@@ -64,8 +64,6 @@ OVERRIDE_FEATURE_DEFAULT_STATES({{
{tab_groups::kAndroidTabGroupStableIds, base::FEATURE_DISABLED_BY_DEFAULT},
{kIncognitoReauthenticationForAndroid, base::FEATURE_ENABLED_BY_DEFAULT},
{kMagicStackAndroid, base::FEATURE_DISABLED_BY_DEFAULT},
{kShowNtpAtStartupAndroid, base::FEATURE_DISABLED_BY_DEFAULT},
{kStartSurfaceAndroid, base::FEATURE_DISABLED_BY_DEFAULT},
{kSurfacePolish, base::FEATURE_DISABLED_BY_DEFAULT},
{kAdaptiveButtonInTopToolbarCustomizationV2,
base::FEATURE_DISABLED_BY_DEFAULT},