Discharge7443/brave-core
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Update default browser metric configurations (#29965)

Browse Source
This commit is contained in:
Darnell Andries
2025-07-16 10:06:42 -07:00
committed by GitHub
parent f212f47cb7
commit d4b45dd07c
2 changed files with 12 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files
components/p3a/histograms_braveizer.cc
+11 -16
View File
@@ -60,23 +60,18 @@ void HistogramsBraveizer::DoHistogramBravetization(
uint64_t name_hash,
base::HistogramBase::Sample32 sample) {
if ("DefaultBrowser.State" == histogram_name) {
int answer = 0;
switch (sample) {
case 0: // Not default.
case 1: // Default.
answer = sample;
break;
case 2: // Unknown, merging to "Not default".
answer = 0;
break;
case 3: // Other mode is default, merging to "Default".
answer = 1;
break;
default:
return;
int typical_answer = 0;
int express_answer = INT_MAX - 1;
if (sample == 1 || sample == 3) {
// 'Enabled' or 'Other' answer should be reported as 'Yes'
typical_answer = 1;
express_answer = 1;
} else if (sample > 3) {
// Unknown answer, do not report.
return;
}
UMA_HISTOGRAM_BOOLEAN("Brave.Core.IsDefault", answer);
UMA_HISTOGRAM_BOOLEAN("Brave.Core.IsDefaultDaily", answer);
UMA_HISTOGRAM_BOOLEAN("Brave.Core.IsDefault", typical_answer);
UMA_HISTOGRAM_BOOLEAN("Brave.Core.IsDefaultDaily", express_answer);
}
if ("Extensions.LoadExtension" == histogram_name) {
components/p3a/metric_names.h
+1 -2
View File
@@ -59,8 +59,7 @@ inline constexpr auto kCollectedTypicalHistograms =
{"Brave.Core.FailedHTTPSUpgrades.2", MetricConfig{.ephemeral = true}},
{"Brave.Core.FirstPageLoadTime", MetricConfig{.ephemeral = true}},
{"Brave.Core.IsDefault", MetricConfig{
.attributes = MetricAttributes{MetricAttribute::kAnswerIndex, MetricAttribute::kChannel, MetricAttribute::kGeneralPlatform, MetricAttribute::kYoi, MetricAttribute::kWoi, MetricAttribute::kWeekOfActivation, MetricAttribute::kSubregion, MetricAttribute::kVersion},
.record_activation_date = true,
.attributes = MetricAttributes{MetricAttribute::kAnswerIndex, MetricAttribute::kChannel, MetricAttribute::kGeneralPlatform, MetricAttribute::kYoi, MetricAttribute::kSubregion, MetricAttribute::kVersion, MetricAttribute::kWoi},
}},
{"Brave.Core.NumberOfExtensions", {}},
{"Brave.Core.PagesLoaded.NonRewards", {}},