Discharge7443/brave-core
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[cr143][Win] WinDelaySpellcheckServiceInit feature was removed.

Browse Source 
We were only disabling this feature in a test.

Chromium change:

https://chromium.googlesource.com/chromium/src/+/5fe1e59226f59c4d6fb70e7410d1a0ab83688ae2

commit 5fe1e59226f59c4d6fb70e7410d1a0ab83688ae2
Author: Andreas Haas <ahaas@google.com>
Date:   Mon Oct 20 10:18:55 2025 -0700

    [cleanup] Remove feature WinDelaySpellcheckServiceInit

    The feature has landed already years ago, but the feature flag has never
    been cleaned up.

    R=gujen@google.com

    Bug: 40681243, 356623689
This commit is contained in:
Max Karolinskiy
2025-11-18 11:26:53 -05:00
parent 71999aed39
commit d88ff77c00
1 changed files with 3 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files
browser/renderer_context_menu/brave_spelling_menu_observer_browsertest.cc
+3 -15
View File
@@ -1,7 +1,7 @@
/* Copyright 2020 The Brave Authors. All rights reserved.
/* Copyright (c) 2020 The Brave Authors. All rights reserved.
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this file,
* You can obtain one at http://mozilla.org/MPL/2.0/. */
* You can obtain one at https://mozilla.org/MPL/2.0/. */
#include <memory>
@@ -76,28 +76,16 @@ class BraveSpellingMenuObserverTest : public InProcessBrowserTest {
private:
std::unique_ptr<SpellingMenuObserver> observer_;
std::unique_ptr<BraveMockRenderViewContextMenu> menu_;
#if BUILDFLAG(IS_WIN) && BUILDFLAG(USE_BROWSER_SPELLCHECKER)
base::test::ScopedFeatureList feature_list_;
#endif // BUILDFLAG(IS_WIN) && BUILDFLAG(USE_BROWSER_SPELLCHECKER)
};
#if BUILDFLAG(IS_WIN) && BUILDFLAG(USE_BROWSER_SPELLCHECKER)
BraveSpellingMenuObserverTest::BraveSpellingMenuObserverTest() {
feature_list_.InitAndDisableFeature(
spellcheck::kWinDelaySpellcheckServiceInit);
}
#else
BraveSpellingMenuObserverTest::BraveSpellingMenuObserverTest() = default;
#endif
BraveSpellingMenuObserverTest::~BraveSpellingMenuObserverTest() = default;
} // namespace
// Tests that right-clicking not add "Ask Brave for suggestions".
IN_PROC_BROWSER_TEST_F(BraveSpellingMenuObserverTest,
CheckAskBraveNotShown) {
IN_PROC_BROWSER_TEST_F(BraveSpellingMenuObserverTest, CheckAskBraveNotShown) {
// Test menu with a misspelled word.
Reset();
InitMenu("wiimode", nullptr);