Discharge7443/brave-core
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Moved CreateSystemProxyConfigService to ProxyConfigService

Browse Source 
Chromium change:
https://chromium.googlesource.com/chromium/src/+/31c169bbc16393c55f3f1973c7f2aa0e03709dd0

commit 31c169bbc16393c55f3f1973c7f2aa0e03709dd0
Author: Yoichi Osato <yoichio@chromium.org>
Date:   Fri Jul 8 03:22:21 2022 +0000

    [Code Health] Move CreateSystemProxyConfigService to ProxyConfigService.

    This CL is pure refactoring.
    This CL moves ConfiguredProxyResolutionService::CreateSystemProxyConfigService
    to ProxyConfigService because:
    - ConfiguredProxyResolutionService::CreateSystemProxyConfigService
     creates *NOT* ConfiguredProxyResolutionService instance but ProxyConfigService instance depending on platforms.
    - ConfiguredProxyResolutionService instance lives on the network service
    but ProxyConfigService on the Browser UI thread.

    Change-Id: I05869c5e479c39a6aadf9698a58a3287f28ee1a0
This commit is contained in:
Claudio DeSouza
2022-08-23 00:18:37 -04:00
committed by mkarolin
parent cbaeb3d044
commit db564ef8b2
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
net/proxy_resolution/proxy_config_service_tor_unittest.cc
+2 -3
View File
@@ -134,9 +134,8 @@ TEST_F(ProxyConfigServiceTorTest, SetProxyAuthorization) {
const std::string isolation_key2 =
ProxyConfigServiceTor::CircuitIsolationKey(site_url2);
auto config_service =
ConfiguredProxyResolutionService::CreateSystemProxyConfigService(
base::ThreadTaskRunnerHandle::Get());
auto config_service = net::ProxyConfigService::CreateSystemProxyConfigService(
base::ThreadTaskRunnerHandle::Get());
auto* service = new ConfiguredProxyResolutionService(
std::move(config_service),