Discharge7443/brave-core
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #16161 from brave/bn-subscribe-opted-int

Browse Source 
[Brave News]: Don't show subscribe button until opted in to Brave News
This commit is contained in:
Pete Miller
2022-11-29 23:45:40 -08:00
committed by GitHub
parent b7322b9239 e7cd2a2647
commit df9d04a301
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
browser/ui/views/location_bar/brave_news_location_view.cc
+6 -1
View File
@@ -74,6 +74,9 @@ class BraveNewsButtonView : public views::LabelButton,
profile->GetPrefs(),
base::BindRepeating(&BraveNewsButtonView::Update,
base::Unretained(this)));
opted_in_.Init(brave_news::prefs::kBraveTodayOptedIn, profile->GetPrefs(),
base::BindRepeating(&BraveNewsButtonView::Update,
base::Unretained(this)));
news_enabled_.Init(brave_news::prefs::kNewTabPageShowToday,
profile->GetPrefs(),
base::BindRepeating(&BraveNewsButtonView::Update,
@@ -93,7 +96,8 @@ class BraveNewsButtonView : public views::LabelButton,
BraveNewsButtonView& operator=(const BraveNewsButtonView&) = delete;
void Update() {
if (!should_show_.GetValue() || !news_enabled_.GetValue()) {
if (!should_show_.GetValue() || !news_enabled_.GetValue() ||
!opted_in_.GetValue()) {
SetVisible(false);
return;
}
@@ -190,6 +194,7 @@ class BraveNewsButtonView : public views::LabelButton,
}
BooleanPrefMember should_show_;
BooleanPrefMember opted_in_;
BooleanPrefMember news_enabled_;
base::raw_ptr<Profile> profile_;