Discharge7443/brave-core
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[cr144] Fix for unwanted glic inclusion

Browse Source 
This is a fix for a glic inclusion where upstream changes failed to
guard the header inclusion. A CL has been submitted upstream for this:

https://crrev.com/c/7212717

Chromium changes:
https://chromium.googlesource.com/chromium/src/+/08f8c83a6f4c1c6f6c51d4a4c40ecb0a63459a22

commit 08f8c83a6f4c1c6f6c51d4a4c40ecb0a63459a22
Author: Kene Okoye <kenok@google.com>
Date:   Wed Nov 26 10:22:17 2025 -0800

    [ActorUi]Split up TaskIconClick UserAction for Task Nudge Redesign

    The Actor Task Nudge is a redesign of the Actor Task Icon which shares
    the same TabStripNudgeButton as the icon.

    Previously, the `Actor.Ui.TaskIcon.Click` UserAction was used for all
    clicks on this button.

    This change splits the metric to distinguish clicks made on the
    redesigned button. Now, the `Actor.Ui.TaskNudge.
    {State}.Click` UserAction is recorded when the Task Nudge is clicked
    (with state corresponding to the current `ActorTaskNudgeState`). Clicks
    on the existing Task Icon continue to log the `Actor.Ui.TaskIcon.Click`
    UserAction

    To support this, `ActorTaskNudgeState` is moved to a common header to
    facilitate access within metrics logging code

    Change-Id: I076704f31e9df0a9c4da3aaa73330ae67b1fab66
    Bug: b:454613329
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7181260
    Auto-Submit: Kene Okoye <kenok@google.com>
    Reviewed-by: Alison Gale <agale@chromium.org>
    Commit-Queue: Alison Gale <agale@chromium.org>
    Reviewed-by: Abe Boujane <boujane@google.com>
    Cr-Commit-Position: refs/heads/main@{#1550615}
This commit is contained in:
Claudio DeSouza
2025-12-21 17:13:08 -05:00
committed by Emerick Rogul
parent 1939d63efb
commit e099c69d09
1 changed files with 20 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
patches/chrome-browser-ui-views-tabs-tab_strip_action_container.cc.patch
+20
View File
@@ -0,0 +1,20 @@
diff --git a/chrome/browser/ui/views/tabs/tab_strip_action_container.cc b/chrome/browser/ui/views/tabs/tab_strip_action_container.cc
index 956a562c4146460b90fbe7853311e183819c9f4b..418f5b1f170d1fe9e891933594caf5491b51d0af 100644
--- a/chrome/browser/ui/views/tabs/tab_strip_action_container.cc
+++ b/chrome/browser/ui/views/tabs/tab_strip_action_container.cc
@@ -19,7 +19,6 @@
#include "chrome/browser/ui/browser_window.h"
#include "chrome/browser/ui/color/chrome_color_id.h"
#include "chrome/browser/ui/layout_constants.h"
-#include "chrome/browser/ui/tabs/glic_actor_task_icon_manager.h"
#include "chrome/browser/ui/tabs/organization/tab_declutter_controller.h"
#include "chrome/browser/ui/tabs/organization/tab_organization_service.h"
#include "chrome/browser/ui/tabs/organization/tab_organization_service_factory.h"
@@ -55,6 +54,7 @@
#include "chrome/browser/glic/public/glic_keyed_service.h"
#include "chrome/browser/glic/public/glic_keyed_service_factory.h"
#include "chrome/browser/glic/resources/grit/glic_browser_resources.h"
+#include "chrome/browser/ui/tabs/glic_actor_task_icon_manager.h"
#include "chrome/browser/ui/tabs/glic_actor_task_icon_manager_factory.h"
#include "chrome/browser/ui/tabs/tab_style.h"
#include "chrome/grit/branded_strings.h"