Discharge7443/brave-core
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

NOTIFICATION_WEB_CONTENTS_DISCONNECTED was removed.

Browse Source 
Chromium change:

https://chromium.googlesource.com/chromium/src/+/a718ebd25a45e1265165c8a492c086b106ba7fbe

commit a718ebd25a45e1265165c8a492c086b106ba7fbe
Author: John Delaney <johnidel@chromium.org>
Date:   Thu Feb 18 22:26:36 2021 +0000

    Remove NOTIFICATION_WEB_CONTENTS_DISCONNECTED

    Replaces existing instances with
    WebContentsObserver::WebContentsDestroyed() and/or
    WebContentsObserver::RenderProcessGone() and removes the notification
    invocation.

    Bug: 1174766
This commit is contained in:
mkarolin
2021-03-23 14:55:32 -04:00
parent 7bb904284b
commit e341f85b82
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
browser/brave_scheme_load_browsertest.cc
+4 -4
View File
@@ -203,15 +203,15 @@ IN_PROC_BROWSER_TEST_F(BraveSchemeLoadBrowserTest,
// Check renderer crash happened by observing related notification.
IN_PROC_BROWSER_TEST_F(BraveSchemeLoadBrowserTest, CrashURLTest) {
content::WindowedNotificationObserver observer(
content::NOTIFICATION_WEB_CONTENTS_DISCONNECTED,
content::NotificationService::AllSources());
content::RenderProcessHostWatcher crash_observer(
browser()->tab_strip_model()->GetActiveWebContents(),
content::RenderProcessHostWatcher::WATCH_FOR_PROCESS_EXIT);
content::ScopedAllowRendererCrashes allow_renderer_crashes(active_contents());
browser()->OpenURL(
content::OpenURLParams(GURL("brave://crash/"), content::Referrer(),
WindowOpenDisposition::CURRENT_TAB,
ui::PAGE_TRANSITION_TYPED, false));
observer.Wait();
crash_observer.Wait();
}
// Some webuis are not allowed to load in private window.