we don’t need a separate chromedriver build anymore

auditors @bbondy @bsclifton

build/commands/lib/build.js

@@ -5,11 +5,6 @@ const build = (buildConfig = config.defaultBuildConfig, options) => {
   config.buildConfig = buildConfig
   config.update(options)
 
-  if (options.chromedriver) {
-    util.buildChromedriver()
-    return
-  }
-
   if (!options.no_branding_update) {
     util.updateBranding()
   }

build/commands/lib/createDist.js

@@ -7,7 +7,6 @@ const createDist = (options) => {
 
   let cmdOptions = config.defaultOptions
   const args = util.buildArgsToString(config.buildArgs())
-  util.buildChromedriver()
   util.run('gn', ['gen', config.outputDir, '--args="' + args + '"'], cmdOptions)
   util.run('ninja', ['-C', config.outputDir, 'create_dist'], cmdOptions)
 }

build/commands/lib/util.js

@@ -88,15 +88,6 @@ const util = {
     util.run('ninja', ['-C', config.outputDir, 'zlib'], options)
   },
 
-  buildChromedriver: (options = config.defaultOptions) => {
-    console.log('building chromedriver...')
-    let outputDir = path.join(config.outputDir.split(path.sep).slice(0, -1).join(path.sep), 'Chromedriver')
-
-    const args = util.buildArgsToString(config.buildArgs())
-    util.run('gn', ['gen', outputDir, '--args="' + args + '"'], options)
-    util.run('ninja', ['-C', outputDir, 'build_chromedriver'], options)
-  },
-
   buildMuon: (options = config.defaultOptions) => {
     console.log('building muon...')
 

build/commands/scripts/commands.js

@@ -18,7 +18,6 @@ program
   .option('-C <build_dir>', 'build config (out/Debug, out/Release')
   .option('--muon', 'build muon')
   .option('--node', 'build node')
-  .option('--chromedriver', 'build chromedriver')
   .option('--target_arch <target_arch>', 'target architecture', 'x64')
   .option('--debug_build <debug_build>', 'keep debugging symbols')
   .option('--official_build <official_build>', 'force official build settings')
@@ -31,6 +30,8 @@ program
 program
   .command('create_dist')
   .option('--target_arch <target_arch>', 'target architecture', 'x64')
+  .option('--debug_build <debug_build>', 'keep debugging symbols')
+  .option('--official_build <official_build>', 'force official build settings')
   .action(createDist)
 
 program