Discharge7443/brave-core
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[cr140][ios] Certs now use SHA256HashValue

Browse Source 
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/a9975f275257c

commit a9975f275257c0ed6c3acc65150c2d0c6722ea82
Author: Matt Mueller <mattm@chromium.org>
Date:   Mon Jul 21 10:36:17 2025 -0700

    Use SHA256HashValue in pinset updates instead of vector<uint8_t>

    Bug: 41286522
    Change-Id: I7cefc6f950ba65e0f82e519644ba9cb1df29b4e7
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6763057
    Reviewed-by: Sorin Jianu <sorin@chromium.org>
    Auto-Submit: Matt Mueller <mattm@chromium.org>
    Commit-Queue: Matt Mueller <mattm@chromium.org>
    Reviewed-by: Nasko Oskov <nasko@chromium.org>
    Reviewed-by: Chris Thompson <cthomp@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1489633}
This commit is contained in:
Emerick Rogul
2025-08-19 19:54:28 +01:00
committed by Claudio DeSouza
parent 04bccd394c
commit e78c414e56
1 changed files with 6 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ios/testing/certificate_unittest.mm
+6 -7
View File
@@ -5,6 +5,7 @@
#import <Security/Security.h>
#include "base/containers/span.h"
#import "brave/ios/browser/api/net/certificate_utility.h"
#include "net/http/transport_security_state.h"
#include "net/net_buildflags.h"
@@ -73,17 +74,15 @@ TEST_F(CertificateTest, LoadingCertificate) {
}
TEST_F(CertificateTest, AcceptableCertificates) {
std::size_t acceptable_certs_count =
sizeof(net::kBraveAcceptableCerts) /
sizeof(net::kBraveAcceptableCerts[0]) -
1;
std::size_t acceptable_certs_count = sizeof(net::kBraveAcceptableCerts) /
sizeof(net::kBraveAcceptableCerts[0]);
NSArray<NSData*>* certs = [BraveCertificateUtility acceptableSPKIHashes];
EXPECT_TRUE([certs count] > 3);
EXPECT_EQ([certs count], acceptable_certs_count);
std::string test_cert = std::string(net::kBraveAcceptableCerts[0]);
auto test_cert = base::as_byte_span(*net::kBraveAcceptableCerts[0]);
if (test_cert.size() > 0) {
NSData* data = [NSData dataWithBytes:&test_cert[0] length:test_cert.size()];
EXPECT_NE(data, nil);
@@ -93,8 +92,8 @@ TEST_F(CertificateTest, AcceptableCertificates) {
}
TEST_F(CertificateTest, HashCertificateSPKI) {
std::string amazon_root_ca1_spki_hash =
std::string(net::kSPKIHash_AmazonRootCA1);
auto amazon_root_ca1_spki_hash =
base::as_byte_span(net::kSPKIHash_AmazonRootCA1);
EXPECT_TRUE(amazon_root_ca1_spki_hash.size() > 0);
NSData* amzn_spki_hash_data =