[cr148] SetInitialSyncFeatureSetupComplete dropped unused arg

Chromium changes:
https://chromium.googlesource.com/chromium/src/+/448b9a0247edbe13101ad734f58b0e9792d6064b

commit 448b9a0247edbe13101ad734f58b0e9792d6064b
Author: Tanmoy Mollik <triploblastic@google.com>
Date:   Thu Apr 2 05:25:50 2026 -0700

    Remove unused method param in SyncUserSettings

    Bug: 347710361
    Change-Id: Ie08884a8a8d4d37d1f6e8b91f2200f1d4d6bf948
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7715580
    Commit-Queue: Tanmoy Mollik <triploblastic@google.com>
    Reviewed-by: Marc Treib <treib@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1609128}
This commit is contained in:
Claudio DeSouza
2026-04-27 12:00:59 +01:00
parent 7a2e7fb904
commit ea653acd4e
5 changed files with 9 additions and 17 deletions
+1 -2
View File
@@ -138,8 +138,7 @@ void BraveSyncWorker::MarkFirstSetupComplete() {
// We're done configuring, so notify SyncService that it is OK to start
// syncing.
service->GetUserSettings()->SetInitialSyncFeatureSetupComplete(
syncer::SyncFirstSetupCompleteSource::ADVANCED_FLOW_CONFIRM);
service->GetUserSettings()->SetInitialSyncFeatureSetupComplete();
}
void BraveSyncWorker::FinalizeSyncSetup(JNIEnv* env) {
@@ -294,8 +294,7 @@ void BraveSyncHandler::HandleSetSyncCode(const base::ListValue& args) {
// we will set the result at BraveSyncHandler::OnJoinChainResult.
// Otherwise we will not let to send request to the server.
sync_service->GetUserSettings()->SetInitialSyncFeatureSetupComplete(
syncer::SyncFirstSetupCompleteSource::ADVANCED_FLOW_CONFIRM);
sync_service->GetUserSettings()->SetInitialSyncFeatureSetupComplete();
}
void BraveSyncHandler::OnJoinChainResult(base::Value callback_id, bool result) {
@@ -52,7 +52,7 @@ void ScriptInjectorRenderFrameObserver::RequestAsyncExecuteScript(
blink::mojom::PromiseResultOption await_promise,
RequestAsyncExecuteScriptCallback callback) {
blink::WebScriptSource web_script_source =
blink::WebScriptSource(blink::WebString::FromUTF16(script));
blink::WebScriptSource(blink::WebString::FromUtf16(script));
auto want_result = CheckIfWantResult(callback);
@@ -321,8 +321,7 @@ TEST_F(BraveSyncServiceImplTest, ForcedSetDecryptionPassphrase) {
brave_sync_service_impl()
->GetUserSettings()
->SetInitialSyncFeatureSetupComplete(
syncer::SyncFirstSetupCompleteSource::ADVANCED_FLOW_CONFIRM);
->SetInitialSyncFeatureSetupComplete();
// Pretend we need the passphrase by triggering OnPassphraseRequired and
// supplying the encrypted portion of data, as it is done in
@@ -422,8 +421,7 @@ TEST_F(BraveSyncServiceImplTest, PermanentlyDeleteAccount) {
brave_sync_service_impl()
->GetUserSettings()
->SetInitialSyncFeatureSetupComplete(
syncer::SyncFirstSetupCompleteSource::ADVANCED_FLOW_CONFIRM);
->SetInitialSyncFeatureSetupComplete();
EXPECT_TRUE(engine());
std::unique_ptr<testing::NiceMock<BraveMockSyncEngine>> mock_sync_engine =
@@ -552,8 +550,7 @@ TEST_F(BraveSyncServiceImplTest, HistoryPreconditions) {
brave_sync_service_impl()
->GetUserSettings()
->SetInitialSyncFeatureSetupComplete(
syncer::SyncFirstSetupCompleteSource::ADVANCED_FLOW_CONFIRM);
->SetInitialSyncFeatureSetupComplete();
EXPECT_TRUE(engine());
// Code below turns on encrypt everything
@@ -599,8 +596,7 @@ TEST_F(BraveSyncServiceImplTest, BookmarksAndPasswordsAfterSetup) {
brave_sync_service_impl()
->GetUserSettings()
->SetInitialSyncFeatureSetupComplete(
syncer::SyncFirstSetupCompleteSource::ADVANCED_FLOW_CONFIRM);
->SetInitialSyncFeatureSetupComplete();
EXPECT_TRUE(engine());
EXPECT_FALSE(
@@ -719,8 +715,7 @@ TEST_F(BraveSyncServiceImplTest_DisableSyncDefaultPasswordsTest,
brave_sync_service_impl()
->GetUserSettings()
->SetInitialSyncFeatureSetupComplete(
syncer::SyncFirstSetupCompleteSource::ADVANCED_FLOW_CONFIRM);
->SetInitialSyncFeatureSetupComplete();
EXPECT_TRUE(engine());
EXPECT_FALSE(
+1 -2
View File
@@ -287,8 +287,7 @@ bool BraveSyncWorker::SetSetupComplete() {
}
if (!sync_service->GetUserSettings()->IsInitialSyncFeatureSetupComplete()) {
sync_service->GetUserSettings()->SetInitialSyncFeatureSetupComplete(
syncer::SyncFirstSetupCompleteSource::ADVANCED_FLOW_CONFIRM);
sync_service->GetUserSettings()->SetInitialSyncFeatureSetupComplete();
}
return true;