Discharge7443/brave-core
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fixed build failure (#34465)

Browse Source 
Build failed at asan build.
Need to relay brave/components/sidebar/browser target to propagate its public deps upward.

05:23:53  stderr:
05:23:53  In file included from ../../brave/browser/ui/views/frame/layout/brave_browser_view_tabbed_layout_impl.cc:16:
05:23:53  In file included from ../../brave/browser/ui/views/sidebar/sidebar_container_view.h:14:
05:23:53  In file included from ../../brave/browser/ui/sidebar/sidebar.h:9:
05:23:53  In file included from ../../brave/components/sidebar/browser/sidebar_service.h:17:
05:23:53 
 ../../brave/components/sidebar/browser/sidebar_item.h:10:10: fatal error: 'brave/components/brave_talk/buildflags/buildflags.h' file not found
05:23:53     10 | #include "brave/components/brave_talk/buildflags/buildflags.h"
05:23:53        |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
05:23:53  1 error generated.
This commit is contained in:
Simon Hong
2026-03-05 19:20:18 +09:00
committed by GitHub
parent e5c9cf0202
commit f46e924b12
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
browser/ui/sidebar/BUILD.gn
+2 -1
View File
@@ -30,11 +30,12 @@ source_set("sidebar") {
"sidebar_web_panel_controller.h",
]
public_deps = [ "//brave/components/sidebar/browser" ]
deps = [
"//base",
"//brave/browser/ui/views/frame/split_view",
"//brave/components/brave_talk/buildflags",
"//brave/components/sidebar/browser",
"//brave/components/sidebar/common",
"//chrome/browser:browser_process",
"//chrome/browser/favicon",