The addition of this argument will allow us to checkout a different
Chromium version, as a tantive version. This is useful when generating
the toolchain for a version bump that the branch itself is not fully
up-to-date with, but it is close enough to provide hermetic toolchains
necessary to run the toolchain job with.
Resolves https://github.com/brave/brave-browser/issues/45237
This PR adds tests for `Version` to `brockit`. For convenience,
`Version` has been moved into its own module, and also a few other bits
and pieces that were associated with it.
This change also touches a lot on `Repository`, because these two
modules make heavy use of a common test machinery for the two. This
means adjusting both tests to make better reuse of code.
Finally, `Repository.chromium()`/`Repository.brave()` are being changed
into globals inside `repository`. This is to avoid instatiations on each
use, and to follow the advise in
https://google.github.io/styleguide/pyguide.html#2174-decision regarding
the use of `@classmethod`
Resolves https://github.com/brave/brave-browser/issues/45231
Adding this hook into the repo that could be used by anyone to have a
standardised way to add tags into commit messages. This also provides a
way to add chromium culprits into changes.
Resolves https://github.com/brave/brave-browser/issues/45015
This change corrects an issue with our current rebase operation, and its
reliance on `git merge-base fork-point`, which gets off-base when the
upstream branch for a given branch (say `cr137`, `cr138`) gets rebased
against their own upstream branch and force pushed. At that point, the
fork point returned by git is wildly off and behind where it should
actually be.
This change adds `--to-ref`/`--from-ref` as a better way to select the
range of changes that we want to rebase. With `--to-ref` it defaults to
`@upstream` when nothing is provided, and it represents the branch we
are rebasing the version on top.
With `--from-ref` we default to `@previous-major` when dealing with
major lifts, or just to `@previous` when dealing with minor bumps.
`@previous-major` is being introduced to find exactly the first change
that changed the major version.
This PR also removes the "dry-run" attempt in determining if there could
be conflicts when rebasing a branch as that warning was entirely
off base.
Resolves https://github.com/brave/brave-browser/issues/45226
Initially the menu was too narrow to fully fit items localized in
German, so we increased the width to the regular menu width of 800.
However users indicated that it was now too wide. This change reduces
the width to 500, which is still enough to fit the German l10n.
* Add support for diferent variants
* Remove omnibox highlight which shows up right after onboarding
* Add different variants function
* Add search widget promo on NTP
* Add notification permission changes
* Update widget promo UI
* Update wdp check
Resolve presubmit issue
* Fixed crash when toggling playlist panel while it's playing
When SidePanelWebView is created, upstream marks this content and
has assumption that it's visible if it has loaded url.
When playlist panel is closed while playing, we cache |contents_wrapper_|
to make it continue to play after closing panel.
So, it has loaded url already. Should be visible before creating
SidePanelWebView with it to avoid above CHECK failure.
Terry Mancey