This patching is not needed in 138 anymore, as it has landed in
upstream.
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/4b7e1adf413943fc48c8ce865511079fed271cf8
commit 4b7e1adf413943fc48c8ce865511079fed271cf8
Author: Maksim Moskvitin <mmoskvitin@google.com>
Date: Fri May 23 06:17:53 2025 -0700
Revert "Sync ProcessorEntity: Upgrade remaining DCHECKs"
This reverts commit 6752bab9ae006f82bdd1bf73a475ffffd2fa2d00.
Reason for revert: Still crashing on M137
Bug: 408182457, 419310731
Original change's description:
> Sync ProcessorEntity: Upgrade remaining DCHECKs
>
> This CL upgrades most of the remaining DCHECKs in ProcessorEntity to
> proper CHECKs, mostly with base::NotFatalUntil::M141.
> A few that are obviously-valid don't have NotFatalUntil, and one that
> is questionable is just removed.
>
> Also includes some minor other cleanups, like inlining a one-line
> helper method with a single call site.
>
> Bug: 408182457
> Change-Id: I7e385de3b6d2953ff9cac62f40e3ebb5651219b8
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6461075
> Reviewed-by: Maksim Moskvitin <mmoskvitin@google.com>
> Commit-Queue: Marc Treib <treib@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1448230}
Bug: 408182457
Change-Id: Ib5d538c4ebd2aabb9cb0cd27416fba02187945cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6578201
Auto-Submit: Maksim Moskvitin <mmoskvitin@google.com>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1464694}
Deprecate EligibleAdsCallback (now EligibleAdsCallbackDeprecated, takes const-ref); introduce new EligibleAdsCallback that takes by value to enable move semantics.
This change adds a new component to display synced tabs. It currently only is visible when presenting synced tabs from Shortcuts.app, but will be used in the future tab tray redesign
As adding groups needs the TabContainer to be in a valid state,
especially state related to available width, we need to ensure
that the TabContainer is updated before we add groups to it.
<!-- Add brave-browser issue below that this PR will resolve -->
Resolves https://github.com/brave/brave-browser/issues/46615
TEST=VerticalTabStripWithScrollableTabBrowserTest.ToggleWithGroups
### MANUAL TEST:
#### Steps to verify
* Turn on brave://flags/#scrollable-tabstrip feature flag
* Create a tab group
* Toggle tabs orientation to vertical and then back to horizontal
#### Expected behavior
There should be no crash
This WebClient method is on by default (and implemented as so in Chrome's web client) but requires us to implement the necessary UI to handle prompting the user when they attempt to submit an insecure form. Since we don't currently do so with our regular web views, disable this for now.
* Replace "Shortcut" section with "Customize toolbar" button
Following our the latest design guidelines, this patch replaces
the "Shortcut" section with a "Customize toolbar" button
in the "Theme and Color Section".
<img width="319" alt="image" src="https://github.com/user-attachments/assets/63337d88-b47d-429e-a397-c51573f80f77" />
This change updates the way that we assign the scroll view's refresh control. Chromium's scroll view proxy attempts to forward invocations of typical `UIScrollVIew` methods but it seems to have issues with `refreshControl`, specifically when setting the same value
When a string is declared as `const` this suppresses RVO, as the value
has to be copied over during return. This change corrects a few places
where this has been happning in the codebase.
* Add reachable test cases by MockPrintPreviewPrintRenderFrame
* Move PreviewPageTextExtractor and PrintPreviewExtractorInternal to an internal h/cc so we can write more unit tests
* Add PrintPreviewData test case
* Add PreviewPageTextExtractorTest
* Pull out indivisual targets of print_preview_extractor and print_preview_extractor_impl
* Add comment for each run case
* Move PrintPreviewExtractor to //brave/browser/ai_chat
* Override kChromeURLContentSecurityPolicyHeaderBase.
* Fix Untrusted interface implementation to allow binding multiple different interfaces to a single URL.
* Make CSPs for frame-src work the same as on Desktop.
Emerick Rogul