- Moved address bar to bottom on NTP
- Moved menu and updated menu icons and texts
- Added request for relaunch when bottom navigation controls are enabled
- UI and visual improvements
Chromium change:
https://chromium.googlesource.com/chromium/src/+/65edd13188a0eb01fa8e1140b7489a40ee517d52
[bookmarks] Extract manager opening logic to interface/impl
The implementation of this interface can't be modularized. Extracting
the BookmarkUtils methods to an interface/impl combo which can
be used by classes in the bookamrks module.
Bug: 395908100
* Add rewards 3.0 feature flag
* Add a function to check for rewards 3.0 flag
Update entry points for rewards with rewards 3.0 flag
* Add RewardsPageActivity/RewardsCustomTabRootUiCoordinator to show rewards 3.0 changes in custom tab
* Address rewards reset for rewards 3.0
* Add activity transition for rewards page
* Remove onBackPressed override
* Add close button to close the rewards panel as we have disabled back press
Update close button position on the page
* Add creator changes for rewards 3.0
Remove logs
Add null check
Remove changes for backpress
* Add changes for handling creators
Encode Url for creators
* Add open url native fucntion
* Add bubble in query params
* Add bytecode changes for BaseCustomTabActivity
Add native function to open url into rewards_page_ui
* Update copyright header year
* Update close icon for rewards page
Remove comments and refactor changes
* Address naming related changes
* Add test for bytecode changes
Resolve rebase error
* Update changes to use TabUtils open tab
* Remove close button
* Add FullScreenCustomTabActivity
TabGroupUiCoordinator.ctor and TabManagementDelegate.createTabGroupUi:
- removed incognitoStateProvider;
- added themeColorProvider.
IncognitoStateProvider / IncognitoStateObserver code at BraveTabGroupUiCoordinator
now does not affect on toolbar color at incognito code, and the code was removed.
Chromium change:
https://source.chromium.org/chromium/chromium/src/+/3468d618873a1bb1ee72fc5c2ca068597f24c7c8
[Anchor] Use BottomUiThemeColorProvider for TabGroupUI
For a top-anchored toolbar, this should be non user-visible. Under
the hood, TabGroupUi doesn't need to explicitly track incognito
state and instead just takes the colors it's given.
For a bottom-anchored toolbar, this results in a TabGroup toolbar
and chin with color and tint matching the toolbar's.
Bug: 369133954
Change-Id: I82532e122541c8a20c08c9110fa46e938a4104a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5983743
Chromium change:
https://source.chromium.org/chromium/chromium/src/+/65eee63c0e75ebd343c409a7c14addb00ca4b6dd
[Tab Model] Deprecate tab_groups package
Merge the tab_groups/ package into tabmodel/. The two packages have
significant overlap and should really have a lot of their logic merged
anyway.
This allows us to package protect TabGroupModelFilterInternal and make
destroy method package private as well.
Fixed: 372068933
Chromium change:
https://source.chromium.org/chromium/chromium/src/+/78b03df18d4625181de54bf6a7efa805c20b367d
Move base.cached_flags to components.cached_flags
We will need to depend on components/variations to support
fieldtrial_testing_config.json.
Since base can't use cached flags, and many clients of base won't
either, it makes more sense to put it in components.
Bug: 370797986
Upstream's logic in `AppLocaleUtils` for `getApplicationLocales` and `setApplicationLocales` is the same as it was in our patch, so we don't need it anymore.
Chromium change:
https://source.chromium.org/chromium/chromium/src/+/826aadf32e2ebec6a4086d97937f345ea5f3f912
Android: Adopt ServiceLoaderUtil for LanguageProfileDelegate
And upstreams & inlines the logic from LocaleManagerDelegate, which
existed only to work around Android T SDK not yet being available.
Also adds some @JniType annotations to LanguageBridge to simplify
changes there.
Bug: 40901855
* Fixed navigation bar color at private tab; fixesbrave/brave-browser#41545
Chromium change:
https://source.chromium.org/chromium/chromium/src/+/52962da478ed750038f966c386c4ee0ff2d73837
Always apply luminance calculation to navigation bar icons
Currently, the navigation bar icons only respond to the color of the navigation bar during animations. Since animations are being disabled for the navbar coloring experiment, it's important that the luminance calculation to properly color the navigation bar icons is applied all the time, not just during animations.
Bug: 364228106, 40925025
fixes https://github.com/brave/brave-browser/issues/41402
Crash happened at app menu => Settings => Brave Shields & privacy => Content Filtering.
Tombstone
```
java.lang.ClassCastException: org.chromium.chrome.browser.settings.SettingsActivity cannot be cast to org.chromium.chrome.browser.settings.BraveSettingsActivity
at org.chromium.chrome.browser.shields.ContentFilteringFragment.onAttach(ContentFilteringFragment.java:86)
```
Upstream had added a new place to create Intent for Settings activity.
Related Chromium change:
https://source.chromium.org/chromium/chromium/src/+/d4af6a2c4ccc6427aa7df0f2beacf61793459e66
[Settings] Introduce a central place to construct intents
SettingsIntentUtil becomes the central place to construct intents
launching the settings activity.
Bug: b/356743945
Change-Id: Id6988af4a182fe6603bb02c9dae8b2ac48f80fed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5832868
Chromium change:
https://source.chromium.org/chromium/chromium/src/+/52962da478ed750038f966c386c4ee0ff2d73837
Always apply luminance calculation to navigation bar icons
Currently, the navigation bar icons only respond to the color of the navigation bar during animations. Since animations are being disabled for the navbar coloring experiment, it's important that the luminance calculation to properly color the navigation bar icons is applied all the time, not just during animations.
Bug: 364228106, 40925025
Chromium change:
https://source.chromium.org/chromium/chromium/src/+/af4a1a29660d0cfa1ed074d69f782abc9f79fd98
Make NotificationPlatformBridge less native-dependent (3/5).
Mark as `static` several helper methods in `NotificationPlatformBridge`. This is in preparation to enable calling methods like `displayProvisionallyUnsubscribedNotification` without an instance of
`NotificationPlatformBridge` existing, which requires native
libraries to be loaded.
As these methods already access no instance variables, there should be no functional changes.
* Revert "[Android] Follow-up for cr128 top GP crash (#25191)"
This reverts commit a7407de42a.
* Revert "[Android] Fix crash after cr128 upgrade at TabSwitcherPaneCoordinator (#25130)"
This reverts commit 68bc172dee.
* [Android] Follow-up with incognito tabs for Fix for crash after cr128 upgrade when pressing back at tab switcher
Fixesbrave/brave-browser#40581
* [Android] Fix for crash after cr128 upgrade when pressing back at tab switcher
Forced invoke of `createTabSwitcherPaneCoordinator` before `TabSwitcherPaneBase.requestAnimationData()` to avoid null access crash.
Fixesbrave/brave-browser#40422
Java asm patch for ToolbarManager.mConstraintsProxy
One direct patch is still remaining to expose nested private class
Improved patch around ToolbarManager.mConstraintsProxy
Related Chromium change
https://source.chromium.org/chromium/chromium/src/+/76dc0890ae54c50d706857f7dbeb99076a4f07b1
[Start] Clean up ToolbarManager and ToolbarLayout|Phone.
In this CL, the followings are cleaned up:
1) ToolbarManager: anything related to Start surface;
2) ToolbarPhone: both |mIsShowingStartSurfaceHomepage| and
|mIsShowingStartSurfaceTabSwitcher| are always false. Remove both
and usages.
3) ToolbarPhone#isLocationBarShownInGeneralNtpOrStartSurface() is
replaced by isLocationBarShownInGeneralNtp(), since "surface
polish" has enabled by default.
4) ToolbarLayout#onStartSurfaceStateChanged(): remove this orphan
method.
Bug: 344651414, 40221888, 40834987
Change-Id: I089d6c8c5390477d305ea377bd2b6c0e97034ff0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5675441
Serg