Commit Graph
4540 Commits
Author SHA1 Message Date
Deep Pandya 0f008b2765 Set brave as default for private mode in all regions for new users (#27769) 2025-02-26 18:02:04 +01:00
Deep Pandya 70dd1effbd Change WDP card position before p3a (#27810) 2025-02-26 10:05:27 -05:00
Deep Pandya a5c0b652be Rewards 3.0 android (#26945)
* Add rewards 3.0 feature flag

* Add a function to check for rewards 3.0 flag

Update entry points for rewards with rewards 3.0 flag

* Add RewardsPageActivity/RewardsCustomTabRootUiCoordinator to show rewards 3.0 changes in custom tab

* Address rewards reset for rewards 3.0

* Add activity transition for rewards page

* Remove onBackPressed override

* Add close button to close the rewards panel as we have disabled back press

Update close button position on the page

* Add creator changes for rewards 3.0

Remove logs

Add null check

Remove changes for backpress

* Add changes for handling creators

Encode Url for creators

* Add open url native fucntion

* Add bubble in query params

* Add bytecode changes for BaseCustomTabActivity

Add native function to open url into rewards_page_ui

* Update copyright header year

* Update close icon for rewards page

Remove comments and refactor changes

* Address naming related changes

* Add test for bytecode changes

Resolve rebase error

* Update changes to use TabUtils open tab

* Remove close button

* Add FullScreenCustomTabActivity
2025-02-22 16:34:57 -05:00
Serg d28dce4cdc Removes Leo suggestion from quick search engines on private tabs on Android (#27763) 2025-02-21 12:34:32 -05:00
Deep Pandya 50c2e997d9 Add Tabs icon in settings (#27725)
* Add Tabs icon in settings

* Update icon tint
2025-02-20 14:09:55 -03:00
Kamil Jozwiak d1a8ace419 Merge pull request #27172 from brave/cr134
Upgrade from Chromium 133 to Chromium 134
2025-02-18 12:39:34 -05:00
Anton Paymyshev 28ea534745 Drop HDKeyring base class (#27663) 2025-02-18 21:06:50 +07:00
AlexeyBarabash 38a78eb167 [cr134] [Android] ScrimManager instead of ScrimCoordinator
Related Chromium change:
https://source.chromium.org/chromium/chromium/src/+/723933f990282b9f4c91d2467ef61b52f292b775

	Creates empty ScrimManager and replace all call sites.

	There should be no functional changes in this. Purely a rename to an
	empty/passthrough super class.

	Bug: 371034867
	Change-Id: I3be1d481c176303545baf831d05db53634a74809
	Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6219602
2025-02-18 12:46:58 +00:00
AlexeyBarabash 66832d8a68 [cr134] [Android] New arg at StatusBarColorController.ctor - edgeToEdgeSystemBarColorHelper
Related Chromium change:
https://source.chromium.org/chromium/chromium/src/+/4141fd4d16b1453625684aeb24468ba6a0614178

	[E2E] Refactor StatusBarColorController to use SystemBarColorHelper

	Handles adding plumbing for StatusBarColorController to
	EdgeToEdgeSystemBarColorHelper in order to update the status bar color.

	StatusBarColorController is used by ChromeActivity, so this addresses
	some of the plumbing used to update the status bar color when Edge to
	Edge is enabled.

	Bug: 379174458
	Change-Id: Id66f51724b0865e68e235b7f90c69aaf5308237e
	Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6049358
2025-02-18 12:46:58 +00:00
AlexeyBarabash 4d9b201fbf [cr134] [Android] Methods removed from AutofillProfile
Related Chromium changes:

	https://source.chromium.org/chromium/chromium/src/+/24d8405e25f96fa97d21389863dface2ade6e13e
	[Android] Remove getFullName from AutofillProfile.

	https://source.chromium.org/chromium/chromium/src/+/72580570fe7be032c5128493fc30bc56251be7a8
	[Android] Remove getCompanyName from AutofillProfile.

	https://source.chromium.org/chromium/chromium/src/+/11fd21337dc3663615d3ea80b7e96c98bdf7bc59
	[Android] Remove getStreetAddress from AutofillProfile.

	https://source.chromium.org/chromium/chromium/src/+/1ceb5bde6020708f4e8ac0915151669438029338
	[Android] Remove getRegion from AutofillProfile.

	https://source.chromium.org/chromium/chromium/src/+/57fb9997ef9f53926687f64839d11f3af07a81be
	[Android] Remove getLocality from AutofillProfile.

	https://source.chromium.org/chromium/chromium/src/+/de56249f9c4683ce2984934e7af0285219861201
	[Android] Remove getDependentLocality from AutofillProfile.

	https://source.chromium.org/chromium/chromium/src/+/7978a85b0dbffea43fad3fbd285481ed87bd1e47
	[Android] Remove getPostalCode from AutofillProfile.

	https://source.chromium.org/chromium/chromium/src/+/40e42067ab55a80a9ce27ebc56bea57e3b953900
	[Android] Remove getSortingCode from AutofillProfile.

	https://source.chromium.org/chromium/chromium/src/+/ca4b12631e134c813c16be27a388320128cab5d5
	[Android] Make getCountryCode private in the AutofillProfile.

	https://source.chromium.org/chromium/chromium/src/+/07a3e15fd0a1399d4a2cce3b9065a4eda694c334
	[Android] Remove getPhoneNumber from AutofillProfile.

	https://source.chromium.org/chromium/chromium/src/+/7f480190852eb6dbce54a0703c99aa0a82de4534
	[Android] Remove getEmailAddress from AutofillProfile.
2025-02-18 12:46:57 +00:00
AlexeyBarabash cf2ea2fe97 [cr134] [Android] TemplateUrlService.isEeaChoiceCountry was removed
Related Chromium change:
https://source.chromium.org/chromium/chromium/src/+/25de988ad1d08cf2713249eb412ca42033a45b7a

	rcaps: Switch to IsInEeaCountry from rcaps in Java code

	Removes TemplateUrlService#IsEeaCountry from the Java class, replacing
	it with RegionalCapabilitiesService#IsInEeaCountry calls.

	Bug: 328040066
	Change-Id: I8bf9240cecb5b5394640221f62a68948e89aa388
	Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6190388
2025-02-18 12:46:57 +00:00
AlexeyBarabash 8681222831 [Android] [cr134] New arg browserControlsStateProvider at LocationBarMediator.ctor
Related Chromium change:
https://source.chromium.org/chromium/chromium/src/+/1c6160dc6933c4813715da1ff449f870ea8c8caf

	[Anchor] Skip status icon crossfade when focusing from bottom

	To match the lack of horizontal animation, we also want to skip the
	crossfade when focusing the omnibox from the bottom. A mechanism exists
	for this already so we are just implementing a new state in which it
	applies.

	Bug: 369134015
	Change-Id: Ifbd33b38ac69e4b75bdcef8422e51b4e45236724
	Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6179194
2025-02-18 12:46:56 +00:00
AlexeyBarabash a0e1f1ef17 [cr134] [Android] ClearBrowsingDataFragmentAdvanced was removed
Chromium now doesn't contain `Basic`/`Advanced`.

Class ClearBrowsingDataFragment now represents what used to be ClearBrowsingDataFragmentAdvanced.

Related Chromium change:
https://source.chromium.org/chromium/chromium/src/+/a49153686134a72ff189024392df6aad09e71fb0

	[Quick Delete] Clean up kQuickDeleteAndroidFollowup flag

	Clean up Quick Delete phase 2 feature checks now that the experiment is
	fully launched. This includes removing the obsolete tabbed layout and
	basic tab from CBD on Android.

	OBSOLETE_HISTOGRAM[History.ClearBrowsingData.UserDeletedFromTab]=No longer logged

	Bug: 40255099
	Change-Id: I340afa9692f17ad3b472f501522a9e6ff8fb061c
	Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6162502
2025-02-18 12:46:55 +00:00
AlexeyBarabash 12bcebfa91 [cr134] [Android] Removed TabModelSelectorObserver.onTabModelSelected
Related Chromium change
https://source.chromium.org/chromium/chromium/src/+/d223f2e8f4900df442947eb2303b356468625d6f

	[Tab Model] Remove onTabModelSelected

	Replace onTabModelSelected with observing getCurrentTabModelSupplier.

	A previous CL removed most usages, but a few were leftover. This CL
	completes the migration.

	This change in observation style is beneficial as it avoids adding
	TabModelSelectorObservers that get notified of various spammy onChange
	updates and subsequently no-op all observer events except for tab model
	selected which is the only action most observers cared about in the
	first place.

	Change-Id: I9a657404c65b8e6b182924656e264945b7ddb35e
	Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6165827
2025-02-18 12:46:54 +00:00
AlexeyBarabash 885a9530d9 [cr134] [Android] Some args changed from Supplier to ObservableSupplier:
- bottomControlsOffsetSupplier arg at ToolbarSwipeLayout.ctor
- bottomToolbarControlsOffsetSupplier arg at TopToolbarCoordinator.initializeWithNative

Related Chromium change
https://source.chromium.org/chromium/chromium/src/+/3c074e90a12a90c9c0d128773300b209b7b29d6f

	[Anchor] Make bottom controls offset for overlay observable

	This allows us to drive immediate changes to the position of the overlay
	instead of passively adjusting when a new frame is composed. This is
	necessary to be able to set up animations to start the overlay in the
	correct location.

	Bug: 369134461
	Change-Id: I897a2ad7943e56660255a1fd2a5b485b70d64466
	Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6107628
2025-02-18 12:46:54 +00:00
AlexeyBarabash 3c295aa6cd [cr134] [Android] DataSharingTabManager arg at ShareDelegateImpl.ctor
Related Chromium change
https://source.chromium.org/chromium/chromium/src/+/4e5c55b15ee78687e23badd0eed3f699349b2f15

	Add share action to system share sheet

	Adds an extra option that creates a tab group and shares the group.

	Low-Coverage-Reason: TRIVIAL_CHANGE does a list of checks
	Bug: 386833405
	Change-Id: I659add9ceeeb8c799160eb6fe12cc84289b581f4
	Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6155198
2025-02-18 12:46:53 +00:00
Artem Samoilenko f845c3713d [Android] Enforce full method signature check for bytecode tests 2025-02-17 15:33:18 -05:00
Anton Paymyshev 5573c3e7de Remove address from TransactionInfo (#27592) 2025-02-15 21:09:51 +07:00
Artem Samoilenko 96bd9e01db [Android] Fix for bottom controls visibility in landscape mode
This is a regression from C132 https://chromium.googlesource.com/chromium/src/+/8c7ff112c0ebadc79c298d02acc0082cb560e6ec
2025-02-12 13:29:52 -05:00
Deep Pandya 8cec452b21 Remove SafetyNet android (#26719)
* Remove safetynet changes android

Resolve presubmit issue

Remove safetynet directory

* Clear kSafetynetStatus pref

* Remove and clear kSafetynetCheckFailed pref

Register kSafetynetStatus in brave_prodfile_prefs

* Remove BraveUpgradeJobIntentService

* Remove safetynet key
2025-02-10 09:56:43 -05:00
samartnik ae993a9370 Merge pull request #27578 from brave/android_menu_footer_home_button_fix
[Android] Fix for home button visibility in menu footer
2025-02-07 17:41:42 -05:00
Serg aea9176c7b Keep url bar text and suggestions in multi-window/split-mode, when switch away from Brave on Android (#27568) 2025-02-07 15:51:49 -05:00
Artem Samoilenko bcc3186292 [Android] Fix for home button visibility in menu footer 2025-02-07 15:40:33 -05:00
Deep Pandya f7c6cfdd66 Add landscape UI for vpn paywall page (#27479) 2025-02-07 20:36:05 +01:00
samartnik ed6768db49 Merge pull request #27542 from brave/android_initial_bottom_address_bar_integration
[Android] Initial bottom address bar integration
2025-02-07 12:08:33 -05:00
Deep Pandya c96125629b Update search engine onboarding icons with vector drawables (#27541) 2025-02-07 11:57:02 -05:00
Serg d504a4e2c6 Gets result about link subscription from a web page on Android (#27423)
* Gets result about link subscription from a web page on Android

* Fixes code review suggestions
2025-02-07 09:12:45 -05:00
Deep Pandya f374095c11 Add null check for imageview (#27530) 2025-02-06 14:34:15 -05:00
Deep Pandya 8a53a7facd Add leo paywall for landscape (#27482)
Update copyright year
2025-02-06 18:45:24 +01:00
Artem Samoilenko bb1955f824 [Android] Initial bottom address bar integration 2025-02-05 15:28:16 -05:00
Kevin Smith 4cc241a866 Reconfigure Rewards component folder structure (#27270)
Fix directory structure per https://www.chromium.org/developers/design-documents/cookbook/
2025-01-31 13:47:34 -07:00
Deep Pandya de42cabc18 Add WDP build check (#27398)
* Add check for WDP native flag in onboarding

* Add check for build flag

* Update BravePrivactSettingsTest number of items
2025-01-30 08:37:52 -05:00
Serg f3dd05a602 Autofocuses input box on Android Leo chat window on a fresh chat 2025-01-29 13:44:38 -05:00
Deep Pandya 80e5f35d95 Merge pull request #27276 from brave/add_notification_permission_for_sync
Add notification permission for sync
2025-01-29 09:33:33 -05:00
deeppandya 498206e106 Show notification permission on sync chain
Resolve rebase conflict
2025-01-28 17:48:03 -05:00
deeppandya c8a75909c0 Add notification permission function in Utils
Add notification permission for sync
2025-01-28 17:48:00 -05:00
deeppandya 9da5774d9c Replace NoUnderlineClickableSpan with ChromeClickableSpan as chromium updated it with CR 133 2025-01-28 16:47:57 -05:00
deeppandya c04404e418 Add learn more link for WDP 2025-01-28 16:17:29 -05:00
deeppandya fd727bed00 Add changes for user to opt in for WDP 2025-01-28 16:17:27 -05:00
deeppandya f73720a5d3 Add onboarding card for WDP 2025-01-28 16:17:25 -05:00
vadims caf53a4dce Hiding the element blocker for OTR profile (#27364)
* hiding the element blocker for OTR profile
(https://github.com/brave/brave-browser/issues/43495)
---------

Signed-off-by: Vadym Struts <vstruts@brave.com>
2025-01-28 22:02:25 +01:00
Serg 6b2a46e5ba Prevents a crash when Fragment is detached from an Activity on Android (#27376) 2025-01-28 15:52:52 -05:00
Darnell Andries 3e42fd2ac8 Merge pull request #24969 from brave/wdp-native-cred-mgr-srv-config
Bootstrap Web Discovery Native, add credential manager and server config loading
2025-01-28 10:32:58 -08:00
Darnell Andries cf94b54d8b Bootstrap Web Discovery Native, add credential manager and server config loading 2025-01-27 18:22:39 -08:00
Serg 385973275d Fixes a few crash reports related to null pointers on Android (#27363) 2025-01-27 20:39:58 -05:00
Artem Samoilenko 4376cff975 [Android] Fix for UnusedMethod lint warning 2025-01-27 09:41:52 -05:00
Artem Samoilenko 5c0393d918 [Android] Remove password leak detection option
Detection is done on Google's backend, and so this feature doesn't apply to Brave.

Chromium change:
https://chromium.googlesource.com/chromium/src/+/65fe083143b4ecc55ab41f9cd5d6692da634c8b1

[M133] Relocate password leak toggle from safe browsing page to privacy page

This change removes the password leak detection toggle from the
standard protection fragment and makes it it's own setting on the
privacy page for Android. We are also removing the safebrowsing
protection level dependency on the password leak toggle enable status so
the now the user has free choice to select whether they want the
password leak toggle enabled regardless of safe browsing status.

We will also remove the enhanced protection bullet point about
password leak detection since that is no longer accurate.

Respective Desktop Implementation CLs:
https://crrev.com/c/6000457 & https://crrev.com/c/5899277

Password Leak Detection Screenshots:
Screenshot(Before):https://crbug.com/370770920#comment33
Screenshot(After):https://crbug.com/370770920#comment32

Enhanced Protection Screenshots:
Screenshot(Before):https://crbug.com/370770920#comment34
Screenshot(AFter):https://crbug.com/370770920#comment35

Fixed: 388883054

(cherry picked from commit 4586b7192eef92f12daa58ed2a34f3e2a392ce62)

Bug: 370770920
2025-01-27 09:41:52 -05:00
Artem Samoilenko 6cc7596cea [Android] Missing imports for WelcomeOnboardingActivity 2025-01-27 09:41:51 -05:00
Artem Samoilenko 638fab7c59 [Android] Disable safety hub settings
We will re-evaluate if new settings are useful for Brave in a separate issue https://github.com/brave/brave-browser/issues/43263
2025-01-27 09:41:46 -05:00
Artem Samoilenko 9cc9abab5f [Android] Rename NoUnderlineClickableSpan to ChromeClickableSpan
Chromium change:
https://chromium.googlesource.com/chromium/src/+/eda1322af61acc3f5cb40191fe897dc93d4b5095

Add underline to links

Based on the a11y team’s request, added underline to links across the product per GAR requirements.
Renamed NoUnderlineClickableSpan to ChromeClickableSpan and removed #setUnderlineText(false).
Updated ~70 render tests that were failing due to this fix.

The following are some of the before & after screenshots:

1. Delete browsing data
Before: https://screenshot.googleplex.com/69tSeP6YBGr95VU
After: https://screenshot.googleplex.com/7WujhWgczf2WmAj

2. Include surrounding text in Google searches
Before: https://screenshot.googleplex.com/9g8VhvttwhTJ79G
After: https://screenshot.googleplex.com/9jPxBG265WErHVk

3. Sad tab
Before: https://screenshot.googleplex.com/4qv7jVva8m9wnP3
After: https://screenshot.googleplex.com/5PwokFga4cw84KN

4. Autofill services
Before: https://screenshot.googleplex.com/Anvz2MZkC3dVEsP
After: https://screenshot.googleplex.com/8arauGBc6JrJQB5

5. Sign-in footer
Before: https://screenshot.googleplex.com/3dQ9kbgWpTvgGX8
After: https://screenshot.googleplex.com/6KBiPUxXyhdxvQc

6. Delete browsing data basic
Before: https://screenshot.googleplex.com/7Xf2kjSVBnjtb2C
After: https://screenshot.googleplex.com/7ZPRWZ7ofpnjEYn

7. Price tracking notifications
Before: https://screenshot.googleplex.com/8yNPhgd4yyjPuiH
After: https://screenshot.googleplex.com/BmhMTVaGjkK427n

8. Safe Browsing
Before: https://screenshot.googleplex.com/6Vtbvea44YQpkyF
After: https://screenshot.googleplex.com/8eHVcHbcjtoYb9H

Bug: 344043844
2025-01-27 09:41:44 -05:00