This target will serve as a reference of what has to be buildable at any
point for any given plastform. This should include Brave itself, tests,
and tools.
```sh
npm run build -- --target=brave:all
```
Resolves https://github.com/brave/brave-browser/issues/45516
* [cr137] [Android] Wait for native initialization when creating bottom strip
Chromium change:
https://chromium.googlesource.com/chromium/src/+/ea006a988d2a36db0eb25801e1c02e9c6e9f5b86
[Tab Group UI] Wait for native initialization when creating bottom strip
Wait for native initialization to complete before initializing the
bottom tab strip. Otherwise it will try to initialize pre-native and
crash. This appears to have regressed in M134/M135 likely due to some
lifecycle change for the BottomControlsCoordinator.
Fixed: 407305088
* Suppressed warning around ContextUtils.getAppSharedPreferences()
---------
Co-authored-by: Artem Samoilenko <artem@brave.com>
* Fixed some NullAway Java warnings and suppressed some others
* Suppressed warning around ContextUtils.getAppSharedPreferences()
because we cannot depend on //chrome from //base to use ChromeSharedPreferences
Fixesbrave/brave-browser#45541
* Strip BidiControl from download file name
* Fix downloads not working for data URIs
* Remove data-uri check. Just don't display any host if there is none (following Safari and Chrome)
This is an update to the Windows SDK with a repackaged SDK, that
includes a version of `d3dcompiler_47.dll` from `10.0.22621.2428`.
Resolves https://github.com/brave/brave-browser/issues/45263
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/fca8e8720feecf9faa988b92806b574cd530b23e
commit fca8e8720feecf9faa988b92806b574cd530b23e
Author: Devon Loehr <dloehr@google.com>
Date: Thu Mar 20 09:54:01 2025 -0700
Update Supported Windows SDK to 10.0.26100.3323
The floor bug (https://crbug.com/374162585) which blocked the previous roll has been addressed, so we're trying to update the SDK again.
Code changes are essentially the same as the previous update attempt
(https://crrev.com/c/5898835). Some minor changes to gate new SDK features behind a #define while we transition, and some regenerated image baselines to support the new 3D emojis. Note that updating mc.exe and midl.exe outputs produced no changes.
Pleasantly, the linking change to d3dcompiler_47.dll has been undone, so we no longer need to patch in an older version. This means the update is about as straightforward as it gets.
-----------------------------------------------------------------
Instructions to reproduce:
These instructions are best done on a fresh VM. Make sure to uninstall any existing installations of Visual Studio and any existing SDK installations before starting.
1. Install git for windows from their website, with the default settings (https://git-scm.com/downloads/win)
2. Install depot_tools following the instructions on their webpage (https://commondatastorage.googleapis.com/chrome-infra-docs/flat/depot_tools/docs/html/depot_tools_tutorial.html#_setting_up)
3. Run:
$ git config --global depot-tools.allowGlobalGitConfig true
4. Download Visual Studio Professional (Free Trial) from the official site (https://visualstudio.microsoft.com/downloads/)
5. Run the VS installer with the following arguments:
```
$ VisualStudioSetup.exe --add Microsoft.VisualStudio.Workload.NativeDesktop --add Microsoft.VisualStudio.Component.VC.ATLMFC --add Microsoft.VisualStudio.Component.VC.Tools.ARM64 --add Microsoft.VisualStudio.Component.VC.MFC.ARM64 --includeRecommended --passive
```
6. Open the VS installer (from the start menu), click “Modify”, and uninstall any existing SDK versions (search for “windows sdk”).
7. Open “Add or Remove Programs” and make sure there are no SDK versions installed; remove them if so (search for “windows software development kit”).
8. Download SDK Version 10.0.26100.3323 from the official site (https://developer.microsoft.com/en-us/windows/downloads/windows-sdk/)
9. Run the SDK installer with default settings, except disable “insights”.
10. Run the packaging script from depot_tools, e.g
$ python3 depot_tools\win_toolchain\package_from_installed.py 2022 -w 10.0.26100.0
Link to packaging script version used for packaging: https://source.chromium.org/chromium/chromium/tools/depot_tools/+/main:win_toolchain/package_from_installed.py;drc=371aa997c04791d21e222ed43a1a0d55b450dd53
This resulted in the final package with hash 076960eda6.
Bug: 362650376
Change-Id: Ib6cb299ab20cfca1e72f34728e6ea165ab057d05
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6252774
Reviewed-by: Keren Zhu <kerenzhu@chromium.org>
Reviewed-by: Dominic Farolino <dom@chromium.org>
Reviewed-by: Zequan Wu <zequanwu@google.com>
Commit-Queue: Devon Loehr <dloehr@google.com>
Reviewed-by: Giovanni Ortuno Urquidi <ortuno@chromium.org>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1435503}
cdesouza-chromium