Override illustrations added to the Cookies, Permission, and Safe
Browsing pages. They are not showing right now because we also disable
kPrivacySettingsRedesign feature, but this feature flag will go away in
Chromium 86.
The replacements are 1px high, same width as the originals, and transparent.
Chromium change:
https://chromium.googlesource.com/chromium/src/+/9f72153ac42b35aaaa5871451b180565e2ae758e
commit 9f72153ac42b35aaaa5871451b180565e2ae758e
Author: Sean Harrison <harrisonsean@chromium.org>
Date: Wed Apr 1 09:43:49 2020 +0000
Settings: Add new illustrations with light and dark mode
Add new light/dark illustrations to the cookies page, security page, and permissions page
Bug: 1032584
Chromium change:
https://chromium.googlesource.com/chromium/src/+/55acceb9eb6e671c1c42558d8411710e6611535a
commit 55acceb9eb6e671c1c42558d8411710e6611535a
Author: sauski <sauski@google.com>
Date: Tue Jul 7 09:30:14 2020 +0000
Privacy Settings Redesign: Solidify redesigned implementation
CL removes logic to support the pre-redesign version of settings. This
was previously dependent on the privacySettingsRedesignEnabled flag.
Bug: 1067336
Summary in Preference was reduced to 10 lines in the new AndroidX library.
Here we extended it and set maximum lines available.
Chromium change:
https://chromium.googlesource.com/chromium/src/+/ef3863977776f3e377328b56830c3e614078afbd
Update AndroidX preference library to v1.1.1
This also updates the preference library's dependencies:
core, annotation, collection, fragment
Binary-Size: New androidx fragment library is larger.
Bug: 1092986
Otherwise there is an error:
../../brave/android/javatests/org/chromium/chrome/browser/BravePrivateTabTest.java:8: error: symbol not found android.support.test.filters.SmallTest
import android.support.test.filters.SmallTest;
Chromium change:
https://chromium.googlesource.com/chromium/src/+/7b378cb12e97bb1b2f2692891e7b461590d94949
Use Material default preference layout
Replace custom preference layout with material default. This correctly
aligns icons under the action bar back arrow without the additional
logic and fixed paddings previously used.
This results in small UI shifts on settings screens with icons. See
https://crbug.com/1095981 for screenshots and UX approval.
Bug: 971791, 1095981
This is not an optional parameter anymore, need to explicitly pass it.
Chromium change:
https://chromium.googlesource.com/chromium/src/+/07c37aac7d883993f15c07c39ac3c29506d7ae6a
commit 07c37aac7d883993f15c07c39ac3c29506d7ae6a
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Mon Jun 29 07:58:30 2020 +0000
Remove default values from TestingProfile OTR API functions.
GetOffTheRecordProfile and HasOffTheRecordProfile functions in
TestingProfile had temporary default values for upgrading to new APIs.
All calls are updated before, and now the defaults are removed.
Bug: 1033903
This helper test method requires this parameter now, so let's pass
1 to keep the same behaviour that we have before this change.
Chromium change:
https://chromium.googlesource.com/chromium/src/+/903473ede0759fb9a90d29f0cc078e91d53ac793
commit 903473ede0759fb9a90d29f0cc078e91d53ac793
Author: Fergal Daly <fergal@chromium.org>
Date: Thu Jul 2 04:04:49 2020 +0000
Stop dividing the command-line-provided number of test jobs by 2.
The value should be half of the number of CPU cores or whatever
--test-launcher-jobs says. This change makes base::NumParallelJobs
return the number of CPU cores divided by a cores_per_job factor
supplied by each caller.
This also adds error checking on the result where it wasn't already
present.
Bug: 1096909
Previously, tab_hover_card_bubble_view_browsertest.cc would directly
access TabHoverCardBubbleView::widget_ to get the hover card widget,
which does no longer exist. Instead, we now need to use the new getter
added to the parent class BubbleDialogDelegateView.
Chromium change:
https://chromium.googlesource.com/chromium/src/+/be0e041591da8533dc5c969ed5f272eb475cc62b
commit be0e041591da8533dc5c969ed5f272eb475cc62b
Author: Caroline Rising <corising@chromium.org>
Date: Mon Jul 6 20:26:22 2020 +0000
TabHoverCardBubbleView cleanup and fix destruction crashing bug.
Before this change TabHoverCardBubbleView could be partially destructed
when delayed_show_timer_ ended. This change lets delayed_show_timer_
be destructed first.
Bug: 1096840
This extra output parameter was added to the signature of the method
so we need to adapt callers.
Chromium change:
https://chromium.googlesource.com/chromium/src/+/3cb10b91c99375d28754cc04649d6160c79658cf
commit 3cb10b91c99375d28754cc04649d6160c79658cf
Author: Aya ElAttar <ayaelattar@google.com>
Date: Wed Jul 15 00:15:11 2020 +0000
Pass destination on clipboard read
Added the ClipboardDataEndpoint destination trying
to read the clipboard data as a as a parameter for all
ui::Clipboard Read*() functions. This destination is intended
to be used only on ChromeOS and Test platforms.
This CL adds this plumbing. Implementation of filtering will
be done in following CLs.
Bug: 1096456
Many method referencing "master preferences" got renamed to reference
"initial preferences" instead, so we need to adjust this.
Chromium change:
https://chromium.googlesource.com/chromium/src/+/a7f076e8c5ccde5dee6735b00ab43bd951d7b592
commit a7f076e8c5ccde5dee6735b00ab43bd951d7b592
Author: Elly Fong-Jones <ellyjones@chromium.org>
Date: Mon Jun 29 21:13:55 2020 +0000
inclusion: rename "master_preferences" &c, part 1/n
This change renames:
* master_prefs::MasterPrefsPath -> initial_prefs::InitialPrefsPath
* first_run::internal::MasterPrefsPath -> ...::InitialPrefsPath
This is the first part of renaming the "master preferences" file and all
the code referencing it. A file in a platform-dependent location named
"master_preferences" or similar has historically been the documented way
to impose initial preferences in newly-created profiles. Removing
support for the old name would break backward compatibility, so this
sequence of CLs will instead:
1) Rename the concept from "master preferences" to "initial preferences"
throughout the codebase *without* changing the name of the actual
initial preferences file on disk
2) Add support for a secondary initial preferences file, named
"initial_preferences"
3) Update all public documentation to refer to the new
"initial_preferences" file instead
It is not likely that it will ever be possible to drop support for the
old filename, given its likely wide use, but this will at least improve
things.
Bug: 1097204
Chromium change:
https://chromium.googlesource.com/chromium/src/+/7d0b49b0aa5550c0302aa353a786d72fed07a4d0
commit 7d0b49b0aa5550c0302aa353a786d72fed07a4d0
Author: Robert Sesek <rsesek@chromium.org>
Date: Wed Jul 8 18:31:27 2020 +0000
Move //services/service_manager/sandbox to //sandbox/policy.
Originally the sandbox policies lived in //content, but with
servicification this would create unwanted dependencies between
//services and //content. Instead, create a new //sandbox/policy
library to hold the sandbox integration code. This library can depend
on the low-level //sandbox routines, but not nice versa.
Tbr: ajgo@chromium.org (mechanical change rule)
Bug: 1097376
Otherwise there is an error:
../../brave/build/android/bytecode/java/org/brave/bytecode/BraveClassVisitor.java:24: error: symbol not found org.objectweb.asm.tree.ClassNode
import org.objectweb.asm.tree.ClassNode;
The current number of tokens on my machine is 1879922, which greatly
exceeds the limit of 900K recently added usptream.
Chromium change:
https://chromium.googlesource.com/chromium/src/+/6d647737c27eaefb061fc6500147a694d1b03789
commit 6d647737c27eaefb061fc6500147a694d1b03789
Author: Kent Tamura <tkent@chromium.org>
Date: Fri Jul 10 09:18:28 2020 +0000
Add max_tokens_here for document.h
The current number of tokens for document.h is 898,916 on my local
machine.
This CL has no behavior changes.
Bug: 1049569
Prior to cr86, it overwrote of DownloadItemView::GetYForFilenameText(),
but that's no longer an existing method in that parent class.
Chromium change:
https://chromium.googlesource.com/chromium/src/+/316bd1dd529d469af7b4751a5cdd999d6c277f87
commit 316bd1dd529d469af7b4751a5cdd999d6c277f87
Author: Peter Kasting <pkasting@chromium.org>
Date: Thu Jul 16 04:20:59 2020 +0000
Refactor DownloadItemView state transitions, part 3.
This adds a helper, UpdateLabels(), to set all labels' visibility, text,
and style based on the current mode; this replaces the scattered pieces
throughout other functions.
The file name label's style changes based not on the mode but on the
enabled state of the whole view; update that in the functions that set
the view's enabled state.
The above two changes mean that UpdateColorsFromTheme() now only deals
with colors, and thus no longer need be called outside OnThemeChanged().
Renames |dangerous_download_label_| to the more accurate (and shorter!)
|warning_label_|.
For some reason UpdateMode() was also sometimes setting the file name
label's Y coordinate. This is done in layout, and there's no reason to
do it here.
Otherwise build will fail since gfx::AcceleratedWidget is an uint32_t.
Chromium change:
https://chromium.googlesource.com/chromium/src/+/06046d63974233252873292adbee780ffaee5f82
commit 06046d63974233252873292adbee780ffaee5f82
Author: Maksim Sisov <msisov@igalia.com>
Date: Fri Jun 26 07:02:29 2020 +0000
X11 and Ozone: make sure gfx::AcceleratedWidget to be uint32_t
Currently, Ozone/X11 defines gfx::AcceleratedWidget as
int32_t whereas non-Ozone/X11 defines that as x11::Window
or uint32_t. To fix the inconsistency and allow use_x11 &&
use_ozone builds, make non-Ozone/X11 uses Ozone's definition
of gfx::AcceleratedWidget.
Also adds missing includes.
Bug: 1098267
This method has been removed upstream since its only logic has now
been merged into its constructor.
Chromium change:
https://chromium.googlesource.com/chromium/src/+/668e2071c430e324a3ec6e2ffad895aedc618aac
commit 668e2071c430e324a3ec6e2ffad895aedc618aac
Author: Sangwoo Ko <sangwoo.ko@navercorp.com>
Date: Fri Jun 26 21:04:21 2020 +0000
Remove ToolbarButton::Init()
It just sets FocusBehavior and if it's basic behavior all toolbar
buttons, it can be done in constructor
Bug: 1099601
Chromium change:
https://chromium.googlesource.com/chromium/src/+/930e44d29b15ba30d02ed06d28c127862c078dc7
commit 930e44d29b15ba30d02ed06d28c127862c078dc7
Author: Matt Menke <mmenke@chromium.org>
Date: Thu Jul 16 02:26:44 2020 +0000
Move URLRequest::FirstPartyURLPolicy into RedirectInfo.
RedirectInfo is the main consumer of this field, so currently has to
include url_request.h. RedirectInfo is sent across processes via Mojo
messages, which means the Network Service's Mojom files have to include
url_request.h. As a result, ~8,000 build steps are indirectly depending
on url_request.h. Not only do almost all of them not actually need
url_request.h, but this means they also include a fair number of net/
header files, which slows build time and makes rebuilding chrome after
modifying any of a number of files slow.
Moving FirstPartyURLPolicy to RedirectInfo solves this problem.
Bug: 1103784
Chromium change:
https://chromium.googlesource.com/chromium/src/+/257bcabbc59957ebbeb549c06ff62857a76e2514
commit 257bcabbc59957ebbeb549c06ff62857a76e2514
Author: Richard Knoll <knollr@chromium.org>
Date: Mon Jul 6 21:06:54 2020 +0000
[Nearby] Add NearbyNotificationManager and handler
This adds a basic progress notification that will be properly translated
in a follow up CL. We add a new NotificationHandler type so we can use
native notifications on all supported desktop OSs. Handling notification
actions is guarded by the kNearbySharing flag.
Bug: 1102348
Chromium change:
https://chromium.googlesource.com/chromium/src/+/23b4ec91c36c130c799ec4c8b4001cee24085f5c
commit 23b4ec91c36c130c799ec4c8b4001cee24085f5c
Author: Jan Krcal <jkrcal@chromium.org>
Date: Wed Jul 1 04:37:45 2020 +0000
[User menu] Refactor setting profile identity into one function
This CL is a refactoring before a minor update of the design of the
profile menu. This CL brings no behavioral change.
This change is needed because in the new design, the layout of the
profile name heading and the layout of the identity info are more
intertwined and thus it is opportune to set them in one function.
Bug: 1099286
Chromium change:
https://chromium.googlesource.com/chromium/src/+/7492117659dab49c3f4d7c16af696af428e5e3a1
commit 7492117659dab49c3f4d7c16af696af428e5e3a1
Author: Marc Treib <treib@chromium.org>
Date: Tue Jul 7 15:19:56 2020 +0000
[CBD] Wire password deletion failure to the UI
Before this CL, BrowsingDataRemover did not expose the concept of
"deletion failure", i.e. when a requested deletion could not be
completed. (An example of such a deletion failure is a timeout, which
BrowsingDataRemoverImpl sets to 30 seconds.)
This CL adds the concept of "failed data types" to the API. They're
represented as a bitmask of DataTypes - the same format that's used to
request deletion in the various Remove*() methods.
So far, the only data type that will actually report deletion errors is
DATA_TYPE_PASSWORDS, but support for more types can easily be added.
None of the clients/observers does anything with the new information
yet; that's left for a future CL.
Bug: 1086433
Chromium change:
https://chromium.googlesource.com/chromium/src/+/42e9330687356ecfaaa63e41e9ace81226fef8b7
commit 42e9330687356ecfaaa63e41e9ace81226fef8b7
Author: James Cook <jamescook@chromium.org>
Date: Mon Jul 6 20:56:12 2020 +0000
Make ChromeBrowserMainParts::AddParts() take a std::unique_ptr
The function takes ownership of its argument, so change to unique_ptr
to make that clear.
Also remove "virtual" from the function because nothing overrides it.
No behavior changes - I just happened to notice this while adding a
new ExtraParts class in a different CL.
It has been moved from Blink's public/mojom into public/mojom/loader,
so we need to update include paths.
Chromium change:
https://chromium.googlesource.com/chromium/src/+/60693aa5a0a281ba33d7ad08da48dc8170288983
commit 60693aa5a0a281ba33d7ad08da48dc8170288983
Author: Hiroki Nakagawa <nhiroki@chromium.org>
Date: Thu Jul 16 09:01:41 2020 +0000
Loader: Move referrer.mojom into blink/public/mojom/loader
blink/public/mojom/loader is a more suitable place for referrer.mojom
than the Blink's top-level mojom directory (i.e., blink/public/mojom) in
terms of code structure.
Chromium change:
https://chromium.googlesource.com/chromium/src/+/e06e20c09c3ee52af0a4040e8582243ec661e414
commit cdec7f4c2965655fd83393b7f64abfce8b1c7c40
Author: Matt Menke <mmenke@chromium.org>
Date: Wed Jul 15 17:59:54 2020 +0000
Move URLRequest::ReferrerPolicy enum into its own file.
This enum is part of the NetworkService API, and files outside of the
network service shouldn't need to transitively include a bunch of net/
classes to use it.
This CL also converts it from an enum to an enum class.
This CL is part of a chain of CLs that will reduce the 4000 build
steps in content_browsertests currently depending on url_request.h
to about 200.
Bug: 1103784
Chromium change:
https://chromium.googlesource.com/chromium/src/+/96ecc0aa4768e41e5d6c6bc7d45834e802dacbdc
commit 96ecc0aa4768e41e5d6c6bc7d45834e802dacbdc
Author: Robert Kaplow <rkaplow@chromium.org>
Date: Thu Jul 16 15:29:09 2020 +0000
Trim in-memory logs in unsent_log_store when attempting to persist.
This will actually trim large logs if they cannot be uploaded right away.
I'm not sure this is behavior we want, although I presume logs large enough
to hit our limits (looks like 100K currently from
metrics_reporting_service.cc) are large enough it probably makes sense to
trim. Curious if you think this is risky.
After writing this, i considered changing the API such that the trimming
call and persisting are seperate. Not sure which is better, but trimming at
the time of persisting seems like a reasonable place to do it, so left it
this way as it is simpler.
Bug: 1098317
This means renaming uses of ServiceBinding to ServiceReceiver, as
well as removing any use of the old InterfaceRequest<T> type (e.g.
used by the ServiceRequest alias) and use PendinReceiver<T> instead.
Chromium change:
https://chromium.googlesource.com/chromium/src/+/bb551f12072ebf7a9af6df26a51d125f90078453
commit bb551f12072ebf7a9af6df26a51d125f90078453
Author: Gyuyoung Kim <gyuyoung@igalia.com>
Date: Thu Jul 2 00:12:00 2020 +0000
Convert mojom::ServiceRequest to PendingReceiver<mojom::Service>
There are many uses of mojom::ServiceRequest. This CL migrates
them to PendingReceiver<mojom::Service>.
Besides that, ServiceBinding is renamed to ServiceReceiver and
the variable name is also changed from |binding_| to |receiver_|
or |service_binding_| to |service_receiver_|.
Bug: 955171
This whole directory does no longer exist upstream.
Chromium change:
https://chromium.googlesource.com/chromium/src/+/742de287e968fceeddd15f086f135057fcc5da71
commit 742de287e968fceeddd15f086f135057fcc5da71
Author: Marc Treib <treib@chromium.org>
Date: Mon Jul 13 08:18:09 2020 +0000
Delete third_party/cacheinvalidation
It has been essentially unused for a while.
Apart from deleting the code, this CL contains the following changes:
- In ChromeGcmListenerService: stop passing incoming
GCM messages to the cacheinvalidation code.
- In ProcessInitializationHandler: stop initializing cacheinvalidation's
Logger class.
- Create a dummy GcmRegistrationTaskService: This service (part of the
cacheinvalidation library) is listed in the AndroidManifest.xml as
exported, so it's part of Chrome's public API and can't just be
removed. Adding an empty dummy implementation lets us keep the
manifest entry without the actual implementation from the library.
Bug: 1099672
The patch is no longer needed as the Chromium change no longer creates a
new instalnce of AndroidSyncSettings in the testing c'tor (instead it
needs to be passed in).
Chromium change:
https://source.chromium.org/chromium/chromium/src/+/7839b373c49781e224901e13b1c752c62053fe01
commit 7839b373c49781e224901e13b1c752c62053fe01
Author: Boris Sazonov <bsazonov@chromium.org>
Date: Fri Jul 10 09:16:51 2020 +0000
[Signin][Android] Ensure AndroidSyncSettings is created on the UI thread
Ensure AndroidSyncSettings.get() is only invoked on the UI thread. This
is necessary for migration to IdentityManager, as it can only be used
from the UI thread.
Bug: 1093998
The entitlement we were patching out was moved to a different plist that
is branded only for Chrome.
Chromium change:
https://chromium.googlesource.com/chromium/src/+/587c802620ba356ba369328041bf7dccd1cc014f
commit 587c802620ba356ba369328041bf7dccd1cc014f
Author: Robert Sesek <rsesek@chromium.org>
Date: Wed Jul 1 15:14:02 2020 +0000
mac: Divide the entitlements into Chrome-specific and Chromium files.
This let the signing scripts work out-of-the-box with Chromium builds.
The existing app-entitlements.plist file is split into two: in that file
are all the entitlements that work with any signed build of the product,
but the entitlements that are bound to the Google Chrome signing
identity are moved into a new app-entitlements-chrome.plist.
Bug: 1021255
mkarolin