This change removes all the remaining occurrences of these functions
being used with a single argument, following upstream deprecation.
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/b843c806672c1e1b950f0868ddde79390c1eea69
commit b843c806672c1e1b950f0868ddde79390c1eea69
Author: Jonathan Lee <jonathanjlee@google.com>
Date: Mon Oct 13 16:04:32 2025 -0700
Roll src/third_party/googletest/src/ 244cec869..7917641ff (4 commits)
**Note to gardeners**: This CL may be incompatible with other CLs that
add new usage of single-argument `testing::{DoAll,Invoke}`, which are
deprecated. Please prefer forward-fixing by cleaning up the deprecated
callsites instead of reverting this roll. The forward-fix is well-
understood (crbug.com/439838457), and we want CQ to stop new deprecated
callsites from landing.
https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/244cec869d12..7917641ff965
$ git log 244cec869..7917641ff --date=short --no-merges --format='%ad %ae %s'
2025-09-02 dmauro Bump Abseil dependency to 20250814.0
2025-08-24 absl-team Remove unused syslog dependency for Fuchsia.
2025-08-19 absl-team Internal header include changes.
2025-08-16 absl-team Deprecate single-argument DoAll and Invoke.
Created with:
roll-dep src/third_party/googletest/src
Change-Id: Id197f789d82c374e16b07153012983792fcb4be7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6920668
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Jonathan Lee <jonathanjlee@google.com>
Cr-Commit-Position: refs/heads/main@{#1529188}
The existing override in brave for the instantiation of
`BraveSavedTabGroupBar` was broken once the local `browser_` field was
converted into a `BrowserWindowInterface*`. This change provides the
`Browser*` value again to the constructor in the same way the upstream
code is doing.
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/a3248bace171d5a92a5e94d152334ef002df95ab
commit a3248bace171d5a92a5e94d152334ef002df95ab
Author: Thomas Lukaszewicz <tluk@chromium.org>
Date: Mon Oct 13 14:51:12 2025 -0700
[bedrock] Eliminate calls to Browser::IsBrowserClosed() part 1
Currently there are three closing related methods exposed on Browser:
- IsAttemptingToCloseBrowser()
- IsBrowserClosed()
- is_delete_scheduled()
Currently attempts to close the browser can be blocked for any number of
reasons:
- Important browser dialogs that need to be shown before close
e.g. warn-before-closing dialogs
- Before unload handlers (can cancel closing the tab)
- Configurable policies can block closing a tab
These checks may happen async - and while this happens
IsAttemptingToCloseBrowser() will return true until the Browser is
deleted or the close is blocked / cancelled.
is_delete_scheduled_ becomes true once all the blocking checks above
have been cleared (close is confirmed and cannot be blocked) and the
Browser is scheduled for async destruction.
IsBrowserClosed() currently is set to true at an arbitrary point during
the Browser close attempt (at a point close can still be blocked by tab
policy for e.g.). It's behavior is incorrect and not necessary (clients
should be query either IsAttemptingToCloseBrowser() or
is_delete_scheduled() depending on their needs).
This CL replaces calls to Browser::IsBrowserClosed() with checks against
either IsAttemptingToCloseBrowser() or is_delete_scheduled() depending
on which is appropriate.
Bug: 450660162
Change-Id: I7b666471f4acf8371c692cf45c4fed530a9982dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7035131
Commit-Queue: Tom Lukaszewicz <tluk@chromium.org>
Reviewed-by: Fred Shih <ffred@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1529151}
It is not very clear how this function call has been working all along,
but it is clear the call itself is supposed to be routed via the
TabStripModel.
All the mentions to this enum value in Brave were required enumaration
list where it was treated similar to `DENIED`.
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/de9d0f6c71f986bedf12a1c7e3308b0467ee30df
commit de9d0f6c71f986bedf12a1c7e3308b0467ee30df
Author: Antonio Sartori <antoniosartori@chromium.org>
Date: Mon Oct 13 04:58:34 2025 -0700
[permissions] Remove PermissionStatus::UNSATISTIED_OPTIONS
This CL removes PermissionStatus::UNSATISFIED_OPTIONS. The initial
purpose of it was to inform that a request for a capability could be
downgraded to less strict options (i.e. request for precise location
but only approximate is granted).
This only applies to GEOLOCATION at the moment. However, the pattern
that we currently have in the code [1] is that we can only request
permission for GEOLOCATION (without specifying precise/approximate)
and the selected granularity can be inspected looking at the returned
PermissionResult.
In practice, UNSATISFIED_OPTIONS at the moment is coupled to the
states of approximate and precise location (returned in the
PermissionResult), representing indirectly the same information.
However, it happens that it is not propagated correctly, and things go
out of sync. By removing it, we fix those kind of bugs and avoid the
weird situation in which the caller of a permission check needs to
check both things and does not know what to do if they are
inconsistent.
We can think later on whether we'll actually need to introduce this
again.
[1] https://source.chromium.org/chromium/chromium/src/+/main:content/browser/geolocation/geolocation_service_impl.cc;l=52;drc=62a9a00176f862e688fa47919ed6f19b59f77b5f
Change-Id: Ie23422fe3125b9527da9847f1c9b5456cb6cde4d
Bug: 393053278
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7030883
Commit-Queue: Antonio Sartori <antoniosartori@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Andy Paicu <andypaicu@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1528842}
This value was being patched by us to use our own tree, however that's
not necessary anymore.
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/b2db8fa9667498feafdb6795f51ed9602454e4f0
commit b2db8fa9667498feafdb6795f51ed9602454e4f0
Author: Lukasz Anforowicz <lukasza@chromium.org>
Date: Mon Oct 13 16:36:54 2025 -0700
[rust] Remove most remaining `cargo-vet`-related code pieces.
This CL keeps `chromium_crates_io/supply-chain/audits.toml` (to avoid
the risk of breaking https://github.com/google/rust-crate-audits), but
removes other `cargo-vet`-related functionality from Chromium:
* `supply-chain/config.toml`
* `gnrt` functionality related to generating `config.toml`
* `tools/rust` scripts for building the
`third_party/rust-toolchain/bin/cargo-vet` binary.
Manually tested by:
* `cargo test` under `tools/crates/gnrt`
* `tools/crates/run_gnrt.py gen` and verifying that no changes are
generated
Bug: 405980483
Change-Id: Idba9c73ba951a2ae9b5b46fdd59c6facbdf7ff03
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7037020
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1529201}
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/cb981d31a11e2ad9d9d519e2d790e12e1fedfa3c
commit cb981d31a11e2ad9d9d519e2d790e12e1fedfa3c
Author: Masa Fujita <massan@google.com>
Date: Thu Oct 9 20:03:59 2025 -0700
flyout: a11y: Allow users to control flyout menus with keyboard
This CL adds the ability for the user to use the keyboard to control the
flyout menus.
When the user selects an item with arrow keys and decides to proceed,
the `View`'s click listeneris called. We capture this and run the flyout
logic when necessary.
This CL also makes it so that `ListMenuItemAdapter` sets up the view to
use both the delegate and the click listener upon click.
Bug: 447103380
Change-Id: I4560508cdfe63fab553e44478bb48d3ed528caca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6978443
Reviewed-by: Peter Conn <peconn@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Jenna Himawan <jhimawan@google.com>
Commit-Queue: Masa Fujita <massan@google.com>
Cr-Commit-Position: refs/heads/main@{#1527899}
With the introduction of this class, the override for
`NotifyPinnedContainerOfActiveStateChange` is not viable anymore and
moves to `SidePanelToolbarPinningController::UpdateActiveState`, as this
is where the code lives now.
Also, GetActionItem moved to SidePanelUtil.
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/f8878892623fb7b457d7e8b1fed9566350be53c6
commit f8878892623fb7b457d7e8b1fed9566350be53c6
Author: Steven Luong <stluong@chromium.org>
Date: Fri Oct 10 15:08:56 2025 -0700
[SidePanel] Move pinning logic out of SidePanelCoordinator
Currently the pinning logic is in the SidePanelCoordinator and should
be moved to a dedicated class that handles pinning because it is only
relevant for the side panel header.
Bug: 450649530
Change-Id: I4da6ff24bbc2e076efdaf26d8377683865e63482
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7029539
Reviewed-by: Eshwar Stalin <estalin@chromium.org>
Commit-Queue: Steven Luong <stluong@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1528396}
Brave doesn't support Google Wallet, therefore this URL is being
stubbed.
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/380c84ee932222d10b5d9ec1135f65ef3961fa43
commit 380c84ee932222d10b5d9ec1135f65ef3961fa43
Author: Julia Sobiech <jsobiech@google.com>
Date: Fri Oct 10 13:30:22 2025 -0700
[Settings/Autofill] Add `category-reference-card` component
This new component displays a card with a title and a list of chips.
Each chip consists of an icon and a label. The page is filled with
example chip data and final data hierarchy will be introduced in a
following CL.
Bug: 433612617
Change-Id: I1bed25c4d01e53364edb46868a9e9c2cc6c9ccba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6973441
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Julia Sobiech <jsobiech@google.com>
Reviewed-by: Stanislav Mikheyev <mikhe@google.com>
Cr-Commit-Position: refs/heads/main@{#1528335}
This value is now set with the help of `BrowserCreatedObserver`.
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/5202ab57139b9c0d8a6be73af944eb5601a09d74
commit 5202ab57139b9c0d8a6be73af944eb5601a09d74
Author: Thomas Lukaszewicz <tluk@chromium.org>
Date: Wed Oct 8 18:22:18 2025 -0700
[bedrock] Remove InProcessBrowserTest::SelectLastActive()
There are no intended behavioral changes in this CL, this is purely
a test refactor.
This CL replaces all remaining uses of SelectFirstBrowser() with
SetBrowser(), forcing tests to be explicit which Browser instance
is being set to default - eliminating the dependency on
BrowserList ordering.
During setup the last-active Browser is now set as the default
Browser instance. In the vast majority of cases (barring possibly
session-restore browser tests) this is the only Browser instance in
the environment.
Bug: 431672609
Change-Id: I0c0eb6e0a7a5b8a7d194c6b27ee3f90ac2972c1b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7019129
Commit-Queue: Tom Lukaszewicz <tluk@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1527272}
`MemoryPressureListener` is now an abstract class. This change for now
migrates to use `MemoryPressureListenerRegistration`, but the
constructor chosen is already deprecated. Another mirgation will take
place once the path for it is a bit clearer.
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/220ae86e5c28f0c21a64990cae0a28d1f234b0fc
commit 220ae86e5c28f0c21a64990cae0a28d1f234b0fc
Author: Patrick Monette <pmonette@chromium.org>
Date: Thu Oct 9 20:29:28 2025 -0700
Add MemoryPressureListener interface
This change adds an new constructor overload to
MemoryPressureListenerRegistration that accepts a pointer to a
MemoryPressureListener implementation.
Bug: 436324601
Change-Id: I0440405e56d986417d8245c73f4263b34cb5f80e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7016598
Reviewed-by: Francois Pierre Doray <fdoray@chromium.org>
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1527903}
Unfortunately with the current way how `ChromeBrowserMainParts` is
replaced with a `ChromeBrowserMainParts_ChromiumImpl` there a certain
viral aspect to it, where the external functions using the same class
point end up pointing to a derived class, rather than the Chromium
implementation one.
This change applies this substitution in other places where
`ChromeBrowserMainParts_ChromiumImpl` is expected because the function
in question is called in the body of `ChromeBrowserMainParts`.
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/d71ed037ed0acb08f0c4416e5673d31b047df708
commit d71ed037ed0acb08f0c4416e5673d31b047df708
Author: Lei Zhang <thestig@chromium.org>
Date: Thu Oct 9 12:59:50 2025 -0700
Move ChromeBrowserMainParts code out of chrome_content_browser_client.cc
Currently, ChromeContentBrowserClient::CreateBrowserMainParts() does all
the work of selecting the right parts to instantiate. Move this code
into a new ChromeBrowserMainParts::Create() instead. Then
chrome_content_browser_client.cc, which is the one of the largest and
slowest to compile files in the source tree, builds about 3 seconds
faster in build time benchmarks on a physical workstation. While
chrome_browser_main.cc, which compiles in about half the time, builds
about 2.5 seconds slower. Given modern CPUs with many cores, this better
balances parallel work. Since compiling chrome_content_browser_client.cc
blocks the critical path to linking the chrome binary, this speeds up
the overall build by about 3 seconds.
Change-Id: I4223aa5fc88f615b5157397fffdc47a8b88a7d2c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7022412
Reviewed-by: Erik Chen <erikchen@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1527728}
This class is now named `ExtensionsMenuViewPlatformDelegateViews`. This
affects the patch and override in place for it.
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/52cb76cffd1782264aef9daf6e1ea7fb325af6bf
commit 52cb76cffd1782264aef9daf6e1ea7fb325af6bf
Author: EmiliaPaz <emiliapaz@chromium.org>
Date: Thu Oct 9 17:00:40 2025 -0700
[Extensions] Change menu platform delegate views name
ExtensionsMenuViewController was used as the extensions menu
controller for views::View. With the introduction of a
platform-agnostic menu controller, it is renamed to
ExtensionsMenuViewPlatformDelegateView.
No functionality changed.
Bug: 449814184
Bypass-Check-License: moved file
Change-Id: I09337c68145af5e051568def8ac75da48057dd8c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7018110
Reviewed-by: Tim <tjudkins@chromium.org>
Commit-Queue: Emilia Paz <emiliapaz@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1527847}
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/8e0ca53362ef330a49b98c7add3a7857fc82405e
commit 8e0ca53362ef330a49b98c7add3a7857fc82405e
Author: Martin Šrámek <msramek@chromium.org>
Date: Tue Oct 7 11:40:45 2025 -0700
Remove the kLinkedServicesSetting disabled code on Desktop and Android
Since the feature has been launched.
Apart from removing many references to the feature, flag, and tests, we're also adapting the ManageSyncSettings code from the previous approach (where the old strings were set in the XML file and the new strings programmatically overwritten in the Java code) to one where the strings are simply set in the XML file.
We're not removing the equivalent codepaths on iOS, where it hasn't launched yet.
Bug: 343132001
Change-Id: I8b92689b67db9485e87dd99657a32f1601277553
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7006398
Reviewed-by: Rainhard Findling <rainhard@chromium.org>
Commit-Queue: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1526439}
This affects the constructor declaration, with some reordering.
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/43f894f3cc8906a052fddc7264518d6b039a3e9b
commit 43f894f3cc8906a052fddc7264518d6b039a3e9b
Author: dljames <dljames@chromium.org>
Date: Wed Oct 8 15:00:03 2025 -0700
[TBHSP] Add MainRegion container view
The main_region_ is introduced to hold 2 things:
1) The main_container_ (holds the primary UI elements that are affected
by the ToolbarHeightSidePanel)
2) The toolbar height side panel
This change allows us to resize the main components of the browser
together while allowing the toolbar height side panel to display to its
full height.
Change-Id: I4dcddca73d28d0c95def11427f349ebeb4e37049
Bug: 448163576
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7014039
Commit-Queue: Darryl James <dljames@chromium.org>
Reviewed-by: Eshwar Stalin <estalin@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1527179}
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/e9da334545f4152c14f5e60b2209b89ae7f49d9b
commit e9da334545f4152c14f5e60b2209b89ae7f49d9b
Author: Xi Han <hanxi@google.com>
Date: Fri Oct 3 14:58:20 2025 -0700
[Theme] Refactor initialization of NtpCustomizationConfigManager.
In this CL, we split the initialization of NtpCustomizationConfigManager:
- For customized colors: move to maybeInitializeColorTheme() and it is
triggered when listener is added which can provide the current
Activity's context. This is because a colorId could return different
color value in light|dark modes.
- For customized images: initialization remains in the constructor.
This is a refactoring CL without any behaviour changes.
Bug: 423579377
Change-Id: I9852565c0d4042fa4f0a4970756823ad88e6dd10
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7003871
Reviewed-by: Xinyi Ji <xinyiji@chromium.org>
Commit-Queue: Xi Han <hanxi@chromium.org>
Reviewed-by: Wenyu Fu <wenyufu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1525042}
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/b6ebd28f9a489688be248371f224d79ca2d93604
commit b6ebd28f9a489688be248371f224d79ca2d93604
Author: Xi Han <hanxi@google.com>
Date: Fri Oct 3 10:16:24 2025 -0700
[Theme] Refactor LogoView to use Drawable from SVG file.
Today, the LogoView uses png files to draw Google Logo, which isn't
efficient in binary size and performance. In this CL:
1. Add ic_google_logo.xml, which could replace all google_logo.png;
2. In LogoView, add logo Drawable.
3. All changes are behind flag.
This is a refactoring CL without any behaviour changes.
Video: http://shortn/_uEO2ICjrUF.
BYPASS_LARGE_CHANGE_WARNING: will be removed in crrev.com/c/7004745 .
Bug: 423579377
Change-Id: I16690a7989e9fd15837a132a073792bcce318ee7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7003403
Commit-Queue: Xi Han <hanxi@chromium.org>
Reviewed-by: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1524855}
The workround for these are not necessary anymore, as upstream has
rolled out a solution to make these paths absolute.
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/c0a2debb2e8d313dcb992cdfb2710b6c39ce6a4b
commit c0a2debb2e8d313dcb992cdfb2710b6c39ce6a4b
Author: Lukasz Anforowicz <lukasza@chromium.org>
Date: Mon Oct 6 09:43:37 2025 -0700
[rust] Avoid explicitly using build directory in ninja-level args.
Before this CL, arguments of `rustc_wrapper.py` could have contained
machine-specific bits (e.g. `OUT_DIR=../../../../out/Default/....`).
Such machine-specific bits are in general unfriendly toward caching
and distributed builds.
After this CL, we compute `OUT_DIR` as a path relative to the build
root (rather than relative to the crate root). This avoids having
machine-specific bits in arguments of `rustc_wrapper.py`.
But only making the change above would break
`include!(concat!(env!("OUT_DIR"), "/foo.rs")) because `rustc` resolves
such `include!` path relative to the crate root. So this CL also
modifies `rustc_wrapper.py` to rewrite all environment variables to
absolute paths (including `OUT_DIR` and `SDKROOT`; the latter was
already being rewritten even before this CL).
But only making the changes above would means that `.d` files contain
absolute paths and `ninja` / `siso` complain and error out when that
happens. So this CL also tweaks `rustc_wrapper.py` to rewrite `.d`
files to use build-root-relative paths.
Fixed: 448040713
Fixed: 300352286
Change-Id: I4b7674ddfeafb1d62dcd3658707c3e81989cc006
Cq-Include-Trybots: chromium/try:android-rust-arm32-rel
Cq-Include-Trybots: chromium/try:android-rust-arm64-dbg
Cq-Include-Trybots: chromium/try:android-rust-arm64-rel
Cq-Include-Trybots: chromium/try:linux-rust-x64-dbg
Cq-Include-Trybots: chromium/try:linux-rust-x64-rel
Cq-Include-Trybots: chromium/try:win-rust-x64-dbg
Cq-Include-Trybots: chromium/try:win-rust-x64-rel
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7006886
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1525663}
This function's arg list has changed, and therefore it needs to match
the upstream arglist.
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/35efa85f133fe268730020986fba73403fad1213
commit 35efa85f133fe268730020986fba73403fad1213
Author: Mike Wittman <wittman@chromium.org>
Date: Mon Oct 6 11:14:25 2025 -0700
Default to the same task runner for model loading and execution
Moves model loading onto the same task runners as are used for
execution, for the purpose of having identical task execution priority.
Excludes AutocompleteScoringModelHandler which runs its model on the
main thread, and where we don't want to do file I/O.
Rationale: if running a model is important enough to have user visible
or user blocking impacts, it's very likely that clients will want to
load the model as soon as possible and not wait for best effort task
execution.
Bug: 429938366
Change-Id: Iad24ac32845f21a27afbe24af12f1ee7fec14607
AX-Relnotes: n/a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6972854
Reviewed-by: Xinghui Lu <xinghuilu@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Dana Fried <dfried@chromium.org>
Reviewed-by: Siddhartha S <ssid@chromium.org>
Reviewed-by: Salvador Guerrero Ramos <salg@google.com>
Commit-Queue: Mike Wittman <wittman@chromium.org>
Reviewed-by: Nathan Memmott <memmott@chromium.org>
Reviewed-by: Elias Klim <elklm@chromium.org>
Reviewed-by: manuk hovanesian <manukh@chromium.org>
Reviewed-by: Dominic Battre <battre@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1525726}
The previous unique token is gone, and this change uses a different one.
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/d031210359bc83e34633a9ec8ebf8fbd44687b69
commit d031210359bc83e34633a9ec8ebf8fbd44687b69
Author: Dana Fried <dfried@chromium.org>
Date: Mon Oct 6 10:23:39 2025 -0700
[Browser Layout] Switch to new frame layout API by default
This CL:
- Makes the "use new layout" feature into an always-on killswitch
- Renames BrowserViewLayoutDelegateImplNew to
BrowserViewLayoutDelegateImpl
- Removes references to the feature flag elsewhere
The effect will be that in addition to the flag being on for all CQ
testbots and ToT builds, it will also be on for Canary, Dev, and CI
bots.
This should allow us to collect error reports from more users and
determine if there are any issues with the new logic.
Bug: 443123625
Change-Id: Id2d7f6818ed1aba1ed8842b24275e0e7dfe0488e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7011507
Commit-Queue: Dana Fried <dfried@chromium.org>
Reviewed-by: Darryl James <dljames@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1525685}
This feature was being disabled, however this recent CL has completely
removed the code it was guarding.
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/ac1a331a845ff0eb45787915b786e34cd7e96085
commit ac1a331a845ff0eb45787915b786e34cd7e96085
Author: Joshua Hood <jdh@chromium.org>
Date: Mon Oct 6 08:21:03 2025 -0700
Delete the Origin Trial for Third Party Cookie Deprecation
The removal includes:
- Deleting the tpcd::trial::OriginTrialService and its factory.
- Removing the TOP_LEVEL_TPCD_ORIGIN_TRIAL content setting.
- Cleaning up related logic in CookieSettings and other components.
- Removing the kTopLevelTpcdOriginTrial feature flag.
Bug: 448432611
Change-Id: I32fe899067ddb7d18a9a7d564c60844d676597d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7004601
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Joshua Hood <jdh@chromium.org>
Reviewed-by: mmenke <mmenke@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1525614}
This function used to offer an alterate URL outparam, but that's now a
functionality offered by a separate function.
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/e1f54419f9f4c4adfda94f4bdbac16517586ee4c
commit e1f54419f9f4c4adfda94f4bdbac16517586ee4c
Author: Lei Zhang <thestig@chromium.org>
Date: Fri Oct 3 17:36:36 2025 -0700
Rename OmniboxEditModel::CurrentMatch() and add simpler CurrentMatch()
Currently, almost all CurrentMatch() callers have to pass in a nullptr
for the out-parameter, since they do not need the alternate navigation
URL. Simplify this situation by renaming CurrentMatch() to
CurrentMatchAndAlternateNavUrl() to better describe what it actually
does. Then add a new CurrentMatch() that does not have an out-parameter.
It simply wraps CurrentMatchAndAlternateNavUrl(). Then update
CurrentMatch() callers appropriately.
Along the way, also update ui_test_utils::SendToOmniboxAndSubmit() to
use std::string_view instead of std::string.
Change-Id: I6ab95e8412a3542b5e4e95dc412923e7c9908a97
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7008660
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: manuk hovanesian <manukh@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1525098}
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/12fc15823a476304996ed4ea31d17521808b4d6d
commit 12fc15823a476304996ed4ea31d17521808b4d6d
Author: Fred Shih <ffred@chromium.org>
Date: Fri Oct 3 13:36:04 2025 -0700
Add ts typemap for string16
This typemap converters string16 to string and vice versa
automatically. String16 should be completely opaque to ts users after
this.
Unfortunately it is not possible to partial migrations because of how
the bindings are generated. It is a risky change, but we shouldn't have
too many of these mega changes. Url would probably be the next big one.
Fixed: 431824282
Change-Id: I4f5f74ae103b583a50f97ce326fb070f748343c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6987362
Reviewed-by: Michael Cui <mlcui@google.com>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Fred Shih <ffred@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1524994}
This migration has been effected in upstream, but several places in our
codebase got broken by this transition. This change makes several parts
of our codebase more friendly to passing `string_view`.
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/0e1784e3cf990560b173f40338e582f50aba0e85
commit 0e1784e3cf990560b173f40338e582f50aba0e85
Author: Charlie Harrison <csharrison@chromium.org>
Date: Fri Oct 3 11:04:26 2025 -0700
RELAND: Migrate GURL::path() and friends to return string_view
This relands crrev.com/c/7003625. Missing cases were found by staring
at the output of `git grep` for the whole codebase.
Origin description:
Also migrates some last remaining callers of the std::string APIs.
This completes phase 1 of crbug.com/448174617.
Bug: 448174617
Change-Id: I7f24f81d1fbf129d8b0dd94f4cf948626deab933
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7007010
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1524878}
Error fixed:
../../chrome/browser/android/preloading/android_prerender_manager.cc:56:39: error: no member named 'new_tab_page_preload_pipeline_manager' in 'tabs::TabFeatures'
56 | return tab ? tab->GetTabFeatures()->new_tab_page_preload_pipeline_manager()
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/8965a614fb0e5c650f888a8644bbbfa9ae433635
commit 8965a614fb0e5c650f888a8644bbbfa9ae433635
Author: Robert Lin <robertlin@chromium.org>
Date: Wed Oct 1 20:18:36 2025 -0700
Migrate NewTabPagePreloadPipelineManager to TabFeatures
According to `docs/chrome_browser_design_principles.md`, TabFeatures
is preferred for all tab-centric features. This CL migrates
NewTabPagePreloadPipelineManager to TabFeatures
Bug: 421941586
Change-Id: Id48373979e7b6750e24c3bc60365a0760bf252ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6980603
Reviewed-by: Tom Lukaszewicz <tluk@chromium.org>
Commit-Queue: Huanpo Lin <robertlin@chromium.org>
Reviewed-by: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1523984}
This used to be a `std::string`.
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/79167e224d3cd322af1031bb0124212580e7cde8
commit 79167e224d3cd322af1031bb0124212580e7cde8
Author: Jaewon Jung <jw.jung@navercorp.com>
Date: Thu Oct 2 19:04:02 2025 -0700
Use std::u16string for Extension::Create() error parameter
The `Extension::Create()` method and its callers used `std::string` for
the error output parameter, leading to unnecessary conversions between
UTF-8 and UTF-16.
This change migrates the error parameter to `std::u16string` across
the call stack. This eliminates string conversions, simplifying the
code and improving consistency. In a few places where a `std::string`
is still required, a temporary conversion is performed.
Signed-off-by: Jaewon Jung <jw.jung@navercorp.com>
Bug: 41317803
Change-Id: Ia660ca60834f233eca82e8f2b65961cce48230d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6975452
Reviewed-by: Devlin Cronin <rdevlin.cronin@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1524554}
Claudio DeSouza