Claudio DeSouza
34bb26e4e1
This method is now an abstract method from `LocationBar`, which makes the virtual patching unnecessary. Another aspect in this CL is that `ToolbarView::location_bar_` got renamed to `location_bar_view_`, and a different `location_bar_` member was introduced in its place. This change corrects all references to the new name. Chromium changes: https://chromium.googlesource.com/chromium/src/+/da5f63b7460799641c75c85ad8cc792118a22a02 commit da5f63b7460799641c75c85ad8cc792118a22a02 Author: Maks Orlovich <morlovich@chromium.org> Date: Thu Jan 15 06:10:29 2026 -0800 Shift some LocationBarView dependencies to LocationBar... ... to permit a different implementation of LocationBar based on WebUI. As part of prep work this also tries to split up uses in ToolbarView between those that are likely views impl specific and those that are likely cross-impl. Some of those guesses may turn out wrong; but this should bring us closer to being able to start an implementation that can then make the definite judgement. Heavily based on Paul Jensen's https://chromium-review.googlesource.com/c/chromium/src/+/7445719 Bug: 474582476 Change-Id: Ia36162c004954c27f1fbe75e4eb6dcdd439eebbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7452590 Reviewed-by: Tom Lukaszewicz <tluk@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/main@{#1569691}
Brave Core
Brave Core is a set of changes, APIs, and scripts used for customizing Chromium to make the Brave browser. Please also check https://github.com/brave/brave-browser
Follow @brave on Twitter for important announcements.
Resources
Community
You can ask questions and interact with the community in the following locations:
- Brave Community
communitychannel on Brave Software's Slack