Max Karolinskiy
3bed74eee7
These features are now turned on by default upstream and they cause BrowserViewLayout::CreateLayout to create BrowserViewTabbedLayoutImpl layout which we don't override yet and our BraveBrowserViewLayout doesn't get created, but because of overrides elsewhere this causes crashes in layout. Chromium change: https://chromium.googlesource.com/chromium/src/+/838d53b6116eea2fe8c3925706c935ed4c215ae6 commit 838d53b6116eea2fe8c3925706c935ed4c215ae6 Author: Dana Fried <dfried@chromium.org> Date: Tue Nov 25 14:10:38 2025 -0800 Reland "[Chrome Next] Enable new layout with THSB support by default" This reverts commit 7f022b6ba56e1d6db06ea7db3cb877db8db99645. Reason for revert: Disable test that was flaking on Mac (see attached bug for further details). Also fixes an incorrect calculation that could cause a test to fail on Linux depending on how Widgets are rendered on a particular bot. Original change's description: > Revert "[Chrome Next] Enable new layout with THSB support by default" > > This reverts commit 76dd43c1e46b85047fe11d0b48d1df7cd9103365. > > Reason for revert: Suspected to cause > HelpBubbleFactoryWebUIInteractiveUiTest.* failures > https://ci.chromium.org/ui/p/chrome/builders/ci/mac-rel-ready/40022/overview > > Original change's description: > > [Chrome Next] Enable new layout with THSB support by default > > > > This turns on the new layout for tabbed browsers that enables > > Toolbar Height Side Panel by default. > > > > The flag is still configurable via chrome://flags, and can be used as > > an emergency killswitch if something goes terribly wrong. > > > > Bug: 453717426 > > Change-Id: Ib2e5cb469444efe50c5fd2a3d4650e22a102f0f2 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7185002 > > Commit-Queue: Dana Fried <dfried@chromium.org> > > Auto-Submit: Dana Fried <dfried@chromium.org> > > Reviewed-by: Eshwar Stalin <estalin@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#1549207} > > Bug: 453717426
Brave Core
Brave Core is a set of changes, APIs, and scripts used for customizing Chromium to make the Brave browser. Please also check https://github.com/brave/brave-browser
Follow @brave on Twitter for important announcements.
Resources
Community
You can ask questions and interact with the community in the following locations:
- Brave Community
communitychannel on Brave Software's Slack