T

Emerick Rogul 3caaa1e17f [cr145] Fix warnings about redefining computed properties in delete browsing data dialog

As upstream continues to work on rearchitecting the delete browsing data dialog,
we encountered the following warnings when visiting the dialog in cr145:

  polymer_bundled.min.js:1 Cannot redefine computed property 'isSyncPaused_'.
  polymer_bundled.min.js:1 Cannot redefine computed property 'hasPassphraseError_'.
  polymer_bundled.min.js:1 Cannot redefine computed property 'hasOtherSyncError_'.
  polymer_bundled.min.js:1 Cannot redefine computed property 'googleSearchHistoryString_'.

This is because we override `properties()` using a spread of the base class
properties, which ends up redefining them.

Remove the spread of base class properties and initialize Brave-specific fields
in the constructor instead. This avoids redeclaring inherited computed
properties, which caused runtime Polymer errors, while keeping TypeScript type
checking happy. The change ensures new instance properties are added safely
without breaking inherited behavior.

2026-01-29 13:41:20 -05:00

.github

Run upstream tests on filters change (#33333 )

2026-01-21 12:14:36 +00:00

.storybook

[storybook]: Fix preprocessor expressions for ForkTsChecker (#33404 )

2026-01-27 08:42:47 +13:00

android

[cr145][Android][Icons] Update ic_help_24dp

2026-01-29 13:41:19 -05:00

app

[cr145] Several feature flags now part of kSideBySide

2026-01-29 13:40:55 -05:00

base

…

brave_domains

[cr145][Android] Add DEFINE_JNI macro to the end of every file (part 1)

2026-01-29 13:40:19 -05:00

browser

[cr145] Fix warnings about redefining computed properties in delete browsing data dialog

2026-01-29 13:41:20 -05:00

build

[cr145][Android] Updates star vector drawable

2026-01-29 13:41:19 -05:00

chromium_src

[cr145][Windows][Installer] kPotentialFileAssociations is now wstrings.

2026-01-29 13:41:17 -05:00

common

Configure unique GUIDs, installer names, and update paths for Brave Origin (#33184 )

2026-01-29 13:13:05 -05:00

components

[cr145] native_widget_types => native_ui_types

2026-01-29 13:41:12 -05:00

content

Prevent blocked events from previous navigation showing up on new page (#33250 )

2026-01-22 16:13:59 +00:00

docs

[cr145][Android] Replace JavaParamRef -> JavaRef

2026-01-29 13:40:24 -05:00

elevation_service

…

extensions

…

fuzzers

Add enable_brave_news buildflag (#32852 )

2026-01-12 13:22:17 -05:00

gin

…

installer

[cr145][Windows][Installer] kPotentialFileAssociations is now wstrings.

2026-01-29 13:41:17 -05:00

ios

[cr145][ios] ScopeSet header deleted

2026-01-29 13:40:53 -05:00

mojo/brave_ast_patcher

…

net

…

patches

[cr145] Glic fix for TabStripActionContainer landed

2026-01-29 13:41:15 -05:00

renderer

[cr145] IWYU for callback_helpers.h

2026-01-29 13:40:34 -05:00

resources

…

rewrite

Fix memory leak in TabStyle::Get() (#33382 )

2026-01-26 20:01:46 +09:00

sandbox/win

…

script

[cr145] Adds RunNodeRaw to brave_node.

2026-01-29 13:40:37 -05:00

services

…

test

[cr145] gcm was modularized.

2026-01-29 13:41:10 -05:00

third_party

[cr145] Force-enable googlechrome siso config for Brave RBE builds.

2026-01-29 13:41:20 -05:00

tools

[cr145] Updates lit mangler snapshot.

2026-01-29 13:41:10 -05:00

Settings move searchbar (#33235 )

2026-01-25 19:54:17 -03:00

updater

…

utility

Disable Brave Ads for Brave Origin (#33309 )

2026-01-27 13:32:06 -05:00

…

vendor/brave_base

…

win_build_output

…

.brave_gclient

…

.clang-tidy

…

.clangd

…

.eslintrc.js

…

.git-blame-ignore-revs

…

.gitallowed

…

.gitattributes

standardize diff handling for mm files to match what is currently in … (#33246 )

2026-01-16 06:07:10 -07:00

.gitignore

…

.prettierignore

Format components/brave_adblock_ui/ (#32832 )

2026-01-12 20:38:42 +04:00

.prettierrc.js

…

.semgrepignore

…

.sonarcloud.properties

…

.style.yapf

…

.yapfignore

…

brave_paks.gni

…

brave_repack_locales.gni

…

BUILD.gn

Fix Windows build when enable_brave_vpn is false and create_dist (#33372 )

2026-01-23 10:29:27 -05:00

chromium_presubmit_config.json5

…

codereview.settings

…

CONTRIBUTING.md

…

DEPS

Bump lodash from 4.17.21 to 4.17.23 (#33359 )

2026-01-22 12:23:59 +00:00

jest.config.js

[webpack]: Add support for preprocessor expressions (#32922 )

2026-01-13 23:50:18 +13:00

LICENSE

…

LICENSE.html

…

package-lock.json

1.88.80

2026-01-29 17:00:59 +00:00

package.json

[cr145] Remove Siso version enforcement.

2026-01-29 13:41:20 -05:00

PRESUBMIT.py

Reland - Move replacement files for chromium resources to their own directory (#33204 )

2026-01-14 19:44:13 +00:00

README.md

…

snapcraft.yaml

1.88.80

2026-01-29 17:00:59 +00:00

tsconfig-jest.json

…

tsconfig-lint.json

…

tsconfig-mangle.json

…

tsconfig-storybook.json

…

tsconfig-webpack.json

…

tsconfig.json

…

README.md

Brave Core

Brave Core is a set of changes, APIs, and scripts used for customizing Chromium to make the Brave browser. Please also check https://github.com/brave/brave-browser

Follow @brave on Twitter for important announcements.

Resources

Community

You can ask questions and interact with the community in the following locations:

Brave Community
community channel on Brave Software's Slack