Emerick Rogul
5145be6b18
Signing with `--skip_signing` stopped working on Mac due to the following upstream commit. This happened because we override the behavior of `run_command` to scrub signing-related commands/arguments from the command-line when `--skip_signing` is passed. However, this upstream commit added a new async function named `run_command_all_output_async` which also needs to be scrubbed. Chromium change: https://source.chromium.org/chromium/chromium/src/+/8062ee35c902563309983726a37b90d5ca10caed commit 8062ee35c902563309983726a37b90d5ca10caed Author: Joshua Pawlicki <waffles@chromium.org> Date: Tue Jul 15 10:45:21 2025 -0700 mac signing: Parallelize some per-distribution operations. This may speed up the per-distribution section of signing by up to 45%. codesign --verify and spctl --assess will now run in parallel. This is expected to provide a speed-up up to 20% depending on I/O throughput. The app bundle needs to be zipped prior to notarization. Previously, the execution would wait for zipping to be complete and then start notarization in the background (while continuing in parallel with processing the next distribution). Now, the zipping is also done in the background while execution moves on to the next distribution. This could provide a speed-up of up to 25% depending on I/O vs CPU bottlenecks. Bug: 426019706 Change-Id: I0a054c43c2b51f56abd0a94e78a9caf337a2a216 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6699494 Commit-Queue: Mark Mentovai <mark@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/main@{#1487061}
Brave Core
Brave Core is a set of changes, APIs, and scripts used for customizing Chromium to make the Brave browser. Please also check https://github.com/brave/brave-browser
Follow @brave on Twitter for important announcements.
Resources
Community
You can ask questions and interact with the community in the following locations:
- Brave Community
communitychannel on Brave Software's Slack