Claudio DeSouza
5b2e60ef87
In `cr137` there was a fix to address the addtion of a new `IsFullCookieAccessAllowed` overload. This however didn't correct the corresponding `IsEphemeralCookieAccessAllowed` overloads, which is now running into issues in M138. This change makes them both match Chromium changes: https://chromium.googlesource.com/chromium/src/+/18fb94f3c165cd93f3a74af6dded31e1f4770ed6 https://chromium.googlesource.com/chromium/src/+/78f06c4ae118f70021a4e6ed143f59df129cf2ad commit 18fb94f3c165cd93f3a74af6dded31e1f4770ed6 Author: Joshua Thomas <masnoble@chromium.org> Date: Mon Apr 14 11:31:40 2025 -0700 Add cookie partition key to `IsFullCookieAccessAllowed` check. This adds a new overload for `IsFullCookieAccessAllowed` which will return the proper `false` for Fenced Frames and Credentialless iFrames, which both carry a nonced cookie partition key. One important fix this makes is assigning the correct `StorageAccessStatus` is returned for these anonymous contexts. Bug: 399826579 Change-Id: Iff244ecf552f3759ca9d65aa0b43b1cb95ff920a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6391755 Feels: Chris Fredrickson <cfredric@chromium.org> Reviewed-by: Chris Fredrickson <cfredric@chromium.org> Reviewed-by: Christian Dullweber <dullweber@chromium.org> Commit-Queue: Joshua Thomas <masnoble@chromium.org> Reviewed-by: Maks Orlovich <morlovich@chromium.org> Reviewed-by: Ari Chivukula <arichiv@chromium.org> Cr-Commit-Position: refs/heads/main@{#1446671} commit 78f06c4ae118f70021a4e6ed143f59df129cf2ad Author: Joshua Thomas <masnoble@chromium.org> Date: Thu May 8 14:08:42 2025 -0700 Migrate to new `IsFullCookieAccessAllowed` overload This CL is part of a larger effort to update all callsites of `IsFullCookieAccessAllowed` to a new overload that includes a CookiePartitionKey parameter. This CL was uploaded by git cl split. Split from: http://crrev.com/c/6519872 Bug: 399826579 Change-Id: I4230723dda16b360f0f785da42d3bb6bde292f6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6514497 Commit-Queue: Maks Orlovich <morlovich@chromium.org> Auto-Submit: Joshua Thomas <masnoble@chromium.org> Reviewed-by: Maks Orlovich <morlovich@chromium.org> Reviewed-by: Chris Fredrickson <cfredric@chromium.org> Cr-Commit-Position: refs/heads/main@{#1457810}
Brave Core
Brave Core is a set of changes, APIs, and scripts used for customizing Chromium to make the Brave browser. Please also check https://github.com/brave/brave-browser
Follow @brave on Twitter for important announcements.
Resources
Community
You can ask questions and interact with the community in the following locations:
- Brave Community
communitychannel on Brave Software's Slack