cdesouza-chromiumandAleksey Khoroshilov
5d05b50d9e
* DCHECK tests using EXPECT_DEATH This change updates the only DCHECK test we have to rely on EXPECT_DEATH, as `logging::ScopedLogAssertHandler` will not be able to prevent termination in coming upstream updates. Chromium change: https://chromium.googlesource.com/chromium/src/+/2cc59dab0e60c52aa7e1aca45d97992fdfc5a6dd commit 2cc59dab0e60c52aa7e1aca45d97992fdfc5a6dd Author: Peter Boström <pbos@chromium.org> Date: Sat Feb 18 08:13:24 2023 +0000 (Partial) Make sure CHECK() failures crash This partial land excludes iOS and Windows where two tests currently rely on aborting a LOG(FATAL). This is going in to not backslide in platform-agnostic code. This is trying to make sure that CHECK failures effectively don't return before LOG(FATAL) is properly [[noreturn]]. A follow-up could be to split out CheckError from DcheckError to make sure the destructor can be marked [[noreturn]]. Note that this doesn't apply to the optimized version of CHECK which is already a [[noreturn]] function call, but also doesn't involve LOG(FATAL). Bug: 1409729 * Add another test to check both DCHECKs. --------- Co-authored-by: Aleksey Khoroshilov <akhoroshilov@brave.com>
Brave Core
Brave Core is a set of changes, APIs, and scripts used for customizing Chromium to make the Brave browser. Please also check https://github.com/brave/brave-browser
Follow @brave on Twitter for important announcements.
Resources
Community
You can ask questions and interact with the community in the following locations:
- Brave Community
communitychannel on Brave Software's Slack