79cc97c87f331a70f6d3f552e2d9d77228ecfb94
Fix intermittent test failure caused by race condition between tool execution completion and pause button click timing. The original test used the real navigation tool which executes asynchronously. If navigation completed before the pause button was clicked, GenerateAssistantResponse would be called, violating the Times(0) expectation. Fix by using a MockTool that captures its callback, allowing the test to control exactly when the tool execution completes. The tool now completes after pause is clicked, verifying that generation is correctly skipped while paused. Key changes: - Replace navigation tool with MockTool for controlled timing - Capture tool callback and complete it after pause - Verify generation is skipped while in paused state - Remove tab-related checks that don't apply with mock tool Resolves brave/brave-browser#51130
[Android] Fixes a crash in FaviconUtils.getIconDrawableWithFilter when an icon is not available for a particular URL by falling back to the default globe icon. (#33569)
…
[Android] Fixes a crash in FaviconUtils.getIconDrawableWithFilter when an icon is not available for a particular URL by falling back to the default globe icon. (#33569)
…
…
…
…
…
…
…
…
…
…
…
…
…
…
…
…
…
Brave Core
Brave Core is a set of changes, APIs, and scripts used for customizing Chromium to make the Brave browser. Please also check https://github.com/brave/brave-browser
Follow @brave on Twitter for important announcements.
Resources
Community
You can ask questions and interact with the community in the following locations:
- Brave Community
communitychannel on Brave Software's Slack
Languages
C++
36.9%
HTML
31.6%
Swift
9.4%
TypeScript
9%
Java
4.8%
Other
8.1%