Claudio DeSouza
800bd25c72
Chromium changes: https://chromium.googlesource.com/chromium/src/+/0eda25f638d92e3fe8c5598516539bee3cdb086c commit 0eda25f638d92e3fe8c5598516539bee3cdb086c Author: dljames <dljames@chromium.org> Date: Tue Nov 25 11:51:35 2025 -0800 [TBHSP] Update SidePanelAnimationCoordinator's Observer API This CL updates the SidePanelAnimationCoordinator's Observer API to be more granular in the types of updates it can notify its observers. API Changes: - Added OnAnimationTypeStarted and OnAnimationTypeEnded The OnAnimationType* functions were added to separate observers who care about specific animation sequences, from those that care about the type of animation being performed. These additions will allow observers the ability to perform prerequisite or cleanup tasks before and after the main animation has completed. For example, at the end of an animation you may want to reparent a specific view, or set some state before the animation starts. Additionally, OnAnimationType functions can only be subscribed to by using the animation type AddObserver/RemoveObserver functions. This allows further separation by allowing observers to listen to either animation sequence progress updates, or animation type updates, or both. OnAnimationSequenceEnded was not implemented as the naming suggests. It was effectively telling observers that the main animation timeline had ended and not the individual sequences. This function has been updated to notify observers when a specific sequence tied to an animation id has finished. This can happen at any point between the start and end of the main animation timeline. Tests has been added to verify the new behavior. Change-Id: I931e5e5dc6d9085e7b63e61eeacc945e4078664b Bug: 445452247 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7180522 Reviewed-by: Eshwar Stalin <estalin@chromium.org> Commit-Queue: Darryl James <dljames@chromium.org> Reviewed-by: Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/main@{#1549973}
Brave Core
Brave Core is a set of changes, APIs, and scripts used for customizing Chromium to make the Brave browser. Please also check https://github.com/brave/brave-browser
Follow @brave on Twitter for important announcements.
Resources
Community
You can ask questions and interact with the community in the following locations:
- Brave Community
communitychannel on Brave Software's Slack