Sangwoo Ko
8d0433253d
The core infrastructure for vertical tabs has been removed from upstream * Split tab - CompoundTabContainer which contains pinned contrainer and unpinned container separately is removed. * Scrollable tab strip support was removed - TabStripScrollContainer was removed. This PR temporarily make Brave buildable and disables vertical tab strip support As CompoundTabContainer is gone, rework BraveTabContainer to handle both pinned and unpinned tabs. Previously, we had CompoundTabContainer which contains two TabContainers , one for pinned tabs and the other for unpinned tabs. And TabContainer for unpinned tabs had a ScrollView to allow scrolling when there are many unpinned tabs. But now, as CompoundTabContainer is removed, we need to handle both pinned and unpinned tabs in BraveTabContainer. Plus, we should support scrolling feature for unpinned tabs. But adding scroll view to BraveTabContainer causes various issues as it manipulates view hierarachy, which upstream code is not aware of. As a result, it'd require many changes from our side to make it work. So instead of adding scroll view, we directly handle scrolling logic inside BraveTabContainer. BraveTabContainer calculates visable area for unpinned tabs and sets clip rect accordingly. It also handles scroll events and update unpinned tabs position based on the offset.
Brave Core
Brave Core is a set of changes, APIs, and scripts used for customizing Chromium to make the Brave browser. Please also check https://github.com/brave/brave-browser
Follow @brave on Twitter for important announcements.
Resources
Community
You can ask questions and interact with the community in the following locations:
- Brave Community
communitychannel on Brave Software's Slack