Emerick Rogul
a488ed37fd
Delay initial CrViewManager.switchViews() call until after first render so all view elements are stamped before switching. This avoids assertion failures introduced by stricter upstream invariants when views are conditionally stamped or not yet attached during early lifecycle. Chromium change: https://source.chromium.org/chromium/chromium/src/+/e6b2721218aea18372be7c12cfe9879faf5b80a1 commit e6b2721218aea18372be7c12cfe9879faf5b80a1 Author: dpapad <dpapad@chromium.org> Date: Tue Nov 18 15:22:36 2025 -0800 WebUI: Prevent cr-view-manager events firing when not needed. When calling switchView() or switchViews() with an already active view, cr-view-manager was unnecessarily firing 'view-enter-start', 'view-enter-finish', 'view-exit-start', 'view-exit-finish' events, which in turn caused a bug in Settings where focusBackButton() was called in SettingsViewMixin when it shouldn't (when searching in <all-sites>). The cr-view-manager behavior when switching to already active views had been modified at crrev.com/c/6696849, so this CL effectively restores the old "early return no-op" behavior. Fixed: 460732312 Change-Id: If71cd7084a267a52539464f5e3e2a45ba3dc49e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7169474 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: John Lee <johntlee@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/main@{#1546843}
Brave Core
Brave Core is a set of changes, APIs, and scripts used for customizing Chromium to make the Brave browser. Please also check https://github.com/brave/brave-browser
Follow @brave on Twitter for important announcements.
Resources
Community
You can ask questions and interact with the community in the following locations:
- Brave Community
communitychannel on Brave Software's Slack