aef842e09bcf9aa43236afb181ffa764bb1c5ff8
Shields button should be clickable always. This bug is regression from controlling enable/disable shields button. To fix this, shields button should be always enabled. The purpose of disabling shields button was preventing shields button click when tab is not ready. So, instead of disabling shields button, just return when current tab is null during the handling of click. And enable/disableShieldsButton methods are integrated into updateBraveShieldsButtonState(). Also, shields popup will be displayed only for http/https protocols.
…
…
…
…
Brave Core
Brave Core is a set of changes, APIs, and scripts used for customizing Chromium to make Brave.
Follow @brave on Twitter for important announcements.
Resources
Community
You can ask questions and interact with the community in the following locations:
- The Brave Community
communitychannel on Brave Software's Slackdevelopers-bravechannel in our Brave Discord server
Languages
C++
36.9%
HTML
31.6%
Swift
9.4%
TypeScript
9%
Java
4.8%
Other
8.1%