Mario Sanchez Prada
b7e4c1a82f
We had made services.cc depend on //brave/utility via a chromium_src override, but that caused a dependency cycle because //brave/utility also depends on //chrome/utility (e.g. extend some upstream classes), causing a gn check error. To fix this, we can follow the pattern used in other places and make upstream's //chrome/utility directly include the files from Brave that it needs, and replace the oneliner patch to //chrome/utility/BUILD.gn with one that would simply include those sources, instead of having it depend on //brave/utility. Last, we also add a missing dep on //brave/common/importer:importer to avoid another gn check failure due to having some files from that target included from brave_external_process_importer_bridge.h. Resolves https://github.com/brave/brave-browser/issues/10623
Brave Core
Brave Core is a set of changes, APIs, and scripts used for customizing Chromium to make Brave.
Follow @brave on Twitter for important announcements.
Resources
Community
You can ask questions and interact with the community in the following locations:
- Brave Community
communitychannel on Brave Software's Slack