All toolbar variants (upstream and Brave) are persisted to SharedPreferences as integers.
Upstream guards against shifts by using explicit numeric assignments in the header.
Brave values must do the same — if they are defined implicitly and upstream inserts a new entry above them, the whole range shifts and users lose their saved setting.
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/c6ef9d2f680a39f97473af883b8fc394b581b6c0
commit c6ef9d2f680a39f97473af883b8fc394b581b6c0
Author: Bhuvana Betini <bbetini@google.com>
Date: Thu Feb 12 09:55:15 2026 -0800
[Glic] Add CPA toolbar entrypoint
This CL implements a baseline CPA entrypoint for Glic on Android. It
introduces the GlicToolbarButtonController to manage UI and on-click
handling. Also, it introduces the GlicActionProvider for future
conditional cueing logic. The dataflow integrates Glic into the
segmentation platform model to allow for conditional button display and
registers the new button type in histogram metrics for tracking.
Because the flag is not by set by native and the button is added to
the toolbar, a Cached Flag is used to prevent NPEs for unit tests.
In future CLs, the Glic button will have proper styling, be hooked up to
bottom sheet, and use data from contextual_cueing_service to be
conditionally shown.
Bug: 475590295
Change-Id: Ic31cd0c7ab1428abc679e330e6da86cb8531914c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7551433
Reviewed-by: Salvador Guerrero Ramos <salg@google.com>
Commit-Queue: Bhuvana Betini <bbetini@google.com>
Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1584071}
samartnik
05208f0893