mkarolin c70040567d MenuItemView::HasIcons was removed.
Chromium change:

https://chromium.googlesource.com/chromium/src/+/0d0322b87e3fcfe9f0878f08b3887cd7b41ed3cf

commit 0d0322b87e3fcfe9f0878f08b3887cd7b41ed3cf
Author: Peter Kasting <pkasting@chromium.org>
Date:   Tue Aug 8 19:24:23 2023 +0000

    More consistent icon handling for menus.

    * Eliminate MenuItemView::set_has_icon(); make all menus consider icon
      state. This was a footgun.
    * For height consistency, menu items without icons would have a minimum
      height of the check height if any items had icons. This is now
      better-documented, applied even to items _with_ icons (in case
      their icons are small), and not applied to separators (which have
      their own min-height config values).
    * System menus on Windows were marked as owner-draw if they had icons,
      but we didn't do any custom owner drawing. Never owner-draw these.

    This then simplifies/cleans up as a result of the above.

    Bug: none
2023-09-06 12:38:51 +01:00
2023-09-06 12:38:49 +01:00
2023-09-06 12:38:49 +01:00
2023-09-06 12:38:44 +01:00
2023-09-06 12:38:49 +01:00

Brave Core

Brave Core is a set of changes, APIs, and scripts used for customizing Chromium to make the Brave browser. Please also check https://github.com/brave/brave-browser

Follow @brave on Twitter for important announcements.

Resources

Community

You can ask questions and interact with the community in the following locations:

S
Description
No description provided
Readme MPL-2.0
3.8 GiB
Languages
C++ 36.9%
HTML 31.6%
Swift 9.4%
TypeScript 9%
Java 4.8%
Other 8.1%