d1099835d87d37dc4e4c02f984299eb32561b6c5
SidePanel from the build (#25721)
`BraveSidePanel` acts as a complete replacement to chromium's `SidePanel` type, however the upstream type has never been properly excluded from the build. This leads occasional breaks where new references to `SidePanel` appear in different places, and new overrides have to be introduced to correct those occurrences. This change entirely removes side panel from being built by exluding the particular headers/UT from being imported through their respective shadow files. This will no only reduce the number of places where we have to honour the token replacements, which means less build breakage going foward, but it will also prevent ODR violation bugs from occurring, which can be a particularly nasty type of UB.
…
…
…
…
…
…
…
…
…
…
…
Brave Core
Brave Core is a set of changes, APIs, and scripts used for customizing Chromium to make the Brave browser. Please also check https://github.com/brave/brave-browser
Follow @brave on Twitter for important announcements.
Resources
Community
You can ask questions and interact with the community in the following locations:
- Brave Community
communitychannel on Brave Software's Slack
Languages
C++
36.9%
HTML
31.6%
Swift
9.4%
TypeScript
9%
Java
4.8%
Other
8.1%