Claudio DeSouza
ead3032dbb
This extra arg has been added to the original function and is being plumbed into the override as well. Chromium changes: https://chromium.googlesource.com/chromium/src/+/3e9801630f7a3697936eb90d31185542abd8f60c commit 3e9801630f7a3697936eb90d31185542abd8f60c Author: Carlos IL <carlosil@chromium.org> Date: Wed May 7 18:32:19 2025 -0700 Mixed Content: Use the same check for ShouldAutoUpgrade and IsMixedContent Currently IsMixedContent determines whether mixed content is restricted in a particular context by checking if its security origin or precursor if opaque is https (https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/loader/mixed_content_checker.cc;drc=8d201f296ea4efda4529e69fd9509be8abd63156;l=293), whereas ShouldAutoupgrade only checks the security origin, which is null if opaque (https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/loader/mixed_content_checker.cc;drc=8d201f296ea4efda4529e69fd9509be8abd63156;l=867). This can lead to some requests not being autoupgraded when they should be. Bug: 40062462 Change-Id: I10c381e407a0693ae262533027fad9e2c37fa365 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6388538 Auto-Submit: Carlos IL <carlosil@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/main@{#1457364}
Brave Core
Brave Core is a set of changes, APIs, and scripts used for customizing Chromium to make the Brave browser. Please also check https://github.com/brave/brave-browser
Follow @brave on Twitter for important announcements.
Resources
Community
You can ask questions and interact with the community in the following locations:
- Brave Community
communitychannel on Brave Software's Slack