Mario Sanchez Prada
ef0275fb43
We need to disable upstream's IsDuplicateOf() via a define above and re-declare it to workaround the fact that the first parameter of the upstream method will change into PermissionRequest_ChromiumImpl too. Chromium change: https://chromium.googlesource.com/chromium/src.git/+/d7e4d44c73251333f1c9163480208033ace4bdbc commit d7e4d44c73251333f1c9163480208033ace4bdbc Author: Bret Sepulveda <bsep@chromium.org> Date: Tue Apr 20 13:46:41 2021 +0000 Miscellaneous permissions cleanup. This patch: * Introduces a new method PermissionRequest::IsDuplicateOf, rather than relying on comparing the result of GetMessageTextFragment (which returns a human-readable string) to determine whether two requests are duplicates. * Makes PermissionRequest::GetMessageTextFragment desktop-only, as it was only used elsewhere in the aforementioned duplicates logic. * Uses std::u16string in MockPermissionRequest everywhere. * And deletes a few bits of unused code. Bug: 1110905
Brave Core
Brave Core is a set of changes, APIs, and scripts used for customizing Chromium to make Brave.
Follow @brave on Twitter for important announcements.
Resources
Community
You can ask questions and interact with the community in the following locations:
- Brave Community
communitychannel on Brave Software's Slack